[release/11.0.1xx-preview2] Fix NullReferenceException when binding to Dictionary<Enum, object> with x:DataType#34244
Closed
github-actions[bot] wants to merge 2 commits intorelease/11.0.1xx-preview2from
Conversation
…ith x:DataType Fixes #13856 Using with a binding to like caused a NullReferenceException at compile time in XamlC. - **XamlC (SetPropertiesVisitor.cs)**: Added support for finding indexers with enum parameter types and emitting enum constant values via IL - **SourceGen (CompiledBindingMarkup.cs)**: Added support for enum indexer parameter types in the binding path parser - Added enum indexer detection in XamlC's property digger - Updated type validation to allow enum indexer types - Added code to emit enum constant values as IL instructions - Added enum indexer support in SourceGen's TryParsePath method - Fixed pre-existing test failure in Maui32879Tests (unrelated pragma warning directive) - Added Maui13856.xaml unit test for XamlC compilation - Added Maui13856Tests.cs for SourceGen validation
- Add diagnostic + early return when enum member name is not found in the enum type - Update test to assert fully qualified enum member (per simonrozsival review) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32916 to release/11.0.1xx-preview2
/cc @StephaneDelcroix