Skip to content

[Windows] Fix modal page keyboard focus not shifting to newly opened modal#34212

Merged
jfversluis merged 10 commits into
inflight/currentfrom
fix/modal-keyboard-focus-22938
Mar 5, 2026
Merged

[Windows] Fix modal page keyboard focus not shifting to newly opened modal#34212
jfversluis merged 10 commits into
inflight/currentfrom
fix/modal-keyboard-focus-22938

Cache and restore original IsHitTestVisible on modal pop

20faf34
Select commit
Loading
Failed to load commit list.
Azure Pipelines / maui-pr failed Mar 5, 2026 in 8h 55m 11s

Build #10.0.50-ci+pr.34212.azdo.1321646 had test failures

Details

Tests

  • Failed: 22 (0.12%)
  • Passed: 17,561 (99.11%)
  • Other: 136 (0.77%)
  • Total: 17,719

Annotations

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item Microsoft.Maui.Controls.Core.UnitTests.dll in job 2492f212-a9f9-484e-a1a2-be35fc69585f has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/2492f212-a9f9-484e-a1a2-be35fc69585f/workitems/Microsoft.Maui.Controls.Core.UnitTests.dll/console

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item Microsoft.Maui.Controls.Core.UnitTests.dll in job ddef7cff-9a7a-46f0-b41d-1bb4831f9134 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/ddef7cff-9a7a-46f0-b41d-1bb4831f9134/workitems/Microsoft.Maui.Controls.Core.UnitTests.dll/console

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item Microsoft.Maui.Controls.Core.UnitTests.dll in job ffc3f521-c969-483c-a917-1d3551eb0891 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/ffc3f521-c969-483c-a917-1d3551eb0891/workitems/Microsoft.Maui.Controls.Core.UnitTests.dll/console

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25555.106\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item Microsoft.Maui.Controls.Core.UnitTests.dll in job 7fa7dda0-5700-4e05-970e-d13234a1d662 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/7fa7dda0-5700-4e05-970e-d13234a1d662/workitems/Microsoft.Maui.Controls.Core.UnitTests.dll/console

Check failure on line 1 in DoesNotInheritBindingContextToContentFromControlTemplate

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

DoesNotInheritBindingContextToContentFromControlTemplate

Assert.Equal() Failure: Values differ
Expected: Test
Actual:   other context
Raw output
   at Microsoft.Maui.Controls.Core.UnitTests.ContentViewUnitTests.DoesNotInheritBindingContextToContentFromControlTemplate() in /_/src/Controls/tests/Core.UnitTests/ContentViewUnitTest.cs:line 544
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.Maui.Controls.Core.UnitTests.dll.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

Microsoft.Maui.Controls.Core.UnitTests.dll.WorkItemExecution

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in DoesNotInheritBindingContextToContentFromControlTemplate

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

DoesNotInheritBindingContextToContentFromControlTemplate

Assert.Equal() Failure: Values differ
Expected: Test
Actual:   other context
Raw output
   at Microsoft.Maui.Controls.Core.UnitTests.ContentViewUnitTests.DoesNotInheritBindingContextToContentFromControlTemplate() in /_/src/Controls/tests/Core.UnitTests/ContentViewUnitTest.cs:line 544
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.Controls.Core.UnitTests.dll.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / maui-pr

Microsoft.Maui.Controls.Core.UnitTests.dll.WorkItemExecution

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.