Add critical rule: agents must NEVER approve/request-changes on PRs#33885
Closed
kubaflo wants to merge 1 commit intodotnet:mainfrom
Closed
Add critical rule: agents must NEVER approve/request-changes on PRs#33885kubaflo wants to merge 1 commit intodotnet:mainfrom
kubaflo wants to merge 1 commit intodotnet:mainfrom
Conversation
- Add prominent warning section at top of pr-finalize skill - Add CRITICAL note to copilot-instructions.md AI agents should only post comments with findings. Approval and rejection decisions are reserved for human reviewers.
kubaflo
force-pushed
the
fix/pr-finalize-no-approve
branch
from
707fb6e to
5381908
Compare
kubaflo
added
the
area-ai-agents
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit safety guardrail to the pr-finalize skill documentation to ensure AI-driven workflows only provide feedback via comments and never make approval/blocking decisions via GitHub review flags.
Changes:
- Added a prominent “NEVER approve/request-changes” warning section to the top of the
pr-finalizeskill documentation. - Added a matching critical note in
.github/copilot-instructions.mdunder thepr-finalizeskill entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/skills/pr-finalize/SKILL.md |
Introduces a clear, early warning section forbidding gh pr review --approve and --request-changes, and clarifies the agent’s role as comment-only feedback. |
.github/copilot-instructions.md |
Reinforces the same rule at the skills index level so it’s visible even before opening the skill doc. |
Contributor
Author
|
closed in favour of #33861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Adds a critical safety rule to the
pr-finalizeskill: AI agents must NEVER use--approveor--request-changesflags when reviewing PRs.Why This Matters
During testing of PR #33861, an AI agent mistakenly ran
gh pr review --approve, which is inappropriate because:Changes Made
.github/skills/pr-finalize/SKILL.md.github/copilot-instructions.mdNew Warning Section
Issues Fixed
N/A - Safety improvement to agent workflow