Skip to content

Fixed: Missing diagnostic in SourceGen when Setter references non-BindableProperty - Candidate Failure Feb 2nd #33854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 1 commit into from
Feb 3, 2026
Merged

Fixed: Missing diagnostic in SourceGen when Setter references non-BindableProperty - Candidate Failure Feb 2nd #33854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Controls/src/SourceGen/SetterValueProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ public bool TryProvideValue(ElementNode node, IndentedTextWriter writer, SourceG
IFieldSymbol? bpRef = bpNode.GetBindableProperty(context);
if (!TryGetBindablePropertyNameAndType(bpRef, bpNode, context, out var bpName, out var bpType))
{
// Report diagnostic when bindable property cannot be resolved
var propertyText = bpNode.Value as string ?? string.Empty;
var location = LocationHelpers.LocationCreate(context.ProjectItem.RelativePath!, (IXmlLineInfo)bpNode, propertyText);
context.ReportDiagnostic(Diagnostic.Create(Descriptors.MemberResolution, location, propertyText));
value = string.Empty;
return false;
}
Expand Down
Loading