Improve skills and scripts for better agent workflows#33699
Merged
Conversation
Skills improvements: - try-fix: Streamlined from 346→281 lines, moved examples to references/ - pr-finalize: Enhanced description with triggers, moved example to references/ - verify-tests-fail: Added markdown report generation and PR-based output structure - learn-from-pr: Updated SKILL.md Script improvements: - EstablishBrokenBaseline.ps1: Added fail-fast dirty working directory check - Fails immediately if tracked files have uncommitted changes - Uses --untracked-files=no to avoid false positives from logs/artifacts - Guarantees baseline validity: if script succeeds, baseline was clean Other: - Updated pr agent documentation - Added android.instructions.md - Deleted obsolete skills.instructions.md
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves agent skills and scripts based on learnings from real agent sessions, making workflows more robust and user-friendly.
Changes:
- Enhanced verify-tests-fail skill with markdown report generation and PR-based output folder structure
- Streamlined try-fix skill from 346→281 lines by moving examples to references/
- Enhanced pr-finalize skill with better trigger phrases and quality preservation guidelines
- Added fail-fast dirty working directory check to EstablishBrokenBaseline.ps1
- Added new android.instructions.md with Android-specific development guidance
- Updated path references from
.github/agent-pr-session/toCustomAgentLogsTmp/PRState/throughout - Deleted obsolete skills.instructions.md (content moved to custom coding guidelines)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/skills/verify-tests-fail-without-fix/scripts/verify-tests-fail.ps1 |
Added PR number auto-detection, markdown report generation, and PR-based output directory structure |
.github/skills/verify-tests-fail-without-fix/SKILL.md |
Documented new output files and PR number detection features |
.github/skills/try-fix/SKILL.md |
Streamlined from 346→281 lines, strengthened "alternative-focused" principle, moved examples to references/ |
.github/skills/try-fix/references/*.md |
New reference files for output structure, examples, and compile error patterns |
.github/skills/pr-finalize/SKILL.md |
Enhanced description with trigger phrases and negative triggers, added quality preservation guidance |
.github/skills/pr-finalize/references/complete-example.md |
Moved 65-line example to references for progressive disclosure |
.github/skills/learn-from-pr/SKILL.md |
Updated session markdown path references |
.github/scripts/EstablishBrokenBaseline.ps1 |
Added fail-fast dirty working directory check, removed FixFiles parameter (auto-detect only) |
.github/instructions/skills.instructions.md |
Deleted (content moved to custom coding guidelines) |
.github/instructions/android.instructions.md |
New file with Android View namespace collision solutions and handler best practices |
.github/agents/pr.md |
Updated state file path references |
.github/agents/pr/post-gate.md |
Updated state file path references |
.github/skills/verify-tests-fail-without-fix/scripts/verify-tests-fail.ps1
Outdated
Show resolved
Hide resolved
.github/skills/verify-tests-fail-without-fix/scripts/verify-tests-fail.ps1
Outdated
Show resolved
Hide resolved
- Remove duplicate $ErrorActionPreference and $RepoRoot initialization - Add null-safe check for $MergeBase.Substring() calls
Added a section detailing how to save the PR finalization summary to a markdown file for tracking, including required content and file path. This helps standardize documentation and improve traceability of PR assessments.
kubaflo
force-pushed
the
skill-improvements
branch
from
2b1603e to
2c55cb9
Compare
kubaflo
approved these changes
Jan 25, 2026
Contributor
kubaflo
left a comment
kubaflo
left a comment
There was a problem hiding this comment.
Let's merge this PR before the comment-skill one, so that we can use files from the CustomAgentLogsTemp to generate comments
kubaflo
added
the
area-ai-agents
This was referenced Feb 12, 2026
Merged
Closed
Merged
Merged
Closed
This was referenced Feb 16, 2026
Open
Open
Closed
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR improves several agent skills and scripts based on learnings from real agent sessions.
Skills Improvements
Script Improvements
EstablishBrokenBaseline.ps1 - Added fail-fast dirty working directory check:
--untracked-files=noto avoid false positives from logs/artifactsOther
Issues Fixed
N/A - Infrastructure improvements