Skip to content

[Testing] Fix for flaky UITests in CI - 3 #33689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 5 commits into from
Feb 17, 2026
Merged

[Testing] Fix for flaky UITests in CI - 3 #33689

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b20033c
updated test sample
TamilarasanSF4853 Dec 31, 2025
420d6b6
added retry
TamilarasanSF4853 Jan 23, 2026
b15cd42
added changes
TamilarasanSF4853 Jan 23, 2026
055d7e3
added changes
TamilarasanSF4853 Jan 27, 2026
bdfa677
added android failing condition
TamilarasanSF4853 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue12134.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ private async void DisplayCookies()

private async void WebViewOnNavigated(object sender, WebNavigatedEventArgs e)
{
#if ANDROID
var result = await Task.FromResult(Android.Webkit.CookieManager.Instance?.GetCookie("https://dotnet.microsoft.com"));
#else
var result = await ((WebView)sender).EvaluateJavaScriptAsync("document.cookie");
#endif
_label.Text = result.Contains(_guid.ToString(), StringComparison.OrdinalIgnoreCase) ? "Success" : "Failed";

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android.Webkit.CookieManager.Instance?.GetCookie(...) can return null (or the Instance can be null), and the next line calls result.Contains(...), which will throw on Android. Please make the check null-safe and treat null/empty as "Failed".

Suggested change
_label.Text = result.Contains(_guid.ToString(), StringComparison.OrdinalIgnoreCase) ? "Success" : "Failed";
var success = !string.IsNullOrEmpty(result) && result.Contains(_guid.ToString(), StringComparison.OrdinalIgnoreCase);
_label.Text = success ? "Success" : "Failed";

Copilot uses AI. Check for mistakes.
}

Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.HostApp/Issues/Issue18452.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ protected override void Init()
Content = grid;
}
}
}
}
2 changes: 2 additions & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18420.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ public void ApplyingRotationWithZeroDurationShouldNotCrash()
{
App.WaitForElement("RotateButton");
App.Tap("RotateButton");
App.WaitForElement("RotateButton");
App.Tap("RotateButton");
App.WaitForElement("RotateButton");
App.Tap("RotateButton");
App.WaitForElement("RotateButton");
}
Expand Down
1 change: 1 addition & 0 deletions ...ontrols/tests/TestCases.Shared.Tests/Tests/Issues/Issue28986_SafeAreaBorderOrientation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public void SafeAreaBorderOrientationLandscapeToPortrait()

[Test]
[Category(UITestCategories.SafeAreaEdges)]
[Retry(2)]
public void SafeAreaBorderMultipleOrientationChanges()
{
var borderContent = App.WaitForElement("BorderContent");
Expand Down
Loading