Apply Integration Tests logging fixes from PR #33624 - #33638
Merged
Conversation
- Update ToolRunner.cs to use ITestOutputHelper instead of Console.WriteLine - Update DotnetInternal.cs to pass ITestOutputHelper, add OutputBuildErrorsFromBinLog - Update XHarness.cs to pass ITestOutputHelper to all methods - Update Adb.cs and Emulator.cs (Android) to use ITestOutputHelper - Update Simulator.cs (Apple) to store ITestOutputHelper as field - Update BuildWarningsUtilities.cs with new OutputBuildErrorsFromBinLog method - Update all test files to pass output: _output to DotnetInternal and XHarness calls - Add ShowLiveOutput property to Microsoft.Maui.IntegrationTests.csproj Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix logging issues excluding specific targets file
Apply Integration Tests logging fixes from PR #33624
Jan 21, 2026
This was referenced Jan 21, 2026
Open
PureWeen
marked this pull request as ready for review
January 21, 2026 13:05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ports logging improvements from PR #33624 to make Integration Test output visible in Azure DevOps CI. The changes replace Console.WriteLine with ITestOutputHelper for test output capture, as Azure DevOps does not capture console output but does capture xUnit test output.
Changes:
- Added optional
ITestOutputHelper? outputparameter to all utility classes (ToolRunner, DotnetInternal, XHarness, Adb, Emulator, Simulator) - Replaced all
Console.WriteLinecalls withoutput?.WriteLine()for proper CI output capture - Added
OutputBuildErrorsFromBinLog()method to extract and display build errors directly in test logs - Updated all test methods to pass
output: _outputto utility method calls - Added
<ShowLiveOutput>true</ShowLiveOutput>to project file
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Maui.IntegrationTests.csproj | Added ShowLiveOutput property to enable real-time test output |
| ToolRunner.cs | Added optional output parameter, replaced Console.WriteLine with output?.WriteLine() |
| DotnetInternal.cs | Added output parameter, changed ConstructBuildArgs to return tuple with binlogPath, added error extraction on build failure |
| BuildWarningsUtilities.cs | Added OutputBuildErrorsFromBinLog() method to extract and display build errors from binlog files |
| XHarness.cs | Added output parameter propagation throughout all methods |
| Adb.cs | Added output parameter to all methods for Android emulator logging |
| Emulator.cs | Added output parameter to all Android emulator management methods |
| Simulator.cs | Added output parameter to constructor and all iOS simulator methods |
| WindowsTemplateTest.cs | Updated all DotnetInternal calls to pass output: _output |
| SimpleTemplateTest.cs | Updated all DotnetInternal calls to pass output: _output |
| SampleTests.cs | Updated DotnetInternal.Build call to pass output: _output |
| ResizetizerTests.cs | Updated DotnetInternal calls to pass output: _output |
| MultiProjectTemplateTest.cs | Updated DotnetInternal and DotnetInternal.Run calls to pass output: _output |
| MacTemplateTest.cs | Updated DotnetInternal calls to pass output: _output |
| BlazorTemplateTest.cs | Updated DotnetInternal calls to pass output: _output |
| AppleTemplateTests.cs | Updated DotnetInternal and XHarness calls to pass output: _output |
| AndroidTemplateTests.cs | Updated DotnetInternal and XHarness calls to pass output: _output |
| AOTTemplateTest.cs | Updated DotnetInternal.New and DotnetInternal.Build calls to pass output: _output |
rmarinho
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port logging improvements from #33624 to make Integration Test output visible in CI.
Console.WriteLineoutput is not captured by Azure DevOps;ITestOutputHelperis.Changes
Utility Classes
ITestOutputHelper? outputparameter, replaceConsole.WriteLinewithoutput?.WriteLine()OutputBuildErrorsFromBinLog()to extract/display build errors on failureITestOutputHelperthrough Android/Apple utilitiesTest Files
output: _outputtoDotnetInternal.New(),DotnetInternal.Build(),XHarness.Run*()callsProject
ShowLiveOutput=trueto csprojExample
Excluded:
src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targetsas requested.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ghcr.io/tmp/dependabot-cli/dependabot/dependabot /tmp/dependabot-cli/dependabot/dependabot graph nuget org/repo --local /home/REDACTED/work/maui/maui --branch main --directory src/TestUtils/src/Microsoft.Maui.IntegrationTests --proxy-cert /home/REDACTED/work/_temp/runtime-logs/mkcert/rootCA.pem --updater-env NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/dbot-ca.crt git /bin/test --local credential.helpe/home/dependabot/dependabot-updater/bin/main.ps1 /usr/bin/git basename(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.