Skip to content

Revert "Update WindowsAppSDK to 1.8 (#32174)"#33537

Merged
PureWeen merged 2 commits intorelease/10.0.1xx-sr3from
copilot/revert-pr-32174
Jan 14, 2026
Merged

Revert "Update WindowsAppSDK to 1.8 (#32174)"#33537
PureWeen merged 2 commits intorelease/10.0.1xx-sr3from
copilot/revert-pr-32174

Conversation

Copy link
Contributor

Copilot AI commented Jan 14, 2026

Reverts the Windows App SDK update from version 1.7 to 1.8 introduced in PR #32174.

Reverted Changes

Version downgrades:

  • MicrosoftWindowsAppSDKPackageVersion: 1.8.2511060021.7.250909003
  • MicrosoftWindowsSDKBuildToolsPackageVersion: 10.0.26100.465410.0.22621.756

Package references removed:

  • Microsoft.WindowsAppSDK from Essentials.csproj, Graphics.Skia.csproj, Graphics.Win2D.csproj

Restored configurations:

  • Controls.Xaml.csproj: Re-added WINDOWS define constant and AppxGeneratePriEnabled=false
  • Directory.Build.targets: Removed GetTypeScriptCopyToOutputDirectoryItems target
  • WindowsTemplateTest.cs: Restored original RID-based asset path logic
  • windows.cake: Restored X509KeyUsageFlags.NonRepudiation in certificate generation

This reverts commit 5a39604.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • ghcr.io
    • Triggering command: /tmp/dependabot-cli/dependabot/dependabot /tmp/dependabot-cli/dependabot/dependabot graph nuget org/repo --local /home/REDACTED/work/maui/maui --branch main --directory src/Controls/src/Xaml --proxy-cert /home/REDACTED/work/_temp/runtime-logs/mkcert/rootCA.pem --updater-env NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/dbot-ca.crt (dns block)
    • Triggering command: /tmp/dependabot-cli/dependabot/dependabot /tmp/dependabot-cli/dependabot/dependabot graph nuget org/repo --local /tmp/dependabot-base-edeX71/repo --branch main --directory src/Essentials/src --proxy-cert /home/REDACTED/work/_temp/runtime-logs/mkcert/rootCA.pem --updater-env NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/dbot-ca.crt (dns block)
    • Triggering command: /tmp/dependabot-cli/dependabot/dependabot /tmp/dependabot-cli/dependabot/dependabot graph nuget org/repo --local /home/REDACTED/work/maui/maui --branch main --directory src/Essentials/src --proxy-cert /home/REDACTED/work/_temp/runtime-logs/mkcert/rootCA.pem --updater-env NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/dbot-ca.crt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

can you revert the following PR ? #32174


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Revert PR #32174 Revert "Update WindowsAppSDK to 1.8 (#32174)" Jan 14, 2026
Copilot AI requested a review from PureWeen January 14, 2026 16:33
@PureWeen PureWeen closed this Jan 14, 2026
@PureWeen PureWeen reopened this Jan 14, 2026
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen marked this pull request as ready for review January 14, 2026 17:24
Copilot AI review requested due to automatic review settings January 14, 2026 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Windows App SDK update from version 1.8 to 1.7 (originally introduced in PR #32174). The revert is necessary due to compatibility issues with the newer SDK version.

Changes:

  • Downgraded Windows App SDK from 1.8.251106002 to 1.7.250909003
  • Downgraded Windows SDK Build Tools from 10.0.26100.4654 to 10.0.22621.756
  • Removed explicit Microsoft.WindowsAppSDK package references from three projects (Essentials, Graphics.Skia, Graphics.Win2D)
  • Restored build configuration settings in Controls.Xaml.csproj
  • Fixed integration test path logic to work with the reverted SDK
  • Restored certificate key usage flags and logging order in windows.cake

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
eng/Versions.props Downgraded WindowsAppSDK and Windows SDK Build Tools versions to 1.7
src/Essentials/src/Essentials.csproj Removed explicit Microsoft.WindowsAppSDK package reference
src/Graphics/src/Graphics.Skia/Graphics.Skia.csproj Removed explicit Microsoft.WindowsAppSDK package reference
src/Graphics/src/Graphics.Win2D/Graphics.Win2D.csproj Removed explicit Microsoft.WindowsAppSDK package reference
src/Controls/src/Xaml/Controls.Xaml.csproj Re-added WINDOWS define constant and AppxGeneratePriEnabled=false setting
Directory.Build.targets Removed GetTypeScriptCopyToOutputDirectoryItems target override
src/TestUtils/src/Microsoft.Maui.IntegrationTests/WindowsTemplateTest.cs Simplified asset path construction for packaged Windows tests
eng/devices/windows.cake Restored NonRepudiation key usage flag and moved Information log before conditional logic

Comment on lines +170 to +171
var rid = usesRidGraph ? "win10-x64" : "win-x64";
var assetsRoot = Path.Combine(projectDir, $"bin/{config}/{framework}-windows10.0.19041.0/{rid}/AppPackages/{name}_1.0.0.1_Test");
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reverted path logic uses different RID values (win10-x64 vs win-x64) depending on the usesRidGraph parameter. This logic is simpler than the original WindowsAppSDK 1.8 version but should be verified to ensure it correctly locates assets for both DotNetCurrent (net10.0, usesRidGraph=false) and DotNetPrevious (net9.0, usesRidGraph=true) test cases.

Copilot uses AI. Check for mistakes.
var currentUserMyStore = new X509Store("My", StoreLocation.CurrentUser);
currentUserMyStore.Open(OpenFlags.ReadWrite);
certificateThumbprint = localTrustedPeopleStore.Certificates.FirstOrDefault(c => c.Subject.Contains(certCN))?.Thumbprint;
Information("Cert thumbprint: " + certificateThumbprint ?? "null");
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null-coalescing operator has incorrect precedence here. Due to operator precedence, this evaluates as Information((\"Cert thumbprint: \" + certificateThumbprint) ?? \"null\") which will never use the "null" fallback since string concatenation with null produces a string. Should be Information(\"Cert thumbprint: \" + (certificateThumbprint ?? \"null\")) to correctly display "null" when certificateThumbprint is null.

Suggested change
Information("Cert thumbprint: " + certificateThumbprint ?? "null");
Information("Cert thumbprint: " + (certificateThumbprint ?? "null"));

Copilot uses AI. Check for mistakes.
@PureWeen PureWeen merged commit 8e226eb into release/10.0.1xx-sr3 Jan 14, 2026
165 of 178 checks passed
@PureWeen PureWeen deleted the copilot/revert-pr-32174 branch January 14, 2026 19:55
@lothrop
Copy link
Contributor

lothrop commented Jan 20, 2026

WindowsAppSDK 1.7 goes out of support on March 18. Is there a timeline for when WindowsAppSDK 1.8 will be included in .NET MAUI?

@MartyIX
Copy link
Contributor

MartyIX commented Jan 20, 2026

What was wrong with WinAppSDK 1.8, if I may ask?

@bdovaz
Copy link

bdovaz commented Jan 28, 2026

I have the same questions. Can you answer us, @PureWeen? Thank you.

@lothrop
Copy link
Contributor

lothrop commented Feb 4, 2026

Looks like there's a new PR #33850 but it's an update from 1.8.3 to 1.8.4?

@bdovaz
Copy link

bdovaz commented Feb 4, 2026

Okay, I understand what's happening. If you look at the PR we're on, @lothrop, it reverts on release/10.0.1xx-sr3 branch, but on the main branch it is updated to 1.8.

<MicrosoftWindowsAppSDKPackageVersion>1.8.251106002</MicrosoftWindowsAppSDKPackageVersion>

So I imagine that at some point there will be a release updating to 1.8, but we don't know when. @PureWeen?

@MartyIX
Copy link
Contributor

MartyIX commented Feb 4, 2026

So I imagine that at some point there will be a release updating to 1.8, but we don't know when. @PureWeen?

main is used to branch a service release (SR) branch every month, so unless there is a change (i.e. revert), the 1.8 will be released in the next SR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants