-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix build errors for API docs changes #33506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes build errors from PR #33391 by adding XML documentation comments that were not committed. The changes replace <include> directives (which reference external XML documentation files) with inline XML documentation comments (<summary> tags).
Changes:
- Replaced XML
<include>directives with inline<summary>documentation in TableView.cs - Replaced XML
<include>directives with inline<summary>documentation in SwipeView.cs - Replaced XML
<include>directives with inline<summary>documentation in SearchBar.cs - Replaced XML
<include>directives with inline<summary>documentation in ScrollView.cs
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/TableView/TableView.cs | Converted XML include directives to inline summary tags for class and member documentation (7 replacements) |
| src/Controls/src/Core/SwipeView/SwipeView.cs | Converted XML include directives to inline summary tags for class and member documentation (6 replacements) |
| src/Controls/src/Core/SearchBar/SearchBar.cs | Converted XML include directives to inline summary tags for bindable properties and member documentation (10 replacements) |
| src/Controls/src/Core/ScrollView/ScrollView.cs | Converted XML include directives to inline summary tags for member documentation (4 replacements) |
|
Seems now fails on devicetests |
|
/rebase |
6653057 to
b6a7596
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run maui-pr-uitests |
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like dotnet#33391 broke some builds because some files were not committed. This adds these files!
Looks like #33391 broke some builds because some files were not committed. This adds these files!