Skip to content

Conversation

@jfversluis
Copy link
Member

Looks like #33391 broke some builds because some files were not committed. This adds these files!

Copilot AI review requested due to automatic review settings January 13, 2026 13:27
@jfversluis jfversluis added the area-docs Conceptual docs, API docs, Samples label Jan 13, 2026
@jfversluis
Copy link
Member Author

jfversluis commented Jan 13, 2026

/azp run maui-pr-devicetests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis requested a review from rmarinho January 13, 2026 13:32
@rmarinho
Copy link
Member

/azp run maui-pr-uitests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes build errors from PR #33391 by adding XML documentation comments that were not committed. The changes replace <include> directives (which reference external XML documentation files) with inline XML documentation comments (<summary> tags).

Changes:

  • Replaced XML <include> directives with inline <summary> documentation in TableView.cs
  • Replaced XML <include> directives with inline <summary> documentation in SwipeView.cs
  • Replaced XML <include> directives with inline <summary> documentation in SearchBar.cs
  • Replaced XML <include> directives with inline <summary> documentation in ScrollView.cs

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Controls/src/Core/TableView/TableView.cs Converted XML include directives to inline summary tags for class and member documentation (7 replacements)
src/Controls/src/Core/SwipeView/SwipeView.cs Converted XML include directives to inline summary tags for class and member documentation (6 replacements)
src/Controls/src/Core/SearchBar/SearchBar.cs Converted XML include directives to inline summary tags for bindable properties and member documentation (10 replacements)
src/Controls/src/Core/ScrollView/ScrollView.cs Converted XML include directives to inline summary tags for member documentation (4 replacements)

@rmarinho
Copy link
Member

Seems now fails on devicetests

 Essentials -> D:\a\_work\1\s\artifacts\bin\Essentials\Release\net10.0\Microsoft.Maui.Essentials.dll
##[error]src\Controls\src\Core\SearchBar\SearchBar.cs(32,49): Error CS1574: XML comment has cref attribute 'Text' that could not be resolved
D:\a\_work\1\s\src\Controls\src\Core\SearchBar\SearchBar.cs(32,49): error CS1574: XML comment has cref attribute 'Text' that could not be resolved [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=netstandard2.1]
##[error]src\Controls\src\Core\SearchBar\SearchBar.cs(41,49): Error CS1574: XML comment has cref attribute 'Placeholder' that could not be resolved
D:\a\_work\1\s\src\Controls\src\Core\SearchBar\SearchBar.cs(41,49): error CS1574: XML comment has cref attribute 'Placeholder' that could not be resolved [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=netstandard2.1]
##[error]src\Controls\src\Core\SearchBar\SearchBar.cs(44,49): Error CS1574: XML comment has cref attribute 'PlaceholderColor' that could not be resolved

@jfversluis
Copy link
Member Author

/rebase

@jfversluis jfversluis force-pushed the jfversluis/fix-api-docs-build-errors branch from 6653057 to b6a7596 Compare January 13, 2026 14:57
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho
Copy link
Member

/azp run maui-pr-uitests

@rmarinho
Copy link
Member

/azp run maui-pr-devicetests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Member

  • this is mainly fixing build errors from docs, all of the testing builds themselves have succeed so merging this to fix main

@PureWeen PureWeen merged commit c03a50f into main Jan 13, 2026
145 of 166 checks passed
@PureWeen PureWeen deleted the jfversluis/fix-api-docs-build-errors branch January 13, 2026 16:30
kubaflo pushed a commit to kubaflo/maui that referenced this pull request Jan 16, 2026
Looks like dotnet#33391 broke some builds because some files were not
committed. This adds these files!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-docs Conceptual docs, API docs, Samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants