[iOS 26 & Catalyst 26] [Follow-up PR] Fixed IsEnabled behavior on Tabs by SubhikshaSf4851 · Pull Request #33337 · dotnet/maui

SubhikshaSf4851 · 2025-12-30T12:53:11Z

Root Cause

On iOS and Mac Catalyst 26 version, drag and selection gestures allow navigation to disabled tabs which leads to inconsistent with the UI and expected behavior.

Description of Change

Since navigation can be achieved via drag and select in iOS and Mac Catalyst version 26, updated the ShouldSelectViewController logic in ShellItemRenderer.cs to prevent selection of disabled tabs on iOS and Mac Catalyst by returning false when a tab's IsEnabled property is false.

Issues Fixed

Fixes #33158

Tested the behavior in the following platforms

Windows
Android
iOS
Mac

Follow UP PR : 33369

Before Issue Fix	After Issue Fix
Screen.Recording.2026-01-05.at.15.49.31.mov	Screen.Recording.2026-01-05.at.16.00.54.mov

dotnet-policy-service · 2025-12-30T12:53:31Z

Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull request overview

This PR fixes the IsEnabled property for Shell tabs on iOS and Mac Catalyst. Previously, disabled tabs could still be selected through drag gestures or direct selection. The fix implements initial IsEnabled state application at tab creation and prevents selection of disabled tabs in the ShouldSelectViewController delegate.

Key Changes

Added runtime check in ShouldSelectViewController to prevent selection of disabled tabs
Applied initial IsEnabled state when tab items are created or the collection changes
Added UI test to verify the fix works correctly

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs	Adds IsEnabled check in ShouldSelectViewController and applies initial enabled state for tabs in two locations
src/Controls/tests/TestCases.HostApp/Issues/Issue33158.cs	Creates test UI page with three tabs (first and third enabled, second disabled) to demonstrate the issue
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33158.cs	Implements NUnit test that verifies disabled tab cannot be selected and can be enabled at runtime

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33158.cs

src/Controls/tests/TestCases.HostApp/Issues/Issue33158.cs

PureWeen · 2025-12-31T16:25:36Z

/rebase

PureWeen · 2025-12-31T17:00:48Z

/azp run maui-pr-uitests

azure-pipelines · 2025-12-31T17:00:58Z

Azure Pipelines successfully started running 1 pipeline(s).

PureWeen

This one looks good but I want to wait until we have our iOS 26 UI test lane up before we merge this. I've set it to SR4, by then we should hopefully have it merged

PureWeen

Can you split this into two PRs?

One that has the iOS26 changes and one that has the general changes?
That way we can at least merge the general changes for now and once we get iOS 26 UItests up we can merge the other changes

SubhikshaSf4851 · 2026-01-05T10:59:24Z

@PureWeen As suggested, I’ve split it into two PRs: 33369 for general changes and 33337 for iOS 26–specific changes.

### Root Cause The load-time handling of the `IsEnabled` property for tab items was not implemented on iOS. As a result, disabled tabs could still be selectable and navigateable ### Description of Change Updated `ShellItemRenderer.cs` to set the `IsEnabled` property of each `TabBar` item based on the corresponding `IsEnabled` value during both initial creation and when the items collection changes.  ### Issues Fixed  Fixes #33158 ### Follow-up PR : - On **iOS 26** and **Catalyst 26**, navigation between tabs via drag and selection gestures is handled separately in this PR #33337. ### Tested the behavior in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac | Before Issue Fix | After Issue Fix | |----------|----------| | <video src="https://github.com/user-attachments/assets/d133ccd3-abb1-44dd-9135-16b1ebeeb8e6"> | <video src="https://github.com/user-attachments/assets/223f454c-fc1a-4167-b265-8ef6c7e0c8c6"> |

StephaneDelcroix

✅ Approved

Code Review Summary:

The fix correctly addresses the iOS 26/Mac Catalyst 26 issue where disabled Shell tabs can be selected via drag gestures.

Strengths

Minimal, surgical change (9 lines added)
Proper version guard using OperatingSystem.IsIOSVersionAtLeast(26)
Backwards compatible - doesn't affect iOS < 26
Well-commented code explaining the iOS 26 behavior
Improved variable naming (r → renderer)

Notes

Tests from PR #33369 (merged to inflight/current) will cover this scenario once both merge to main
Cannot fully validate on current simulators since iOS 26 is a future version, but code logic is verified correct
Waiting for iOS 26 UI test lane (per PureWeen's earlier comment) is the right approach

LGTM! 🚀

Changes requested have been addressed - PR was split as requested. PR #33369 (general changes) was merged, and this PR now contains only the iOS 26-specific changes.

### Root Cause The load-time handling of the `IsEnabled` property for tab items was not implemented on iOS. As a result, disabled tabs could still be selectable and navigateable ### Description of Change Updated `ShellItemRenderer.cs` to set the `IsEnabled` property of each `TabBar` item based on the corresponding `IsEnabled` value during both initial creation and when the items collection changes.  ### Issues Fixed  Fixes #33158 ### Follow-up PR : - On **iOS 26** and **Catalyst 26**, navigation between tabs via drag and selection gestures is handled separately in this PR #33337. ### Tested the behavior in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac | Before Issue Fix | After Issue Fix | |----------|----------| | <video src="https://github.com/user-attachments/assets/d133ccd3-abb1-44dd-9135-16b1ebeeb8e6"> | <video src="https://github.com/user-attachments/assets/223f454c-fc1a-4167-b265-8ef6c7e0c8c6"> |

rmarinho · 2026-01-19T15:00:17Z

/azp run maui-pr-uitests

rmarinho · 2026-01-19T15:00:29Z

/azp run maui-pr-devicetests

azure-pipelines · 2026-01-19T15:00:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-01-19T15:00:44Z

Azure Pipelines successfully started running 1 pipeline(s).

### Root Cause The load-time handling of the `IsEnabled` property for tab items was not implemented on iOS. As a result, disabled tabs could still be selectable and navigateable ### Description of Change Updated `ShellItemRenderer.cs` to set the `IsEnabled` property of each `TabBar` item based on the corresponding `IsEnabled` value during both initial creation and when the items collection changes.  ### Issues Fixed  Fixes #33158 ### Follow-up PR : - On **iOS 26** and **Catalyst 26**, navigation between tabs via drag and selection gestures is handled separately in this PR #33337. ### Tested the behavior in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac | Before Issue Fix | After Issue Fix | |----------|----------| | <video src="https://github.com/user-attachments/assets/d133ccd3-abb1-44dd-9135-16b1ebeeb8e6"> | <video src="https://github.com/user-attachments/assets/223f454c-fc1a-4167-b265-8ef6c7e0c8c6"> |

dotnet#33337)  ### Root Cause On iOS and Mac Catalyst 26 version, drag and selection gestures allow navigation to disabled tabs which leads to inconsistent with the UI and expected behavior. ### Description of Change * Since navigation can be achieved via drag and select in iOS and Mac Catalyst version 26, updated the `ShouldSelectViewController` logic in `ShellItemRenderer.cs` to prevent selection of disabled tabs on iOS and Mac Catalyst by returning `false` when a tab's `IsEnabled` property is `false`.  ### Issues Fixed  Fixes dotnet#33158 ### Tested the behavior in the following platforms - [ ] Windows - [x] Android - [x] iOS - [x] Mac Follow UP PR : [33369](dotnet#33369) | Before Issue Fix | After Issue Fix | |----------|----------| | <video src="https://github.com/user-attachments/assets/837f9197-4f92-4797-8b4a-5f40cc0f2af2"> | <video src="https://github.com/user-attachments/assets/89449bc0-bd23-4f10-8bbd-102cce85f64e"> |

dotnet-policy-service bot added the community ✨ Community Contribution label Dec 30, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 30, 2025

Tamilarasan-Paranthaman added platform/macos macOS / Mac Catalyst platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Dec 30, 2025

build-analysis bot mentioned this pull request Dec 30, 2025

System.TimeoutException #33245

Open

sheiksyedm marked this pull request as ready for review December 31, 2025 13:59

Copilot AI review requested due to automatic review settings December 31, 2025 13:59

Copilot started reviewing on behalf of sheiksyedm December 31, 2025 14:00 View session

Copilot AI reviewed Dec 31, 2025

View reviewed changes

SubhikshaSf4851 added 2 commits December 31, 2025 16:26

Fix for IsEnabled property in iOS

f450dd2

added issue id

8443844

github-actions bot force-pushed the Fix-33158 branch from c98f0f5 to 8443844 Compare December 31, 2025 16:26

PureWeen added this to the .NET 10.0 SR4 milestone Dec 31, 2025

PureWeen added this to MAUI SDK Ongoing Dec 31, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Dec 31, 2025

PureWeen reviewed Dec 31, 2025

View reviewed changes

PureWeen previously requested changes Jan 2, 2026

View reviewed changes

github-project-automation bot moved this from Todo to Changes Requested in MAUI SDK Ongoing Jan 2, 2026

Reverting General changes

099e59f

Tamilarasan-Paranthaman added the version/iOS-26 label Jan 5, 2026

SubhikshaSf4851 changed the title ~~[iOS & Catalyst ] Fixed IsEnabled property should work on Tabs~~ [iOS 26 & Catalyst 26] [Follow-up PR] Fixed IsEnabled behavior on Tabs Jan 5, 2026

SubhikshaSf4851 mentioned this pull request Jan 5, 2026

[iOS & Catalyst ] Fixed IsEnabled property should work on Tabs #33369

Merged

4 tasks

StephaneDelcroix approved these changes Jan 7, 2026

View reviewed changes

StephaneDelcroix moved this from Changes Requested to Approved in MAUI SDK Ongoing Jan 7, 2026

build-analysis bot mentioned this pull request Jan 19, 2026

CI UItests failure System.TimeoutException : Timed out waiting for element... #33220

Open

PureWeen modified the milestones: .NET 10.0 SR4, .NET 10 SR5 Jan 21, 2026

rmarinho merged commit 5c4b066 into dotnet:main Jan 31, 2026
153 of 161 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Jan 31, 2026

jfversluis mentioned this pull request Feb 20, 2026

Fixed IsEnabled Property not works on Tabs #26728

Open

4 tasks

Comments

Conversation

SubhikshaSf4851 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Description of Change

Issues Fixed

Tested the behavior in the following platforms

Uh oh!

dotnet-policy-service bot commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PureWeen commented Dec 31, 2025

Uh oh!

PureWeen commented Dec 31, 2025

Uh oh!

azure-pipelines bot commented Dec 31, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

SubhikshaSf4851 commented Jan 5, 2026

Uh oh!

StephaneDelcroix left a comment

Choose a reason for hiding this comment

✅ Approved

Strengths

Notes

Uh oh!

rmarinho commented Jan 19, 2026

Uh oh!

rmarinho commented Jan 19, 2026

Uh oh!

azure-pipelines bot commented Jan 19, 2026

Uh oh!

azure-pipelines bot commented Jan 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SubhikshaSf4851 commented Dec 30, 2025 •

edited

Loading