Skip to content

Fix: Throw a clear error when an SVG lacks dimensions instead of a NullReferenceException #33194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 4 commits into from
Feb 24, 2026
Merged

Fix: Throw a clear error when an SVG lacks dimensions instead of a NullReferenceException #33194

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a18af5d
Fix the Svg file Null reference exception issue
Shalini-Ashokan Dec 15, 2025
98f8759
Added a unit test.
Shalini-Ashokan Dec 16, 2025
58f9f0b
Removed the test case
Shalini-Ashokan Dec 17, 2025
d5f2afd
I modified the fix
Shalini-Ashokan Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/SingleProject/Resizetizer/src/SkiaSharpSvgTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,18 @@ public override SKSize GetOriginalSize() =>

public override void DrawUnscaled(SKCanvas canvas, float scale)
{
var size = GetOriginalSize();
if (size.IsEmpty)
{
throw new InvalidOperationException($"Cannot draw SVG file '{Filename}'. The SVG has no size. Ensure the SVG includes a viewBox attribute or both width and height attributes with valid dimensions.");
}
if (scale >= 1)
{
// draw using default scaling
canvas.DrawPicture(svg.Picture, Paint);
}
else
{
// draw using raster downscaling
var size = GetOriginalSize();

// vector scaling has rounding issues, so first draw as intended
var info = new SKImageInfo((int)size.Width, (int)size.Height);
using var surface = SKSurface.Create(info);
Expand Down
Loading