Merged
Conversation
# Conflicts: # .github/agents/issue-resolver.md # .github/instructions/issue-resolver-agent/reproduction.md
Member
Author
|
I'm fixing the custom agents with this pr and would like your opinion Im basically moving all the script parts of sandbox and hostapp into ps1 files Please update all instructions used by these custom agents to reduce complexity especially if its already covered by the new ps1 files in this pr |
Contributor
…Shell scripts (#32820) * Initial plan * Update agent instructions to use BuildAndRun scripts - Replace manual command sequences with BuildAndRunSandbox.ps1 and BuildAndRunHostApp.ps1 script references - Update pr-reviewer-agent instructions (quick-ref, quick-start, testing-guidelines, error-handling) - Update appium-control.instructions.md to recommend script usage - Update instrumentation.instructions.md with script option - Add note to platform-workflows.md directing to scripts first - Simplify complexity by referencing centralized scripts instead of duplicating manual commands Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Simplify appium-control.instructions.md by removing redundant build/deploy steps Remove manual build/deploy instructions that are now handled by BuildAndRunSandbox.ps1: - Removed 106 lines of redundant iOS/Android build/deploy commands - Removed manual cleanup instructions (script handles this) - Removed manual Appium startup instructions (script handles this) - Kept Appium scripting guidance (template, platform differences, operations) - File now focuses on Appium C# scripting patterns, not build workflows The file now properly delegates build/deploy to the script while maintaining its core purpose: teaching how to write Appium control scripts for manual debugging. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Critical improvements for future agent success: 1. Added prominent section about noReset requirement for Android - Explains Fast Deployment crash scenario - Emphasizes this must NEVER be removed - Documents exact error message to look for 2. Strengthened 'never run manual commands' guidance - Explicit list of prohibited commands (adb, xcrun, dotnet) - Clear explanation that BuildAndRunSandbox.ps1 handles everything - Emphasized reading captured logs instead of capturing new ones 3. Added Fast Deployment troubleshooting section - How to identify the error in logs - Step-by-step fix instructions - Clarifies this is infrastructure issue, not PR bug 4. Updated RunWithAppiumTest.template.cs with strong warnings - Header comment warns about Android requirement - Inline comment at noReset capability with emojis for visibility - Explains crash scenario if removed These changes address the issues encountered during PR #32479 testing where initial tests failed due to missing noReset capability.
…ting Key improvements: 1. Clarified noReset is ANDROID ONLY requirement - Added explicit warning not to use for iOS - Explained iOS deployment works differently - Updated code examples to show platform check 2. Added critical 'Element Not Found' troubleshooting section - DO NOT assume app is working if element not found - Must check logs immediately for crashes/exceptions - Specific commands to verify app actually launched - Common root causes and debugging steps - Prevents agents from waiting/guessing when app has crashed 3. Enhanced validation checklist - Added requirement to verify app running before proceeding - Clear stop condition if element not found - Reference to troubleshooting section These changes address issues discovered during iOS testing where: - App crashed with XAML parse error (missing event handler) - Initial assumption was 'app loading slowly' rather than 'app crashed' - Proper log investigation revealed actual problem immediately
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Phase 2 of the AI agent infrastructure consolidation for .NET MAUI testing workflows. It introduces automated PowerShell scripts for building, deploying, and testing MAUI applications, consolidates log directories, and updates all documentation references to use the new automated workflow.
Key Changes:
- Automated testing scripts that handle device detection, building, deployment, Appium management, and log capture
- Consolidated log structure under
CustomAgentLogsTmp/with subdirectories for Sandbox and UITests - Renamed and reorganized instruction files with consistent
.mdextensions - Updated 53+ markdown files with corrected file paths and references
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.gitignore |
Updates ignored directory from SandboxAppium/ to CustomAgentLogsTmp/ |
.github/scripts/templates/RunWithAppiumTest.template.cs |
New Appium test template with platform detection, PID capture, and comprehensive error handling |
.github/scripts/shared/shared-utils.ps1 |
New utility functions for colored console output |
.github/scripts/shared/Start-Emulator.ps1 |
New script for automated Android emulator and iOS simulator detection and startup |
.github/scripts/shared/Build-AndDeploy.ps1 |
New script for building and deploying MAUI apps to Android/iOS devices |
.github/scripts/BuildAndRunSandbox.ps1 |
New comprehensive script for Sandbox app testing workflow with complete log capture |
.github/scripts/BuildAndRunHostApp.ps1 |
New comprehensive script for HostApp UI test execution with complete log capture |
Multiple instruction .md files |
Path corrections and updates to reference new scripts and consolidated log structure |
| Agent definition files | Updated to use new automated scripts and clarify agent purposes |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This was referenced Dec 22, 2025
Closed
Open
Closed
Closed
This was referenced Jan 1, 2026
Closed
This was referenced Jan 12, 2026
kubaflo
added
area-ai-agents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.