Skip to content

[Android] Optimize MauiWindowInsetListener registry with ConditionalWeakTable#32447

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/apply-comments-from-pr-32278
Closed

[Android] Optimize MauiWindowInsetListener registry with ConditionalWeakTable#32447
Copilot wants to merge 2 commits into
mainfrom
copilot/apply-comments-from-pr-32278

Replace List with ConditionalWeakTable for O(n) performance

48c9648
Select commit
Loading
Failed to load commit list.
Azure Pipelines / MAUI-UITests-public succeeded Nov 8, 2025 in 29m 26s

Build #10.0.10-ci+pr.32447.azdo.153522 had test failures

Details

Tests

  • Failed: 5 (0.04%)
  • Passed: 12,546 (98.64%)
  • Other: 168 (1.32%)
  • Total: 12,719

Annotations

Check failure on line 873 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L873

PowerShell exited with code '1'.

Check failure on line 922 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L922

PowerShell exited with code '1'.

Check failure on line 1776 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L1776

PowerShell exited with code '1'.

Check failure on line 605 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L605

PowerShell exited with code '1'.

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue6994(Android).NullPointerExceptionOnFastLabelTextColorChange

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue6994(Android).NullPointerExceptionOnFastLabelTextColorChange

The app was expected to be running still, investigate as possible crash
TearDown : The app was expected to be running still, investigate as possible crash
Raw output
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 87
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 38

--TearDown
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 87
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 38

1)    at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 87
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 38

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.FlyoutPageFeatureTests(Android).VerifyFlyoutPage_IsGestureEnabled_FlyoutBehaviorPopover

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.FlyoutPageFeatureTests(Android).VerifyFlyoutPage_IsGestureEnabled_FlyoutBehaviorPopover

  Flyout did not open after multiple drag attempts
Assert.That(flyoutOpened, Is.True)
  Expected: True
  But was:  False
Raw output
   at Microsoft.Maui.TestCases.Tests.FlyoutPageFeatureTests.VerifyFlyoutPage_IsGestureEnabled_FlyoutBehaviorPopover() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/FlyoutPageFeatureTests.cs:line 154

1)    at Microsoft.Maui.TestCases.Tests.FlyoutPageFeatureTests.VerifyFlyoutPage_IsGestureEnabled_FlyoutBehaviorPopover() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/FlyoutPageFeatureTests.cs:line 154

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue2617(Mac).BindingToValuesTypesAndScrollingNoCrash

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue2617(Mac).BindingToValuesTypesAndScrollingNoCrash

OpenQA.Selenium.UnknownErrorException : An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: timeout of 240000ms exceeded
TearDown : OpenQA.Selenium.UnknownErrorException : An unknown server-side error occurred while processing the command. Original error: Cannot get 'xml' source of the current application
Raw output
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.ExecuteAsync(String driverCommandToExecute, Dictionary`2 parameters)
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2557
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 745
   at Microsoft.Maui.TestCases.Tests.Issues.Issue2617.BindingToValuesTypesAndScrollingNoCrash() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2617.cs:line 23
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
--TearDown
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.ExecuteAsync(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.Appium.AppiumDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.get_PageSource()
   at UITest.Appium.AppiumApp.get_ElementTree() in /_/src/TestUtils/src/UITest.Appium/AppiumApp.cs:line 41
   at UITest.Appium.NUnit.UITestBase.SaveUIDiagnosticInfo(String note) in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 185
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 97
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 75
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 38
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.TwoPaneViewFeatureTests(Windows).TwoPaneView_TallMode

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.TwoPaneViewFeatureTests(Windows).TwoPaneView_TallMode

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: TwoPaneView_TallMode.png (0.62% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|9_0(String name, <>c__DisplayClass9_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 365
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 207
   at Microsoft.Maui.TestCases.Tests.TwoPaneViewFeatureTests.TwoPaneView_TallMode() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/TwoPaneViewFeatureTests.cs:line 145
   at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)