Sync DeveloperBalance sample changes from the MAUI Samples repo to the .NET MAUI repo by Vignesh-SF3580 · Pull Request #32148 · dotnet/maui

Vignesh-SF3580 · 2025-10-22T11:49:17Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

The DeveloperBalance template sample in the .NET MAUI repo is not up to date with the latest changes from the MAUI Samples repo.

Description of Change

Updated the MAUI mobile DeveloperBalance sample with the latest changes from the MAUI Samples repository.

Screenshots

Mac	Windows
MacDebug.mov	WindowsDebug.mp4

Android	iOS
AndroidDebug.mov	iOSDebug.mov

dotnet-policy-service · 2025-10-22T11:49:37Z

Hey there @@Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR synchronizes the DeveloperBalance template sample from the MAUI Samples repository to the .NET MAUI repository, bringing UI improvements, accessibility enhancements, and code refactoring changes.

Key Changes:

Replaced deprecated layout options (FillAndExpand, CenterAndExpand) with their modern equivalents
Refactored tag selection UI from HorizontalStackLayout with template selector to CollectionView with visual states
Added platform-specific handler configurations for iOS, macOS, and Windows to improve keyboard accessibility

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
AppStyles.xaml	Updated layout options to use non-deprecated values
Info.plist	Added MacCatalyst app category metadata
ProjectListPage.xaml.cs	Added binding context assignment for appearing behavior
ProjectListPage.xaml	Replaced BindableLayout with CollectionView for improved selection handling
ProjectDetailPage.xaml	Refactored tag selection from template selector to CollectionView with visual states
MainPage.xaml	Reordered Grid property attributes
TaskView.xaml	Restructured task item layout to improve accessibility
ProjectCardView.xaml	Changed tag container from HorizontalStackLayout to FlexLayout and removed deprecated property
ChartDataLabelConverter.cs	Created new converter to replace DataLabelValueConverter with updated implementation
CategoryChart.xaml	Updated to use new ChartDataLabelConverter and cleaned up duplicate x:DataType attributes
ProjectListPageModel.cs	Added selected project property and null check for navigation
ProjectDetailPageModel.cs	Added SelectionChanged command to handle CollectionView multi-selection
MauiProgram.cs	Added platform-specific handler configurations for improved keyboard accessibility
TagRepository.cs	Added duplicate association check to prevent redundant database operations
DataLabelValueConverter.cs	Removed obsolete converter class
AppShell.xaml.cs	Added semantic description for theme control on Android/Windows
AppShell.xaml	Added semantic descriptions to theme segment items

Copilot · 2025-10-22T12:47:41Z

src/Templates/src/templates/maui-mobile/Pages/ProjectListPage.xaml.cs

 	{
 		BindingContext = model;
 		InitializeComponent();
+		AppearingBehavior.BindingContext = model;


Setting BindingContext on a behavior after InitializeComponent() is unusual, as behaviors typically inherit the binding context from their parent element. This could indicate a deeper issue with how the behavior's data context is resolved. Consider whether this explicit assignment is necessary, or if the XAML binding on line 17 of the .xaml file should be sufficient.

Suggested change

AppearingBehavior.BindingContext = model;

BindingContext is already set in XAML, so there’s no need to set it here. I have removed it

Copilot · 2025-10-22T12:47:41Z

src/Templates/src/templates/maui-mobile/Pages/ProjectDetailPage.xaml

-                        BindableLayout.ItemTemplateSelector="{StaticResource ChipDataTemplateSelector}"/>
-                </ScrollView>
+
+                <!-- TODO This is still a little jumpy when changing selection -->


This TODO comment indicates an unresolved UI issue with tag selection. Before merging, either resolve the jumpiness issue or create a tracked work item to address it.

Suggested change

Copilot · 2025-10-22T12:47:41Z

src/Templates/src/templates/maui-mobile/Pages/Controls/TaskView.xaml

                        IsChecked="{Binding IsCompleted, Mode=OneTime}"
                        VerticalOptions="Center"
                        CheckedChanged="CheckBox_CheckedChanged"
+                        AutomationProperties.IsInAccessibleTree="True"


The default value of IsInAccessibleTree is already True. This explicit assignment is redundant and can be removed.

Suggested change

AutomationProperties.IsInAccessibleTree="True"

src/Templates/src/templates/maui-mobile/Pages/Controls/ChartDataLabelConverter.cs

Copilot · 2025-10-22T12:47:42Z

src/Templates/src/templates/maui-mobile/PageModels/ProjectListPageModel.cs

-	Task NavigateToProject(Project project)
-		=> Shell.Current.GoToAsync($"project?id={project.ID}");
+	Task? NavigateToProject(Project project)
+		=> project is null ? null : Shell.Current.GoToAsync($"project?id={project.ID}");


Returning null as a Task? instead of Task.CompletedTask is unconventional. Consider using Task.CompletedTask for consistency with async patterns, or change the return type to Task and throw an exception if the project is null.

Suggested change

=> project is null ? null : Shell.Current.GoToAsync($"project?id={project.ID}");

=> project is null ? Task.CompletedTask : Shell.Current.GoToAsync($"project?id={project.ID}");

Why at any point would we be passing a null value into NavigateToProject?
is this a bug further up?

The Project was never null, and I updated the code based on the suggestion.

Copilot · 2025-10-22T12:47:42Z

src/Templates/src/templates/maui-mobile/Data/TagRepository.cs

+		await SaveItemAsync(item);
+


The IsAssociated method calls SaveItemAsync(item) which modifies the database state while checking if an association exists. This is a side effect that shouldn't occur in a method that appears to only query state. Remove line 230 to make this a pure query method.

Suggested change

await SaveItemAsync(item);

Removed the changes.

Copilot · 2025-10-22T12:47:43Z

src/Templates/src/templates/maui-mobile/MauiProgram.cs

+            Microsoft.Maui.Handlers.ContentViewHandler.Mapper.AppendToMapping(nameof(Pages.Controls.CategoryChart), (handler, view) =>
+            {
+                if (view is Pages.Controls.CategoryChart && handler.PlatformView is ContentPanel contentPanel)
+                {
+                    contentPanel.IsTabStop = true;
+                }
+            });


[nitpick] Using nameof(Pages.Controls.CategoryChart) as the mapping key is unusual since this is typically a simple string identifier. Consider using a descriptive string constant like \"CategoryChartAccessibility\" instead for clarity.

src/Templates/src/templates/maui-mobile/MauiProgram.cs

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

src/Templates/src/templates/maui-mobile/Data/TagRepository.cs

jsuarezruiz · 2025-10-22T15:29:40Z

src/Templates/src/templates/maui-mobile/Pages/ProjectDetailPage.xaml

-                        BindableLayout.ItemTemplateSelector="{StaticResource ChipDataTemplateSelector}"/>
-                </ScrollView>
+
+                <!-- TODO This is still a little jumpy when changing selection -->


Is tracked somewhere in an issue?

@Vignesh-SF3580 please leave out any TODO comments on the templates

@jsuarezruiz I have checked the MAUI Samples issue reports - no related issue report were found.

Removed the TODO comments.

jfversluis · 2025-10-22T18:19:54Z

/azp run MAUI-public

azure-pipelines · 2025-10-22T18:20:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

jsuarezruiz · 2025-10-23T15:32:07Z

src/Templates/src/templates/maui-mobile/MauiProgram.cs

 #if (IncludeSampleContent)
 			.UseMauiCommunityToolkit()
 			.ConfigureSyncfusionToolkit()
+//-:cnd:noEmit


That's required?

yea, It's needed for the #IF WINDOWS Calls
We might want to move these so it's more explicilit that's what they are for

PureWeen · 2025-10-23T16:14:42Z

/backport to release/10.0.1xx

github-actions · 2025-10-23T16:14:58Z

Started backporting to release/10.0.1xx: https://github.com/dotnet/maui/actions/runs/18754846384

…#32112) * Initial plan * Migrate chart data label binding fix to Developer Balance template Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Integrate all changes from PR #32148 into Developer Balance template Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Add template semantic markers for platform-specific directives and document template conventions Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Update MauiProgram.cs * Move template instructions to path-specific YAML file Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Resync with PR #32148 - fix implementation differences Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Fix path-specific custom instructions format per GitHub docs Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Revert all template changes - keep only copilot instructions Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Update .github/copilot-instructions/templates.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Improve copilot instructions structure and clarity per feedback Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Vignesh-SF3580 added 2 commits October 22, 2025 13:39

moved changes from maui-samples to maui.

bc61584

Update ProjectListPageModel.cs

8c5d3c0

dotnet-policy-service bot added the community ✨ Community Contribution label Oct 22, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Oct 22, 2025

Tamilarasan-Paranthaman added the area-templates Project templates, Item Templates for Blazor and MAUI label Oct 22, 2025

Vignesh-SF3580 marked this pull request as ready for review October 22, 2025 12:46

Copilot AI review requested due to automatic review settings October 22, 2025 12:46

Copilot AI reviewed Oct 22, 2025

View reviewed changes

PureWeen added this to the .NET 10.0 GA milestone Oct 22, 2025

PureWeen added this to MAUI SDK Ongoing Oct 22, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Oct 22, 2025

PureWeen reviewed Oct 22, 2025

View reviewed changes

src/Templates/src/templates/maui-mobile/MauiProgram.cs Outdated Show resolved Hide resolved

Update MauiProgram.cs

ad9a7bd

PureWeen mentioned this pull request Oct 22, 2025

Add path-specific GitHub Copilot instructions for .NET MAUI Templates #32112

Merged

1 task

Copilot AI added a commit that referenced this pull request Oct 22, 2025

Integrate all changes from PR #32148 into Developer Balance template

b1e5115

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

jsuarezruiz suggested changes Oct 22, 2025

View reviewed changes

github-project-automation bot moved this from Todo to Changes Requested in MAUI SDK Ongoing Oct 22, 2025

Vignesh-SF3580 added 4 commits October 22, 2025 21:29

Update MauiProgram.cs

f180ab1

comments addressed.

04ec87b

updated review concerns

efaf851

Update ProjectDetailPage.xaml

5bd70a2

Copilot AI added a commit that referenced this pull request Oct 22, 2025

Resync with PR #32148 - fix implementation differences

25df86b

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

jsuarezruiz approved these changes Oct 23, 2025

View reviewed changes

github-project-automation bot moved this from Changes Requested to Approved in MAUI SDK Ongoing Oct 23, 2025

PureWeen approved these changes Oct 23, 2025

View reviewed changes

PureWeen merged commit 2be3a9f into dotnet:net10.0 Oct 23, 2025
20 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Oct 23, 2025

github-actions bot mentioned this pull request Oct 23, 2025

[release/10.0.1xx] Sync DeveloperBalance sample changes from the MAUI Samples repo to the .NET MAUI repo #32175

Merged

StephaneDelcroix mentioned this pull request Oct 24, 2025

[templates] sample content template uses deprecated API #32181

Closed

github-actions bot locked and limited conversation to collaborators Nov 23, 2025

	<!-- TODO This is still a little jumpy when changing selection -->
	<!-- UI jumpiness when changing tag selection. Tracked in issue #123. -->

	=> project is null ? null : Shell.Current.GoToAsync($"project?id={project.ID}");
	=> project is null ? Task.CompletedTask : Shell.Current.GoToAsync($"project?id={project.ID}");

Conversation

Vignesh-SF3580 commented Oct 22, 2025

Issue Details

Description of Change

Screenshots

Uh oh!

dotnet-policy-service bot commented Oct 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jfversluis commented Oct 22, 2025

Uh oh!

azure-pipelines bot commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PureWeen commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants