[Android] Fix WebView in a grid expands beyond it's cell #32145
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 32030, "Android - WebView in a grid expands beyond it's cell", PlatformAffected.Android)] | ||
|
|
||
| public class Issue32030 : ContentPage | ||
| { | ||
| WebView webView; | ||
|
|
||
| public Issue32030() | ||
| { | ||
| // Create Grid | ||
| var grid = new Grid | ||
| { | ||
| RowDefinitions = new RowDefinitionCollection | ||
| { | ||
| new RowDefinition { Height = new GridLength(50) }, | ||
| new RowDefinition { Height = GridLength.Star }, | ||
| new RowDefinition { Height = new GridLength(50) } | ||
| } | ||
| }; | ||
|
|
||
| // Create "above webview" Label | ||
| var topLabel = new Label | ||
| { | ||
| Text = "Above webview", | ||
| AutomationId = "TopLabel", | ||
| HorizontalTextAlignment = TextAlignment.Center | ||
| }; | ||
| grid.Add(topLabel); | ||
| Grid.SetRow(topLabel, 0); | ||
|
|
||
| // Create WebView | ||
| webView = new WebView | ||
| { | ||
| BackgroundColor = Colors.BurlyWood, | ||
| Source = new HtmlWebViewSource | ||
| { | ||
| Html = @"<html><body><h1>Initial Content</h1></body></html>" | ||
| } | ||
| }; | ||
| grid.Add(webView); | ||
| Grid.SetRow(webView, 1); | ||
|
|
||
| var button = new Button | ||
| { | ||
| Text = "Click Me", | ||
| AutomationId = "BottomButton", | ||
| }; | ||
|
|
||
| button.Clicked += (s, e) => | ||
| { | ||
| webView.Source = null; | ||
| }; | ||
| grid.Add(button); | ||
| Grid.SetRow(button, 2); | ||
|
|
||
| // Set the grid as the page content | ||
| Content = grid; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #if ANDROID //This is Android specific issue | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
| public class Issue32030 : _IssuesUITest | ||
| { | ||
| public Issue32030(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "Android - WebView in a grid expands beyond it's cell"; | ||
| [Test] | ||
| [Category(UITestCategories.WebView)] | ||
| public void VerifyWebViewStaysWithinGridCell() | ||
| { | ||
| App.WaitForElement("BottomButton"); | ||
| App.Tap("BottomButton"); | ||
| App.WaitForElement("BottomButton"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -57,7 +57,8 @@ public override void OnPageFinished(WebView? view, string? url) | |||||||||||
| bool navigate = _navigationResult != WebNavigationResult.Failure || !GetValidUrl(url).Equals(_lastUrlNavigatedCancel, StringComparison.OrdinalIgnoreCase); | ||||||||||||
| _lastUrlNavigatedCancel = _navigationResult == WebNavigationResult.Cancel ? url : null; | ||||||||||||
|
|
||||||||||||
| // Skip Navigated event for about:blank to prevent unwanted events when Source is null | ||||||||||||
| if (navigate && !IsBlankNavigation(url)) | ||||||||||||
| handler.VirtualView.Navigated(handler.CurrentNavigationEvent, GetValidUrl(url), _navigationResult); | ||||||||||||
|
|
||||||||||||
| handler.SyncPlatformCookiesToVirtualView(url); | ||||||||||||
|
|
@@ -96,6 +97,17 @@ public override bool OnRenderProcessGone(WebView? view, RenderProcessGoneDetail? | |||||||||||
| bool NavigatingCanceled(string? url) => | ||||||||||||
| !_handler.TryGetTarget(out var handler) || handler.NavigatingCanceled(url); | ||||||||||||
|
|
||||||||||||
| static bool IsBlankNavigation(string? url) | ||||||||||||
| { | ||||||||||||
| // Null/empty URLs are handled by the early return in OnPageFinished, | ||||||||||||
| // so we only need to check for the explicit "about:blank" URL | ||||||||||||
| if (string.IsNullOrWhiteSpace(url)) | ||||||||||||
| return false; | ||||||||||||
|
Comment on lines
+104
to
+105
There was a problem hiding this comment. The check
Suggested change
|
||||||||||||
|
|
||||||||||||
| // Check if URL is about:blank (case insensitive) | ||||||||||||
| return string.Equals(url.Trim(), "about:blank", StringComparison.OrdinalIgnoreCase); | ||||||||||||
|
Contributor
There was a problem hiding this comment. Could expand to more variants? Examples:
Contributor
There was a problem hiding this comment. This will be invoked on every Navigation. The impact on performance now is minimal for the current simple string comparison, but take this into account (for example, if think in use URI parsing or more complex stuff).
Contributor
Author
There was a problem hiding this comment. @jsuarezruiz , When the source is null, we set the default WebView source to about:blank. As a result, the OnPageFinished method always receives about:blank as the parameter. Therefore, handling additional variants such as about:blank# or about:blank/ is not necessary in this case. |
||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| static string GetValidUrl(string? url) | ||||||||||||
| { | ||||||||||||
| if (string.IsNullOrEmpty(url)) | ||||||||||||
|
|
||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (navigate && !IsBlankNavigation(url))Based on this:
This could break the fix from #29234 which wanted to prevent events when Source is null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz ,
url = null → IsBlankNavigation returns false → Navigated firesurl should never be null. We’ve modified the source so that if the source is not null, it uses that source; otherwise, it uses "about:blank".
In the OnPageFinished method, url should never be null.
url = "about:blank" → IsBlankNavigation returns true → Navigated doesn’t fireYes, this is the expected behavior. The PR#29234 resolves the issue where Android triggered the Navigating event with a null source.
With my fix, if the source is null, we set it to "about:blank". When the URL is "about:blank", the Navigating event will not fire.
So with the current fix, it resolves both issues #32030 and #29234.