[release/10.0.1xx] [android] fix Aspire integration / env vars#32120
Closed
github-actions[bot] wants to merge 1 commit intorelease/10.0.1xxfrom
Closed
[release/10.0.1xx] [android] fix Aspire integration / env vars#32120github-actions[bot] wants to merge 1 commit intorelease/10.0.1xxfrom
github-actions[bot] wants to merge 1 commit intorelease/10.0.1xxfrom
Conversation
I was trying to run a `dotnet new maui` project in .NET 10 RC 2, which
crashed with:
10-21 14:14:34.785 14069 14069 E AndroidRuntime: FATAL EXCEPTION: main
10-21 14:14:34.785 14069 14069 E AndroidRuntime: Process: com.companyname.hellomaui, PID: 14069
10-21 14:14:34.785 14069 14069 E AndroidRuntime: android.runtime.JavaProxyThrowable: [System.IndexOutOfRangeException]: Arg_IndexOutOfRangeException
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Microsoft.Maui.Hosting.AppHostBuilderExtensions+<>c.<ConfigureEnvironmentVariables>b__2_2 + 0x0(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at System.Linq.Enumerable.ToDictionary + 0x8c(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at System.Linq.Enumerable.ToDictionary + 0x0(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Microsoft.Maui.Hosting.AppHostBuilderExtensions.ConfigureEnvironmentVariables + 0x5a(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Microsoft.Maui.Hosting.MauiAppBuilder..ctor + 0x12e(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Microsoft.Maui.Hosting.MauiApp.CreateBuilder + 0x0(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at hellomaui.MauiProgram.CreateMauiApp + 0x0(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at hellomaui.MainApplication.CreateMauiApp + 0x0(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Microsoft.Maui.MauiApplication.OnCreate + 0xb(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at Android.App.Application.n_OnCreate + 0x16(Unknown Source)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at crc6488302ad6e9e4df1a.MauiApplication.n_onCreate(Native Method)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at crc6488302ad6e9e4df1a.MauiApplication.onCreate(MauiApplication.java:17)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1381)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7830)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2546)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:110)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:248)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.os.Looper.loop(Looper.java:338)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:9067)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
10-21 14:14:34.785 14069 14069 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:932)
Reviewing the existing code:
https://github.com/dotnet/maui/blob/a4c124661c1e3c2f530ff2d4ec4c0a86eda8fcbb/src/Core/src/Hosting/Dispatching/AppHostBuilderExtensions.cs#L53-L57
So, I looked at the contents of:
> adb pull /data/local/tmp/ide-launchenv.txt
/data/local/tmp/ide-launchenv.txt: 1 file pulled, 0 skipped. 0.0 MB/s (3 bytes in 0.002s)
The file contains a line with a space character and a newline. No idea
what put that there?!?
I think the `Select(line => line.Split('=', 2))` call is problematic,
in addition to the `ToDictionary()` call. I think both of these could
throw exceptions on malformed / weird files.
I also got "nerd sniped" to improve the performance:
* `System.IO.File.ReadAllLines()` allocates a `string[]`
* `line.Split('=', 2)` allocates a `string[]`
* `ToDictionary(...)` allocates a dictionary and enumerates
everything again.
We can just flatten the System.Linq usage here into a `foreach` loop
and avoid those allocations. We can also use `IndexOf('=')` to find
the split point.
After these changes, the app no longer crashes and starts up fine.
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
|
Closing in favor of: |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32119 to release/10.0.1xx
/cc @PureWeen @jonathanpeppers