-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Merge main into net10 #32079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into net10 #32079
Changes from all commits
10b65f8
d6bbe9d
1206ef5
11ce8c9
082d25a
3d3f594
ba41e49
bf850e0
689f525
ae3af22
f3a11af
d9ba884
4906519
e6dd13e
37aef27
a8a818e
4615c94
1e56eca
ad506dc
a0a6311
922b3b2
ba96840
3e8446c
97ef945
641945f
1240586
17f4baf
e9d69ec
b1f5361
1596b7c
0ea6ee1
ce6f0a7
60513de
c94dbee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <RunSettings> | ||
| <DataCollectionRunSettings> | ||
| <DataCollectionProviders> | ||
| <DataCollectionProvider friendlyName="Code Coverage"> | ||
| <Configuration> | ||
| <Module> | ||
| <Exclude> | ||
| <Module name="*" /> | ||
| </Exclude> | ||
| <Include> | ||
| <Module name="Microsoft.Maui*.dll" /> | ||
| </Include> | ||
| </Module> | ||
| </Configuration> | ||
| </DataCollectionProvider> | ||
| </DataCollectionProviders> | ||
| </DataCollectionRunSettings> | ||
| </RunSettings> |
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -31,6 +31,7 @@ steps: | |||
| inputs: | ||||
| azureSubscription: ${{ parameters.federatedServiceConnection }} | ||||
| scriptType: 'pscore' | ||||
| addSpnToEnvironment: true | ||||
|
||||
| addSpnToEnvironment: true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,11 @@ public override void ViewDidAppear(bool animated) | |
| { | ||
| base.ViewDidAppear(animated); | ||
| Page.SendAppearing(); | ||
| if (!_intialLayoutFinished) | ||
| { | ||
| _intialLayoutFinished = true; | ||
| SetInitialPresented(); | ||
| } | ||
| } | ||
|
|
||
| public override void ViewDidDisappear(bool animated) | ||
|
|
@@ -158,19 +163,6 @@ void SetInitialPresented() | |
| UpdateLeftBarButton(); | ||
| } | ||
|
|
||
| public override void ViewWillLayoutSubviews() | ||
| { | ||
| // Orientation doesn't seem to be set to a stable correct value until here. | ||
| // So, we officially process orientation here. | ||
| if (!_intialLayoutFinished) | ||
| { | ||
| _intialLayoutFinished = true; | ||
| SetInitialPresented(); | ||
| } | ||
|
|
||
| base.ViewWillLayoutSubviews(); | ||
| } | ||
|
|
||
| public override void ViewDidLoad() | ||
|
Comment on lines
163
to
166
|
||
| { | ||
| base.ViewDidLoad(); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,12 +19,12 @@ public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destina | |
|
|
||
| if (strValue == "HorizontalList") | ||
| { | ||
| return LinearItemsLayout.CarouselDefault; | ||
| return LinearItemsLayout.CreateCarouselHorizontalDefault(); | ||
| } | ||
|
|
||
| if (strValue == "VerticalList") | ||
| { | ||
| return LinearItemsLayout.CarouselVertical; | ||
| return LinearItemsLayout.CreateCarouselVerticalDefault(); | ||
| } | ||
|
Comment on lines
19
to
28
|
||
|
|
||
| throw new InvalidOperationException($"Cannot convert \"{strValue}\" into {typeof(LinearItemsLayout)}"); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,11 +26,11 @@ public override bool CanConvertTo(ITypeDescriptorContext? context, Type? destina | |
|
|
||
| if (strValue == "VerticalList") | ||
| { | ||
| return LinearItemsLayout.Vertical; | ||
| return LinearItemsLayout.CreateVerticalDefault(); | ||
| } | ||
| else if (strValue == "HorizontalList") | ||
| { | ||
| return LinearItemsLayout.Horizontal; | ||
| return LinearItemsLayout.CreateHorizontalDefault(); | ||
| } | ||
|
Comment on lines
26
to
34
|
||
| else if (strValue.StartsWith("VerticalGrid", StringComparison.Ordinal)) | ||
| { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,7 +113,8 @@ public int RemainingItemsThreshold | |
|
|
||
| internal static readonly BindableProperty InternalItemsLayoutProperty = | ||
| BindableProperty.Create(nameof(ItemsLayout), typeof(IItemsLayout), typeof(ItemsView), | ||
| LinearItemsLayout.Vertical, propertyChanged: OnInternalItemsLayoutPropertyChanged); | ||
| null, propertyChanged: OnInternalItemsLayoutPropertyChanged, | ||
| defaultValueCreator: (b) => LinearItemsLayout.CreateVerticalDefault()); | ||
|
Comment on lines
114
to
+117
|
||
|
|
||
| static void OnInternalItemsLayoutPropertyChanged(BindableObject bindable, object oldValue, object newValue) | ||
| { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern: addSpnToEnvironment: true unnecessarily exposes credentials. Prefer omitting unless a downstream script explicitly consumes those variables.