Skip to content

[Testing] Fix for the ProgressSpinnerWorksWhenReEnabled flaky test in CI #31951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Oct 10, 2025
Merged

[Testing] Fix for the ProgressSpinnerWorksWhenReEnabled flaky test in CI #31951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28343.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void ProgressSpinnerRemainsDisabledAfterSwappingContent()
public void ProgressSpinnerWorksWhenReEnabled()
{
App.WaitForElement("SetToEnabled").Tap();
App.ScrollUp("CollectionView");
App.ScrollUp("CollectionView", ScrollStrategy.Gesture, swipePercentage:0.99, swipeSpeed:2500);
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding spaces around the colon in named parameters for consistency with C# coding conventions. The parameter should be swipePercentage: 0.99 instead of swipePercentage:0.99.

Suggested change
App.ScrollUp("CollectionView", ScrollStrategy.Gesture, swipePercentage:0.99, swipeSpeed:2500);
App.ScrollUp("CollectionView", ScrollStrategy.Gesture, swipePercentage: 0.99, swipeSpeed: 2500);

Copilot uses AI. Check for mistakes.
App.WaitForElement("RefreshTriggered");
}
}
Expand Down
Loading