[Testing] Include more testing around Windows Image Aspect recent fixes#31694
Open
jsuarezruiz wants to merge 10 commits intonet10.0from
Open
[Testing] Include more testing around Windows Image Aspect recent fixes#31694jsuarezruiz wants to merge 10 commits intonet10.0from
jsuarezruiz wants to merge 10 commits intonet10.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive UI testing coverage for the recent Windows Image Aspect fixes related to issue 30403. The changes validate that images with AspectFit now properly respect VerticalOptions and HorizontalOptions on Windows platforms.
Key changes:
- Adds extensive test coverage for different image sizes and alignment scenarios
- Creates dedicated test pages for panoramic images, small images, and general image alignment
- Implements automated UI tests to verify aspect ratio preservation and alignment behavior
Reviewed Changes
Copilot reviewed 8 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt |
Adds new public API for Windows ImageHandler.GetDesiredSize override |
src/Core/src/Handlers/Image/ImageHandler.Windows.cs |
Implements GetDesiredSize override and platform constraint management for AspectFit images |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30403SmallImages.cs |
Automated tests for small image behavior with various alignments and container sizes |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30403PanoramicImages.cs |
Automated tests for panoramic image alignment and aspect ratio preservation |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30403.cs |
Basic UI test for the original issue scenario |
src/Controls/tests/TestCases.HostApp/Issues/Issue30403SmallImages.cs |
Test page UI for small image scenarios with multiple test cases |
src/Controls/tests/TestCases.HostApp/Issues/Issue30403PanoramicImages.cs |
Test page UI for panoramic image scenarios with interactive elements |
src/Controls/tests/TestCases.HostApp/Issues/Issue30403.cs |
Basic test page for the original issue reproduction |
Comments suppressed due to low confidence (1)
src/Core/src/Handlers/Image/ImageHandler.Windows.cs:1
- Consider adding null checks for ih.PlatformView before setting MaxWidth and MaxHeight properties to prevent potential null reference exceptions.
using System;
src/Controls/tests/TestCases.HostApp/Issues/Issue30403PanoramicImages.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Added more tests to validate the recent changes related with Windows image Aspect: #30936 (comment)
Issues Fixed
Fixes #31686