-
Notifications
You must be signed in to change notification settings - Fork 2k
Fixed Rectangle renders as thin line instead of filled shape for small height #31651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f8131f
Fixed Rectangle renders as thin line instead of filled shape for smal…
Dhivya-SF4094 0c1384e
Updated test sample
Dhivya-SF4094 8fcb193
Resaved image
Dhivya-SF4094 42942af
Resaved images and updated border test sample
Dhivya-SF4094 0a4f09d
Fixed build error and updated test sample
Dhivya-SF4094 a57625e
Addressed AI summary and fixed Border test
Dhivya-SF4094 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-596 Bytes
(98%)
...ases.Android.Tests/snapshots/android/BackgroundFrameResizesFastAndCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.04 KB
(100%)
...d.Tests/snapshots/android/BackgroundFrameResizesFastAndCorrectlySizeChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+306 Bytes
(100%)
...es.Android.Tests/snapshots/android/BackgroundGradientsShouldRenderCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12 Bytes
(100%)
...ts/TestCases.Android.Tests/snapshots/android/BindingOnStrokeShapeWithRadius.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-146 Bytes
(99%)
...TestCases.Android.Tests/snapshots/android/BindingOnStrokeShapeWithoutRadius.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+16.9 KB
(280%)
...droid.Tests/snapshots/android/BorderBackgroundSizeUpdatesWhenRotatingScreen.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.12 KB
(100%)
...sts/TestCases.Android.Tests/snapshots/android/BorderRoundRectangleWithImage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-196 Bytes
(99%)
...apshots/android/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.59 KB
(96%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Border_Shadow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.62 KB
(95%)
...es.Android.Tests/snapshots/android/Border_StrokeColorWithDashArrayAndOffset.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-901 Bytes
(98%)
...id.Tests/snapshots/android/Border_StrokeColorWithStrokeShape_RoundRectangle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.6 KB
(95%)
...Cases.Android.Tests/snapshots/android/Border_StrokeColorWithStrokeThickness.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-144 Bytes
(99%)
...oid.Tests/snapshots/android/CollectionViewGroupFooterTemplateShouldNotCrash.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+662 Bytes
(100%)
...estCases.Android.Tests/snapshots/android/FirstCustomPageWithBackgroundColor.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+886 Bytes
(100%)
.../TestCases.Android.Tests/snapshots/android/FirstCustomPageWithFlowDirection.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+639 Bytes
(100%)
...stCases.Android.Tests/snapshots/android/FirstCustomPageWithIconImageChanged.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+24 Bytes
(100%)
...ases.Android.Tests/snapshots/android/FooterWithEmptyCVShouldHaveCorrectSize.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-339 Bytes
(99%)
...ts/TestCases.Android.Tests/snapshots/android/HeaderAndFooterShouldBeVisible.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-230 Bytes
(100%)
...ases.Android.Tests/snapshots/android/HorizontalStackLayout_RTLFlowDirection.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-230 Bytes
(100%)
....Tests/snapshots/android/HorizontalStackLayout_RTLFlowDirection_With_Height.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-236 Bytes
(100%)
...napshots/android/HorizontalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-236 Bytes
(100%)
...d.Tests/snapshots/android/HorizontalStackLayout_RTLFlowDirection_With_Width.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-218 Bytes
(100%)
...s.Android.Tests/snapshots/android/HorizontalStackLayout_Spacing_With_Height.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-205 Bytes
(100%)
...d.Tests/snapshots/android/HorizontalStackLayout_Spacing_With_HeightAndWidth.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-211 Bytes
(100%)
...ases.Android.Tests/snapshots/android/HorizontalStackLayout_Spacing_With_RTL.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-205 Bytes
(100%)
...es.Android.Tests/snapshots/android/HorizontalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
+850 Bytes
(100%)
...tCases.Android.Tests/snapshots/android/IndicatorWithTemplateShouldBeVisible.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...s/tests/TestCases.Android.Tests/snapshots/android/Issue22606_SetHeightTo200.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...s/tests/TestCases.Android.Tests/snapshots/android/Issue22606_SetHeightTo500.png
Oops, something went wrong.
Binary file modified
BIN
+3.09 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test.png
Oops, something went wrong.
Binary file modified
BIN
+3.77 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_1.png
Oops, something went wrong.
Binary file modified
BIN
+2.7 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_2.png
Oops, something went wrong.
Binary file modified
BIN
+2.12 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_3.png
Oops, something went wrong.
Binary file modified
BIN
+2.97 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_4.png
Oops, something went wrong.
Binary file modified
BIN
+1.1 KB
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_5.png
Oops, something went wrong.
Binary file modified
BIN
-1.37 KB
(92%)
...sts/TestCases.Android.Tests/snapshots/android/LinearGradientBrushShouldWork.png
Oops, something went wrong.
Binary file modified
BIN
-841 Bytes
(95%)
...Tests/snapshots/android/LinearGradientShouldHaveTheSameTopColorAsBackground.png
Oops, something went wrong.
Binary file modified
BIN
+1.18 KB
(110%)
...tCases.Android.Tests/snapshots/android/RadioButtonUpdateValueInsideBorderNo.png
Oops, something went wrong.
Binary file modified
BIN
+262 Bytes
(100%)
...estCases.Android.Tests/snapshots/android/RadioButtonWithValueChangeSelected.png
Oops, something went wrong.
Binary file modified
BIN
-94 Bytes
(100%)
...ontrols/tests/TestCases.Android.Tests/snapshots/android/RemoveShadowRuntime.png
Oops, something went wrong.
Binary file modified
BIN
-32 Bytes
(100%)
....Android.Tests/snapshots/android/SecondCustomPageWithBackgroundColorChanged.png
Oops, something went wrong.
Binary file modified
BIN
+992 Bytes
(100%)
...d.Tests/snapshots/android/SelectionShouldNotMovedToTopWithGroupedCollection.png
Oops, something went wrong.
Binary file modified
BIN
-97 Bytes
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/ShadowAddClip.png
Oops, something went wrong.
Binary file modified
BIN
+2.35 KB
(110%)
...Controls/tests/TestCases.Android.Tests/snapshots/android/ShadowShouldUpdate.png
Oops, something went wrong.
Binary file modified
BIN
-76 Bytes
(100%)
...Controls/tests/TestCases.Android.Tests/snapshots/android/ShadowUpdateColor1.png
Oops, something went wrong.
Binary file modified
BIN
-126 Bytes
(100%)
...Controls/tests/TestCases.Android.Tests/snapshots/android/ShadowUpdateColor2.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(100%)
...oid.Tests/snapshots/android/Shadow_ChangeFlowDirection_RTL_VerifyScreenshot.png
Oops, something went wrong.
Binary file modified
BIN
-76 Bytes
(100%)
src/Controls/tests/TestCases.Android.Tests/snapshots/android/Shadow_SetColor.png
Oops, something went wrong.
Binary file modified
BIN
-1.13 KB
(99%)
...roid.Tests/snapshots/android/Shadow_SetEnabledStateToFalse_VerifyScreenshot.png
Oops, something went wrong.
Binary file modified
BIN
-177 Bytes
(100%)
...s/TestCases.Android.Tests/snapshots/android/Shadow_SetOffset_PositiveValues.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...trols/tests/TestCases.Android.Tests/snapshots/android/Shadow_SetRadius_Zero.png
Oops, something went wrong.
Binary file modified
BIN
+71 Bytes
(100%)
...tests/TestCases.Android.Tests/snapshots/android/ShapeBackgroundColorChanges.png
Oops, something went wrong.
Binary file modified
BIN
+30.5 KB
(140%)
...roid.Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_FlyoutPage.png
Oops, something went wrong.
Binary file modified
BIN
+30.7 KB
(140%)
....Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_NavigationPage.png
Oops, something went wrong.
Binary file modified
BIN
-187 Bytes
(100%)
...s.Android.Tests/snapshots/android/ToolbarExtendsAllTheWayLeftAndRight_Shell.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
...s/tests/TestCases.Android.Tests/snapshots/android/TwoPaneView_Pane1Priority.png
Oops, something went wrong.
Binary file modified
BIN
-126 Bytes
(100%)
...sts/TestCases.Android.Tests/snapshots/android/TwoPaneView_Pane1SizeIncrease.png
Oops, something went wrong.
Binary file modified
BIN
-24 Bytes
(100%)
....Android.Tests/snapshots/android/TwoPaneView_Pane1SizeIncrease_WithWideMode.png
Oops, something went wrong.
Binary file modified
BIN
-119 Bytes
(100%)
...sts/TestCases.Android.Tests/snapshots/android/TwoPaneView_Pane2SizeIncrease.png
Oops, something went wrong.
Binary file modified
BIN
-24 Bytes
(100%)
....Android.Tests/snapshots/android/TwoPaneView_Pane2SizeIncrease_WithWideMode.png
Oops, something went wrong.
Binary file modified
BIN
-13 Bytes
(100%)
...ests/TestCases.Android.Tests/snapshots/android/TwoPaneView_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-234 Bytes
(100%)
...ts/TestCases.Android.Tests/snapshots/android/TwoPaneView_ShadowWithWideMode.png
Oops, something went wrong.
Binary file modified
BIN
-127 Bytes
(100%)
...ntrols/tests/TestCases.Android.Tests/snapshots/android/TwoPaneView_TallMode.png
Oops, something went wrong.
Binary file modified
BIN
-22 Bytes
(100%)
...ntrols/tests/TestCases.Android.Tests/snapshots/android/TwoPaneView_WideMode.png
Oops, something went wrong.
Binary file modified
BIN
-335 Bytes
(100%)
...ests/TestCases.Android.Tests/snapshots/android/TwoPaneView_ZIsShadowEnabled.png
Oops, something went wrong.
Binary file added
BIN
+29.7 KB
...ts/TestCases.Android.Tests/snapshots/android/UpdateSizeOnlyWhenStrokeExists.png
Oops, something went wrong.
Binary file modified
BIN
-41 Bytes
(100%)
...s/TestCases.Android.Tests/snapshots/android/VerifyBorderWithStrokeDashArray.png
Oops, something went wrong.
Binary file modified
BIN
-248 Bytes
(100%)
...TestCases.Android.Tests/snapshots/android/VerifyFontImageWithFontColorGreen.png
Oops, something went wrong.
Binary file modified
BIN
+162 Bytes
(100%)
...tests/TestCases.Android.Tests/snapshots/android/VerifyFontImageWithFontSize.png
Oops, something went wrong.
Binary file modified
BIN
+632 Bytes
(100%)
...Tests/snapshots/android/VerifyImageAspect_AspectFillWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-1.07 KB
(99%)
.../snapshots/android/VerifyImageAspect_AspectFillWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-51 Bytes
(100%)
...sts/snapshots/android/VerifyImageAspect_AspectFillWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+4.23 KB
(100%)
....Tests/snapshots/android/VerifyImageAspect_AspectFillWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+379 Bytes
(100%)
....Tests/snapshots/android/VerifyImageAspect_AspectFitWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
+168 Bytes
(100%)
...s/snapshots/android/VerifyImageAspect_AspectFitWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...ests/snapshots/android/VerifyImageAspect_AspectFitWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+2.1 KB
(100%)
...d.Tests/snapshots/android/VerifyImageAspect_AspectFitWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
-51 Bytes
(100%)
...oid.Tests/snapshots/android/VerifyImageAspect_CenterWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-28 Bytes
(100%)
...ests/snapshots/android/VerifyImageAspect_CenterWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-51 Bytes
(100%)
...d.Tests/snapshots/android/VerifyImageAspect_CenterWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+4.23 KB
(100%)
...roid.Tests/snapshots/android/VerifyImageAspect_CenterWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+357 Bytes
(100%)
...droid.Tests/snapshots/android/VerifyImageAspect_FillWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-373 Bytes
(100%)
....Tests/snapshots/android/VerifyImageAspect_FillWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...oid.Tests/snapshots/android/VerifyImageAspect_FillWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+6.64 KB
(100%)
...ndroid.Tests/snapshots/android/VerifyImageAspect_FillWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+379 Bytes
(100%)
...tests/TestCases.Android.Tests/snapshots/android/VerifyImageFlowDirectionRTL.png
Oops, something went wrong.
Binary file modified
BIN
+299 Bytes
(100%)
...trols/tests/TestCases.Android.Tests/snapshots/android/VerifyImageWithShadow.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
...ntrols/tests/TestCases.Android.Tests/snapshots/android/VerifyIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
...estCases.Android.Tests/snapshots/android/VerifyIndicatorColorWhenItemsAdded.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...Cases.Android.Tests/snapshots/android/VerifyIndicatorColorWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...ases.Android.Tests/snapshots/android/VerifyIndicatorColorWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...Cases.Android.Tests/snapshots/android/VerifyIndicatorColorWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
.../TestCases.Android.Tests/snapshots/android/VerifyIndicatorHideSingleIsFalse.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...napshots/android/VerifyIndicatorHideSingleIsFalseWithSelectedIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
....Android.Tests/snapshots/android/VerifyIndicatorHideSingleWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...ntrols/tests/TestCases.Android.Tests/snapshots/android/VerifyIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...Cases.Android.Tests/snapshots/android/VerifyIndicatorShapeWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...estCases.Android.Tests/snapshots/android/VerifyIndicatorShapeWithHideSingle.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...ases.Android.Tests/snapshots/android/VerifyIndicatorShapeWithMaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-46 Bytes
(100%)
.../TestCases.Android.Tests/snapshots/android/VerifyIndicatorShapeWithPosition.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...ts/TestCases.Android.Tests/snapshots/android/VerifyIndicatorShapeWithShadow.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
...tCases.Android.Tests/snapshots/android/VerifyIndicatorSizeWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-32 Bytes
(100%)
...Cases.Android.Tests/snapshots/android/VerifyIndicatorSizeWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
...Cases.Android.Tests/snapshots/android/VerifyIndicatorSizeWithMaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...sts/TestCases.Android.Tests/snapshots/android/VerifyIndicatorSizeWithShadow.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...TestCases.Android.Tests/snapshots/android/VerifyIndicatorView_FlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...ts/TestCases.Android.Tests/snapshots/android/VerifyIndicatorView_HideSingle.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...sts/TestCases.Android.Tests/snapshots/android/VerifyIndicatorView_IsVisible.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...estCases.Android.Tests/snapshots/android/VerifyIndicatorView_MaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
.../tests/TestCases.Android.Tests/snapshots/android/VerifyIndicatorView_Shadow.png
Oops, something went wrong.
Binary file modified
BIN
-30 Bytes
(100%)
...ests/TestCases.Android.Tests/snapshots/android/VerifySelectedIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-49 Bytes
(100%)
...ndroid.Tests/snapshots/android/VerifySelectedIndicatorColorWhenItemsChanged.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...droid.Tests/snapshots/android/VerifySelectedIndicatorColorWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...roid.Tests/snapshots/android/VerifySelectedIndicatorColorWithIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...roid.Tests/snapshots/android/VerifySelectedIndicatorColorWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-29 Bytes
(100%)
...droid.Tests/snapshots/android/VerifySelectedIndicatorColorWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-46 Bytes
(100%)
...es.Android.Tests/snapshots/android/VerifySelectedIndicatorColorWithPosition.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(100%)
...tests/TestCases.Android.Tests/snapshots/android/VerifySelectedIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-170 Bytes
(100%)
...tCases.Android.Tests/snapshots/android/VerticalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-170 Bytes
(100%)
...id.Tests/snapshots/android/VerticalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-179 Bytes
(100%)
.../snapshots/android/VerticalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-179 Bytes
(100%)
...oid.Tests/snapshots/android/VerticalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-139 Bytes
(100%)
...ses.Android.Tests/snapshots/android/VerticalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-136 Bytes
(100%)
...oid.Tests/snapshots/android/VerticalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-132 Bytes
(100%)
...tCases.Android.Tests/snapshots/android/VerticalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-136 Bytes
(100%)
...ases.Android.Tests/snapshots/android/VerticalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
108 changes: 108 additions & 0 deletions
108
src/Controls/tests/TestCases.HostApp/Issues/Issue31330.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| using Microsoft.Maui.Controls.Shapes; | ||
| using Microsoft.Maui.Layouts; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 31330, "Rectangle renders as thin line instead of filled shape for small height values", PlatformAffected.Android | PlatformAffected.iOS)] | ||
| public class Issue31330 : ContentPage | ||
| { | ||
| public Issue31330() | ||
| { | ||
| var scrollView = new ScrollView(); | ||
| var grid = new Grid | ||
| { | ||
| BackgroundColor = Colors.LightGray, | ||
| RowSpacing = 10, | ||
| }; | ||
|
|
||
| grid.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto }); | ||
| grid.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto }); | ||
| grid.RowDefinitions.Add(new RowDefinition { Height = GridLength.Auto }); | ||
| grid.RowDefinitions.Add(new RowDefinition { Height = GridLength.Star }); | ||
|
|
||
| // Instructions | ||
| var instructions = new Label | ||
| { | ||
| Text = "Test passes if:\n1. Green BoxView (height 1.2) is visible as a filled rectangle\n2. Blue Rectangle (height 1.2) is visible as a filled rectangle (not a thin line)\n3. Both should have similar appearance", | ||
| FontAttributes = FontAttributes.Bold, | ||
| AutomationId = "Instructions" | ||
| }; | ||
| Grid.SetRow(instructions, 0); | ||
| grid.Children.Add(instructions); | ||
|
|
||
| // BoxView with small height (reference for correct rendering) | ||
| var boxViewLabel = new Label { Text = "BoxView (height 1.2):" }; | ||
| Grid.SetRow(boxViewLabel, 1); | ||
| grid.Children.Add(boxViewLabel); | ||
|
|
||
| var boxView = new BoxView | ||
| { | ||
| Color = Colors.Green, | ||
| WidthRequest = 50, | ||
| HeightRequest = 1.2, | ||
| HorizontalOptions = LayoutOptions.Start, | ||
| VerticalOptions = LayoutOptions.Start, | ||
| AutomationId = "TestBoxView" | ||
| }; | ||
| Grid.SetRow(boxView, 1); | ||
| grid.Children.Add(boxView); | ||
|
|
||
| // Rectangle with small height (should render like BoxView, not as a line) | ||
| var rectangleLabel = new Label { Text = "Rectangle (height 1.2, Fill only, no Stroke):" }; | ||
| Grid.SetRow(rectangleLabel, 2); | ||
| grid.Children.Add(rectangleLabel); | ||
|
|
||
| var rectangle = new Rectangle | ||
| { | ||
| WidthRequest = 50, | ||
| HeightRequest = 1.2, | ||
| Fill = Colors.Blue, | ||
| Stroke = null, // Explicitly no stroke | ||
| HorizontalOptions = LayoutOptions.Start, | ||
| VerticalOptions = LayoutOptions.Start, | ||
| AutomationId = "TestRectangle" | ||
| }; | ||
| Grid.SetRow(rectangle, 2); | ||
| grid.Children.Add(rectangle); | ||
|
|
||
| // AbsoluteLayout test (from original issue report) | ||
| var absoluteLayout = new AbsoluteLayout(); | ||
| Grid.SetRow(absoluteLayout, 3); | ||
| grid.Children.Add(absoluteLayout); | ||
|
|
||
| double shapeWidth = 20; | ||
| double shapeHeight = 1.2; | ||
| double shapeY = 10; | ||
|
|
||
| // BoxView in AbsoluteLayout (reference) | ||
| var absBoxView = new BoxView | ||
| { | ||
| BackgroundColor = Colors.Green | ||
| }; | ||
| AbsoluteLayout.SetLayoutBounds(absBoxView, new Rect( | ||
| 0, | ||
| shapeY, | ||
| shapeWidth, | ||
| shapeHeight | ||
| )); | ||
| AbsoluteLayout.SetLayoutFlags(absBoxView, AbsoluteLayoutFlags.None); | ||
| absoluteLayout.Children.Add(absBoxView); | ||
|
|
||
| // Rectangle in AbsoluteLayout (should match BoxView appearance) | ||
| var absRectangle = new Rectangle | ||
| { | ||
| Fill = Colors.Blue | ||
| }; | ||
| AbsoluteLayout.SetLayoutBounds(absRectangle, new Rect( | ||
| 30, | ||
| shapeY, | ||
| shapeWidth, | ||
| shapeHeight | ||
| )); | ||
| AbsoluteLayout.SetLayoutFlags(absRectangle, AbsoluteLayoutFlags.None); | ||
| absoluteLayout.Children.Add(absRectangle); | ||
|
|
||
| scrollView.Content = grid; | ||
| Content = scrollView; | ||
| } | ||
| } |
Binary file modified
BIN
+474 Bytes
(100%)
...ts/TestCases.Mac.Tests/snapshots/mac/BackgroundFrameResizesFastAndCorrectly.png
Oops, something went wrong.
Binary file modified
BIN
+362 Bytes
(100%)
...s.Mac.Tests/snapshots/mac/BackgroundFrameResizesFastAndCorrectlySizeChanged.png
Oops, something went wrong.
Binary file modified
BIN
-132 Bytes
(99%)
...rols/tests/TestCases.Mac.Tests/snapshots/mac/BindingOnStrokeShapeWithRadius.png
Oops, something went wrong.
Binary file modified
BIN
-147 Bytes
(99%)
...s/tests/TestCases.Mac.Tests/snapshots/mac/BindingOnStrokeShapeWithoutRadius.png
Oops, something went wrong.
Binary file modified
BIN
-360 Bytes
(97%)
...s/snapshots/mac/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png
Oops, something went wrong.
Binary file modified
BIN
-1.42 KB
(91%)
...es.Mac.Tests/snapshots/mac/Border_StrokeColorWithStrokeShape_RoundRectangle.png
Oops, something went wrong.
Binary file modified
BIN
-1.85 KB
(88%)
...sts/TestCases.Mac.Tests/snapshots/mac/Border_StrokeColorWithStrokeThickness.png
Oops, something went wrong.
Binary file modified
BIN
-563 Bytes
(92%)
...ses.Mac.Tests/snapshots/mac/CollectionViewGroupFooterTemplateShouldNotCrash.png
Oops, something went wrong.
Binary file modified
BIN
-656 Bytes
(98%)
.../tests/TestCases.Mac.Tests/snapshots/mac/FirstCustomPageWithBackgroundColor.png
Oops, something went wrong.
Binary file modified
BIN
-444 Bytes
(99%)
...ls/tests/TestCases.Mac.Tests/snapshots/mac/FirstCustomPageWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-121 Bytes
(100%)
...tests/TestCases.Mac.Tests/snapshots/mac/FirstCustomPageWithIconImageChanged.png
Oops, something went wrong.
Binary file modified
BIN
+476 Bytes
(110%)
...ts/TestCases.Mac.Tests/snapshots/mac/FooterWithEmptyCVShouldHaveCorrectSize.png
Oops, something went wrong.
Binary file modified
BIN
-205 Bytes
(99%)
...rols/tests/TestCases.Mac.Tests/snapshots/mac/HeaderAndFooterShouldBeVisible.png
Oops, something went wrong.
Binary file modified
BIN
-677 Bytes
(98%)
...ts/TestCases.Mac.Tests/snapshots/mac/HorizontalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-789 Bytes
(97%)
....Mac.Tests/snapshots/mac/HorizontalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-791 Bytes
(97%)
...ts/snapshots/mac/HorizontalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-664 Bytes
(98%)
...s.Mac.Tests/snapshots/mac/HorizontalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-477 Bytes
(98%)
...TestCases.Mac.Tests/snapshots/mac/HorizontalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-972 Bytes
(97%)
...s.Mac.Tests/snapshots/mac/HorizontalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-285 Bytes
(99%)
...ts/TestCases.Mac.Tests/snapshots/mac/HorizontalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-710 Bytes
(97%)
.../TestCases.Mac.Tests/snapshots/mac/HorizontalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-671 Bytes
(93%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue22606_SetHeightTo200.png
Oops, something went wrong.
Binary file modified
BIN
-1.09 KB
(90%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue22606_SetHeightTo500.png
Oops, something went wrong.
Binary file modified
BIN
-5.17 KB
(92%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test.png
Oops, something went wrong.
Binary file modified
BIN
-2.56 KB
(96%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test_1.png
Oops, something went wrong.
Binary file modified
BIN
-916 Bytes
(99%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test_2.png
Oops, something went wrong.
Binary file modified
BIN
-576 Bytes
(99%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test_3.png
Oops, something went wrong.
Binary file modified
BIN
-466 Bytes
(99%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test_4.png
Oops, something went wrong.
Binary file modified
BIN
-1.05 KB
(97%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue24414Test_5.png
Oops, something went wrong.
Binary file modified
BIN
-986 Bytes
(93%)
...trols/tests/TestCases.Mac.Tests/snapshots/mac/LinearGradientBrushShouldWork.png
Oops, something went wrong.
Binary file modified
BIN
-444 Bytes
(99%)
...s/snapshots/mac/RadioButton_SetBorderWidthAndCornerRadius_VerifyVisualState.png
Oops, something went wrong.
Binary file modified
BIN
-384 Bytes
(99%)
...estCases.Mac.Tests/snapshots/mac/SecondCustomPageWithBackgroundColorChanged.png
Oops, something went wrong.
Binary file modified
BIN
-241 Bytes
(98%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/ShadowShouldUpdate.png
Oops, something went wrong.
Binary file modified
BIN
-422 Bytes
(95%)
...ontrols/tests/TestCases.Mac.Tests/snapshots/mac/ShapeBackgroundColorChanges.png
Oops, something went wrong.
Binary file added
BIN
+28.6 KB
...rols/tests/TestCases.Mac.Tests/snapshots/mac/UpdateSizeOnlyWhenStrokeExists.png
Oops, something went wrong.
Binary file modified
BIN
-456 Bytes
(97%)
...ols/tests/TestCases.Mac.Tests/snapshots/mac/VerifyBorderWithStrokeDashArray.png
Oops, something went wrong.
Binary file modified
BIN
+13 Bytes
(100%)
...s/tests/TestCases.Mac.Tests/snapshots/mac/VerifyFontImageWithFontColorGreen.png
Oops, something went wrong.
Binary file modified
BIN
-164 Bytes
(99%)
...ontrols/tests/TestCases.Mac.Tests/snapshots/mac/VerifyFontImageWithFontSize.png
Oops, something went wrong.
Binary file modified
BIN
-242 Bytes
(100%)
...Mac.Tests/snapshots/mac/VerifyImageAspect_AspectFillWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-403 Bytes
(99%)
...ests/snapshots/mac/VerifyImageAspect_AspectFillWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-136 Bytes
(99%)
...c.Tests/snapshots/mac/VerifyImageAspect_AspectFillWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
-165 Bytes
(100%)
....Mac.Tests/snapshots/mac/VerifyImageAspect_AspectFillWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
-364 Bytes
(99%)
....Mac.Tests/snapshots/mac/VerifyImageAspect_AspectFitWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-83 Bytes
(100%)
...Tests/snapshots/mac/VerifyImageAspect_AspectFitWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
+40 Bytes
(100%)
...ac.Tests/snapshots/mac/VerifyImageAspect_AspectFitWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
-317 Bytes
(100%)
...s.Mac.Tests/snapshots/mac/VerifyImageAspect_AspectFitWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
-72 Bytes
(100%)
...ses.Mac.Tests/snapshots/mac/VerifyImageAspect_CenterWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
+54 Bytes
(100%)
...ac.Tests/snapshots/mac/VerifyImageAspect_CenterWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-317 Bytes
(98%)
...s.Mac.Tests/snapshots/mac/VerifyImageAspect_CenterWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
-291 Bytes
(100%)
...ases.Mac.Tests/snapshots/mac/VerifyImageAspect_CenterWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
-322 Bytes
(100%)
...Cases.Mac.Tests/snapshots/mac/VerifyImageAspect_FillWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-107 Bytes
(100%)
....Mac.Tests/snapshots/mac/VerifyImageAspect_FillWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-6 Bytes
(100%)
...ses.Mac.Tests/snapshots/mac/VerifyImageAspect_FillWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
-97 Bytes
(100%)
...tCases.Mac.Tests/snapshots/mac/VerifyImageAspect_FillWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
-364 Bytes
(99%)
...ontrols/tests/TestCases.Mac.Tests/snapshots/mac/VerifyImageFlowDirectionRTL.png
Oops, something went wrong.
Binary file modified
BIN
-214 Bytes
(100%)
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyImageWithShadow.png
Oops, something went wrong.
Binary file modified
BIN
-463 Bytes
(98%)
...ests/TestCases.Mac.Tests/snapshots/mac/VerticalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-683 Bytes
(98%)
...es.Mac.Tests/snapshots/mac/VerticalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-633 Bytes
(98%)
...ests/snapshots/mac/VerticalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-421 Bytes
(99%)
...ses.Mac.Tests/snapshots/mac/VerticalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-679 Bytes
(98%)
...s/TestCases.Mac.Tests/snapshots/mac/VerticalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-474 Bytes
(98%)
...ses.Mac.Tests/snapshots/mac/VerticalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-517 Bytes
(98%)
...ests/TestCases.Mac.Tests/snapshots/mac/VerticalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-441 Bytes
(98%)
...ts/TestCases.Mac.Tests/snapshots/mac/VerticalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31330.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue31330 : _IssuesUITest | ||
| { | ||
| public Issue31330(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
| public override string Issue => "Rectangle renders as thin line instead of filled shape for small height values"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shape)] | ||
| public void UpdateSizeOnlyWhenStrokeExists() | ||
| { | ||
| App.WaitForElement("TestBoxView"); | ||
| VerifyScreenshot(); | ||
|
Dhivya-SF4094 marked this conversation as resolved.
|
||
| } | ||
| } | ||
Binary file modified
BIN
+571 Bytes
(110%)
...I.Tests/snapshots/windows/BackgroundFrameResizesFastAndCorrectlySizeChanged.png
Oops, something went wrong.
Binary file modified
BIN
+693 Bytes
(110%)
...ests/TestCases.WinUI.Tests/snapshots/windows/BindingOnStrokeShapeWithRadius.png
Oops, something went wrong.
Binary file modified
BIN
+719 Bytes
(110%)
...s/TestCases.WinUI.Tests/snapshots/windows/BindingOnStrokeShapeWithoutRadius.png
Oops, something went wrong.
Binary file modified
BIN
+732 Bytes
(100%)
...tests/TestCases.WinUI.Tests/snapshots/windows/BorderRoundRectangleWithImage.png
Oops, something went wrong.
Binary file modified
BIN
+708 Bytes
(100%)
...apshots/windows/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png
Oops, something went wrong.
Binary file modified
BIN
-1.51 KB
(88%)
...ases.WinUI.Tests/snapshots/windows/Border_StrokeColorWithDashArrayAndOffset.png
Oops, something went wrong.
Binary file modified
BIN
-644 Bytes
(96%)
...UI.Tests/snapshots/windows/Border_StrokeColorWithStrokeShape_RoundRectangle.png
Oops, something went wrong.
Binary file modified
BIN
-1.43 KB
(88%)
...stCases.WinUI.Tests/snapshots/windows/Border_StrokeColorWithStrokeThickness.png
Oops, something went wrong.
Binary file modified
BIN
+409 Bytes
(110%)
...nUI.Tests/snapshots/windows/CollectionViewGroupFooterTemplateShouldNotCrash.png
Oops, something went wrong.
Binary file modified
BIN
-160 Bytes
(99%)
.../TestCases.WinUI.Tests/snapshots/windows/FirstCustomPageWithBackgroundColor.png
Oops, something went wrong.
Binary file modified
BIN
-88 Bytes
(100%)
...ts/TestCases.WinUI.Tests/snapshots/windows/FirstCustomPageWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-42 Bytes
(100%)
...TestCases.WinUI.Tests/snapshots/windows/FirstCustomPageWithIconImageChanged.png
Oops, something went wrong.
Binary file modified
BIN
+840 Bytes
(110%)
...tCases.WinUI.Tests/snapshots/windows/FooterWithEmptyCVShouldHaveCorrectSize.png
Oops, something went wrong.
Binary file modified
BIN
+528 Bytes
(100%)
...ests/TestCases.WinUI.Tests/snapshots/windows/HeaderAndFooterShouldBeVisible.png
Oops, something went wrong.
Binary file modified
BIN
-357 Bytes
(98%)
...tCases.WinUI.Tests/snapshots/windows/HorizontalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-358 Bytes
(98%)
....Tests/snapshots/windows/HorizontalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-357 Bytes
(98%)
...napshots/windows/HorizontalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-356 Bytes
(98%)
...I.Tests/snapshots/windows/HorizontalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-386 Bytes
(98%)
...ses.WinUI.Tests/snapshots/windows/HorizontalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-386 Bytes
(98%)
...I.Tests/snapshots/windows/HorizontalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-381 Bytes
(98%)
...tCases.WinUI.Tests/snapshots/windows/HorizontalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-385 Bytes
(98%)
...ases.WinUI.Tests/snapshots/windows/HorizontalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
+765 Bytes
(110%)
...ols/tests/TestCases.WinUI.Tests/snapshots/windows/Issue22606_SetHeightTo200.png
Oops, something went wrong.
Binary file modified
BIN
+871 Bytes
(110%)
...ols/tests/TestCases.WinUI.Tests/snapshots/windows/Issue22606_SetHeightTo500.png
Oops, something went wrong.
Binary file modified
BIN
+517 Bytes
(100%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test.png
Oops, something went wrong.
Binary file modified
BIN
+140 Bytes
(100%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_1.png
Oops, something went wrong.
Binary file modified
BIN
+76 Bytes
(100%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_2.png
Oops, something went wrong.
Binary file modified
BIN
+1.02 KB
(100%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_3.png
Oops, something went wrong.
Binary file modified
BIN
+826 Bytes
(100%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_4.png
Oops, something went wrong.
Binary file modified
BIN
+1.31 KB
(110%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_5.png
Oops, something went wrong.
Binary file modified
BIN
+584 Bytes
(110%)
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/ShadowShouldUpdate.png
Oops, something went wrong.
Binary file modified
BIN
+630 Bytes
(110%)
...s/tests/TestCases.WinUI.Tests/snapshots/windows/ShapeBackgroundColorChanges.png
Oops, something went wrong.
Binary file modified
BIN
-191 Bytes
(98%)
...sts/TestCases.WinUI.Tests/snapshots/windows/VerifyBorderWithStrokeDashArray.png
Oops, something went wrong.
Binary file modified
BIN
-459 Bytes
(99%)
...s/TestCases.WinUI.Tests/snapshots/windows/VerifyFontImageWithFontColorGreen.png
Oops, something went wrong.
Binary file modified
BIN
+439 Bytes
(100%)
....Tests/snapshots/windows/VerifyImageAspect_AspectFitWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-122 Bytes
(100%)
...s/snapshots/windows/VerifyImageAspect_AspectFitWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
+616 Bytes
(110%)
...ests/snapshots/windows/VerifyImageAspect_AspectFitWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+191 Bytes
(100%)
...I.Tests/snapshots/windows/VerifyImageAspect_AspectFitWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+453 Bytes
(100%)
...nUI.Tests/snapshots/windows/VerifyImageAspect_CenterWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
-118 Bytes
(99%)
...ests/snapshots/windows/VerifyImageAspect_CenterWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
-18.7 KB
(92%)
...inUI.Tests/snapshots/windows/VerifyImageAspect_CenterWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+451 Bytes
(100%)
...WinUI.Tests/snapshots/windows/VerifyImageAspect_FillWithImageSourceFromFile.png
Oops, something went wrong.
Binary file modified
BIN
+4.97 KB
(110%)
....Tests/snapshots/windows/VerifyImageAspect_FillWithImageSourceFromFontImage.png
Oops, something went wrong.
Binary file modified
BIN
+585 Bytes
(110%)
...nUI.Tests/snapshots/windows/VerifyImageAspect_FillWithImageSourceFromStream.png
Oops, something went wrong.
Binary file modified
BIN
+2.16 KB
(100%)
....WinUI.Tests/snapshots/windows/VerifyImageAspect_FillWithImageSourceFromUri.png
Oops, something went wrong.
Binary file modified
BIN
+457 Bytes
(100%)
...s/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyImageFlowDirectionRTL.png
Oops, something went wrong.
Binary file modified
BIN
-69 Bytes
(100%)
...Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-59 Bytes
(100%)
.../TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorColorWhenItemsAdded.png
Oops, something went wrong.
Binary file modified
BIN
-69 Bytes
(100%)
...stCases.WinUI.Tests/snapshots/windows/VerifyIndicatorColorWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-68 Bytes
(100%)
...tCases.WinUI.Tests/snapshots/windows/VerifyIndicatorColorWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-514 Bytes
(97%)
...stCases.WinUI.Tests/snapshots/windows/VerifyIndicatorColorWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
...ts/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorHideSingleIsFalse.png
Oops, something went wrong.
Binary file modified
BIN
-63 Bytes
(100%)
...napshots/windows/VerifyIndicatorHideSingleIsFalseWithSelectedIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
...es.WinUI.Tests/snapshots/windows/VerifyIndicatorHideSingleWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-71 Bytes
(100%)
...Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-70 Bytes
(100%)
...stCases.WinUI.Tests/snapshots/windows/VerifyIndicatorShapeWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
.../TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorShapeWithHideSingle.png
Oops, something went wrong.
Binary file modified
BIN
-69 Bytes
(100%)
...tCases.WinUI.Tests/snapshots/windows/VerifyIndicatorShapeWithMaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-511 Bytes
(97%)
...estCases.WinUI.Tests/snapshots/windows/VerifyIndicatorSizeWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-511 Bytes
(97%)
...stCases.WinUI.Tests/snapshots/windows/VerifyIndicatorSizeWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-511 Bytes
(97%)
...stCases.WinUI.Tests/snapshots/windows/VerifyIndicatorSizeWithMaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-66 Bytes
(100%)
...s/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorView_FlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
...ests/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorView_HideSingle.png
Oops, something went wrong.
Binary file modified
BIN
-62 Bytes
(100%)
...tests/TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorView_IsVisible.png
Oops, something went wrong.
Binary file modified
BIN
-68 Bytes
(100%)
.../TestCases.WinUI.Tests/snapshots/windows/VerifyIndicatorView_MaximumVisible.png
Oops, something went wrong.
Binary file modified
BIN
-68 Bytes
(100%)
.../tests/TestCases.WinUI.Tests/snapshots/windows/VerifySelectedIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-64 Bytes
(100%)
...WinUI.Tests/snapshots/windows/VerifySelectedIndicatorColorWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-69 Bytes
(100%)
...inUI.Tests/snapshots/windows/VerifySelectedIndicatorColorWithIndicatorColor.png
Oops, something went wrong.
Binary file modified
BIN
-69 Bytes
(100%)
...inUI.Tests/snapshots/windows/VerifySelectedIndicatorColorWithIndicatorShape.png
Oops, something went wrong.
Binary file modified
BIN
-513 Bytes
(97%)
...WinUI.Tests/snapshots/windows/VerifySelectedIndicatorColorWithIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
-467 Bytes
(97%)
...s/tests/TestCases.WinUI.Tests/snapshots/windows/VerifySelectedIndicatorSize.png
Oops, something went wrong.
Binary file modified
BIN
+38 Bytes
(100%)
...estCases.WinUI.Tests/snapshots/windows/VerticalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
+35 Bytes
(100%)
...UI.Tests/snapshots/windows/VerticalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
.../snapshots/windows/VerticalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
+33 Bytes
(100%)
...nUI.Tests/snapshots/windows/VerticalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
+2 Bytes
(100%)
...Cases.WinUI.Tests/snapshots/windows/VerticalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-7 Bytes
(100%)
...nUI.Tests/snapshots/windows/VerticalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
+25 Bytes
(100%)
...estCases.WinUI.Tests/snapshots/windows/VerticalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-10 Bytes
(100%)
...tCases.WinUI.Tests/snapshots/windows/VerticalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-50 Bytes
(100%)
...tests/TestCases.iOS.Tests/snapshots/ios/AccessibilityTraitsSetCorrectlyNone.png
Oops, something went wrong.
Binary file modified
BIN
-50 Bytes
(100%)
...sts/TestCases.iOS.Tests/snapshots/ios/AccessibilityTraitsSetCorrectlySingle.png
Oops, something went wrong.
Binary file modified
BIN
-3.33 KB
(97%)
...ts/TestCases.iOS.Tests/snapshots/ios/BackgroundFrameResizesFastAndCorrectly.png
Oops, something went wrong.
Binary file modified
BIN
-9.94 KB
(98%)
...s.iOS.Tests/snapshots/ios/BackgroundFrameResizesFastAndCorrectlySizeChanged.png
Oops, something went wrong.
Binary file modified
BIN
-67 Bytes
(100%)
...rols/tests/TestCases.iOS.Tests/snapshots/ios/BindingOnStrokeShapeWithRadius.png
Oops, something went wrong.
Binary file modified
BIN
-212 Bytes
(99%)
...s/tests/TestCases.iOS.Tests/snapshots/ios/BindingOnStrokeShapeWithoutRadius.png
Oops, something went wrong.
Binary file modified
BIN
-11.8 KB
(50%)
...Cases.iOS.Tests/snapshots/ios/BorderBackgroundSizeUpdatesWhenRotatingScreen.png
Oops, something went wrong.
Binary file modified
BIN
+967 Bytes
(100%)
...trols/tests/TestCases.iOS.Tests/snapshots/ios/BorderRoundRectangleWithImage.png
Oops, something went wrong.
Binary file modified
BIN
-86 Bytes
(100%)
...s/snapshots/ios/BorderWithRoundRectangleShouldRoundCornersOfContentWithinIt.png
Oops, something went wrong.
Binary file modified
BIN
-2.25 KB
(94%)
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Border_Shadow.png
Oops, something went wrong.
Binary file modified
BIN
-1.78 KB
(96%)
...es.iOS.Tests/snapshots/ios/Border_StrokeColorWithStrokeShape_RoundRectangle.png
Oops, something went wrong.
Binary file modified
BIN
-1.88 KB
(95%)
...sts/TestCases.iOS.Tests/snapshots/ios/Border_StrokeColorWithStrokeThickness.png
Oops, something went wrong.
Binary file modified
BIN
-284 Bytes
(98%)
...ses.iOS.Tests/snapshots/ios/CollectionViewGroupFooterTemplateShouldNotCrash.png
Oops, something went wrong.
Binary file modified
BIN
-10.7 KB
(71%)
...s/tests/TestCases.iOS.Tests/snapshots/ios/EntrySelectionLengthRuntimeUpdate.png
Oops, something went wrong.
Binary file modified
BIN
-254 Bytes
(100%)
.../tests/TestCases.iOS.Tests/snapshots/ios/FirstCustomPageWithBackgroundColor.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
...ls/tests/TestCases.iOS.Tests/snapshots/ios/FirstCustomPageWithFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-644 Bytes
(100%)
...tests/TestCases.iOS.Tests/snapshots/ios/FirstCustomPageWithIconImageChanged.png
Oops, something went wrong.
Binary file modified
BIN
-179 Bytes
(98%)
...ts/TestCases.iOS.Tests/snapshots/ios/FooterWithEmptyCVShouldHaveCorrectSize.png
Oops, something went wrong.
Binary file modified
BIN
-382 Bytes
(99%)
...rols/tests/TestCases.iOS.Tests/snapshots/ios/HeaderAndFooterShouldBeVisible.png
Oops, something went wrong.
Binary file modified
BIN
-354 Bytes
(99%)
...ts/TestCases.iOS.Tests/snapshots/ios/HorizontalStackLayout_RTLFlowDirection.png
Oops, something went wrong.
Binary file modified
BIN
-354 Bytes
(99%)
....iOS.Tests/snapshots/ios/HorizontalStackLayout_RTLFlowDirection_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-232 Bytes
(100%)
...ts/snapshots/ios/HorizontalStackLayout_RTLFlowDirection_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-232 Bytes
(100%)
...s.iOS.Tests/snapshots/ios/HorizontalStackLayout_RTLFlowDirection_With_Width.png
Oops, something went wrong.
Binary file modified
BIN
-257 Bytes
(100%)
...TestCases.iOS.Tests/snapshots/ios/HorizontalStackLayout_Spacing_With_Height.png
Oops, something went wrong.
Binary file modified
BIN
-183 Bytes
(100%)
...s.iOS.Tests/snapshots/ios/HorizontalStackLayout_Spacing_With_HeightAndWidth.png
Oops, something went wrong.
Binary file modified
BIN
-340 Bytes
(99%)
...ts/TestCases.iOS.Tests/snapshots/ios/HorizontalStackLayout_Spacing_With_RTL.png
Oops, something went wrong.
Binary file modified
BIN
-183 Bytes
(100%)
.../TestCases.iOS.Tests/snapshots/ios/HorizontalStackLayout_Spacing_With_Width.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Logic and Correctness - This only skips the second stroke inset in
TransformPathForBounds, butRectangle.GetPath()andEllipse.GetPath()are called before this and still subtract the raw defaultStrokeThicknesseven whenStrokeis null. For the issue scenario (RectanglewithHeightRequest = 1.2, fill only),GetPath()still builds a path withy = 0.5andh = 0.2, so the shape can still render as the thin line from #31330. The effective stroke thickness needs to be used when constructing those shape paths too.