Conversation
simonrozsival
previously approved these changes
Sep 3, 2025
mattleibow
previously approved these changes
Sep 3, 2025
rolfbjarne
previously approved these changes
Sep 3, 2025
jfversluis
requested changes
Sep 3, 2025
Member
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
Build error...?
.dotnet/sdk/10.0.100-rc.1.25416.112/Microsoft.Common.CurrentVersion.targets(3442,5): Error MSB3552: Resource file "../../../Controls/src/SourceGen/xlf/MauiGResources.resx" cannot be found.
StephaneDelcroix
dismissed stale reviews from rolfbjarne, mattleibow, and simonrozsival
via
358ae19
StephaneDelcroix
requested review from
Copilot,
jfversluis and
simonrozsival
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a resources localization issue by correcting file paths in the localization configuration. The changes ensure that localized resource files are properly generated and referenced in the correct directory structure.
Key changes:
- Updates the source file path for MauiGResources.resx in the unit test project to remove incorrect "xlf" subdirectory
- Corrects the output path in the localization configuration to include the "xlf" subdirectory for proper localized file generation
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/tests/UnitTests/Core.UnitTests.csproj | Fixes the source path reference for MauiGResources.resx by removing the incorrect "xlf" directory from the Include path |
| eng/automation/LocProject.json | Corrects the OutputPath to include "xlf\" subdirectory for proper localized resource file generation |
jfversluis
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
fix resources localization