[Testing] Feature Matrix UITest Cases for App Themes by TamilarasanSF4853 · Pull Request #31458 · dotnet/maui

TamilarasanSF4853 · 2025-09-02T18:48:36Z

This PR adds a comprehensive App Theme feature matrix with host pages plus an extensive suite of UI tests validating light/dark theme behavior and AppThemeBinding styling across common controls.

App Themes Implementation:

Adds themed and default pages demonstrating Light/Dark switching via UserAppTheme and broad AppThemeBinding coverage (foreground, background, border, placeholder, track, thumb, progress, title colors) across common controls (Button, Border, CheckBox, DatePicker, Entry, Editor, RadioButton, SearchBar, Image, BoxView, ImageButton, Rectangle, Picker, ProgressBar, Slider, Label, Stepper, Switch, TitleBar).
UI tests toggle themes, interact where needed, clear text to expose placeholders, and capture screenshots (with iOS crop) while guarding known failing scenarios behind conditional compilation for stability.

After this fix PR #31891 is merged, the Android snapshots will need to be re-saved.

Screen.Recording.2025-08-29.at.3.30.56.PM.mov

dotnet-policy-service · 2025-09-02T18:51:41Z

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-09-03T05:52:34Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-03T05:52:46Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-09-04T06:37:38Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-04T06:37:50Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-09-05T11:40:07Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-05T11:40:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR adds comprehensive UI test coverage for .NET MAUI's App Theme functionality by implementing feature matrix tests that validate light/dark theme behavior across common controls using AppThemeBinding.

Key Changes:

Adds extensive UI test suite with 28 test methods covering theme switching and AppThemeBinding functionality
Creates host app pages demonstrating themed and default control styling across light/dark themes
Implements platform-specific test handling with conditional compilation for known failing scenarios

Reviewed Changes

Copilot reviewed 6 out of 92 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
AppThemeFeatureTests.cs	Comprehensive UI test class with 28 test methods validating light/dark theme behavior and AppThemeBinding across various controls
DefaultThemePage.xaml	Host app page demonstrating standard control styling without AppThemeBinding for baseline comparison
DefaultThemePage.xaml.cs	Code-behind for default theme page with navigation and theme switching functionality
AppThemePage.xaml	Host app page showcasing AppThemeBinding styling across all major controls with extensive theme-aware properties
AppThemePage.xaml.cs	Code-behind for themed page with light/dark theme switching methods
CorePageView.cs	Updates gallery navigation to include new "App Theme" feature matrix entry

Copilot · 2025-09-08T11:13:28Z

src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs

+		App.NavigateToGallery(AppThemeFeatureMatrix);
+	}
+
+	public void VerifyScreenshotWithPlatformCropping()


This method should be marked as private since it's a helper method used internally by test methods and should not be accessible from outside the class.

Copilot · 2025-09-08T11:13:28Z

src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs

+		VerifyScreenshotWithPlatformCropping();
+#endif


The VerifyScreenshotWithPlatformCropping() call is inside an iOS-specific conditional compilation block but should be outside it to ensure screenshots are captured on all platforms. Move this call after the #endif directive.

jsuarezruiz

Some tests failing on Desktop:

Bacause:
OpenQA.Selenium.Appium.AppiumCommandExecutionHelper.IsKeyboardShown is not implemented

TamilarasanSF4853 · 2025-09-11T11:27:27Z

Some tests failing on Desktop:

Bacause: OpenQA.Selenium.Appium.AppiumCommandExecutionHelper.IsKeyboardShown is not implemented

@jsuarezruiz I have updated the test case in the latest commit. Could you please rerun the CI?

jsuarezruiz · 2025-09-12T06:06:08Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-12T06:06:21Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Tests failing:

Because there are pending snapshots, mostly on Windows. All are available in the latest build. Could you commit the images?

TamilarasanSF4853 · 2025-09-17T15:10:02Z

Tests failing: Because there are pending snapshots, mostly on Windows. All are available in the latest build. Could you commit the images?

@jsuarezruiz I have added the pending snapshots in the latest commit.

jsuarezruiz · 2025-09-18T09:04:06Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-09-18T09:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-09-24T15:59:55Z

Could you rebase to fix the conflict? Thanks in advance.

jsuarezruiz · 2025-10-01T07:25:36Z

@TamilarasanSF4853 Could you rebase and fix the conflicts?

TamilarasanSF4853 · 2025-10-02T15:56:03Z

@TamilarasanSF4853 Could you rebase and fix the conflicts?

@jsuarezruiz I have rebased and resolved the conflicts.

jsuarezruiz · 2025-10-21T08:01:04Z

/rebase

jsuarezruiz · 2025-10-21T08:08:06Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-10-21T08:08:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Failing tests on Android:

TamilarasanSF4853 · 2025-10-22T07:19:06Z

Failing tests on Android:

@jsuarezruiz I have added the pending snapshots in the latest commit.

jsuarezruiz · 2025-10-27T10:46:36Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-10-27T10:46:47Z

Azure Pipelines successfully started running 1 pipeline(s).

* added Android and iOS snapshots * added UITestCategorie * added Mac and Windows snapshots * modified test case * added Mac and Windows snapshots * added default style * removed some styles * modified the styles * added android and iOS snapshots * added snapshots

dotnet-policy-service bot added the community ✨ Community Contribution label Sep 2, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Sep 2, 2025

ghost added the area-testing Unit tests, device tests label Sep 3, 2025

TamilarasanSF4853 marked this pull request as ready for review September 8, 2025 11:13

Copilot AI review requested due to automatic review settings September 8, 2025 11:13

TamilarasanSF4853 requested a review from a team as a code owner September 8, 2025 11:13

Copilot AI reviewed Sep 8, 2025

View reviewed changes

jsuarezruiz suggested changes Sep 9, 2025

View reviewed changes

TamilarasanSF4853 force-pushed the feature-matrix-appthemes branch from 28ed2a7 to dce2592 Compare September 11, 2025 11:24

jsuarezruiz suggested changes Sep 12, 2025

View reviewed changes

TamilarasanSF4853 force-pushed the feature-matrix-appthemes branch from 115641b to 056102b Compare October 2, 2025 14:58

TamilarasanSF4853 mentioned this pull request Oct 7, 2025

[Android][Regression] Fixed Entry and Editor AppThemeBinding colors for text and placeholder reset to default on theme change #31891

Merged

4 tasks

added Android and iOS snapshots

6abd3a5

TamilarasanSF4853 added 7 commits October 21, 2025 08:01

added Mac and Windows snapshots

3dacb33

modified test case

c7218a8

added Mac and Windows snapshots

73fd16c

added default style

81879e0

removed some styles

ea617f1

modified the styles

bb6c8df

added android and iOS snapshots

de398a1

github-actions bot force-pushed the feature-matrix-appthemes branch from fde3806 to de398a1 Compare October 21, 2025 08:01

jsuarezruiz suggested changes Oct 21, 2025

View reviewed changes

added snapshots

991deed

jsuarezruiz approved these changes Oct 27, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current October 31, 2025 20:29

PureWeen merged commit 4f619d4 into dotnet:inflight/current Oct 31, 2025
76 of 78 checks passed

github-actions bot locked and limited conversation to collaborators Dec 1, 2025

TamilarasanSF4853 deleted the feature-matrix-appthemes branch January 9, 2026 10:25

Conversation

TamilarasanSF4853 commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

App Themes Implementation:

Uh oh!

dotnet-policy-service bot commented Sep 2, 2025

Uh oh!

jsuarezruiz commented Sep 3, 2025

Uh oh!

azure-pipelines bot commented Sep 3, 2025

Uh oh!

jsuarezruiz commented Sep 4, 2025

Uh oh!

azure-pipelines bot commented Sep 4, 2025

Uh oh!

jsuarezruiz commented Sep 5, 2025

Uh oh!

azure-pipelines bot commented Sep 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

TamilarasanSF4853 commented Sep 11, 2025

Uh oh!

jsuarezruiz commented Sep 12, 2025

Uh oh!

azure-pipelines bot commented Sep 12, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

TamilarasanSF4853 commented Sep 17, 2025

Uh oh!

jsuarezruiz commented Sep 18, 2025

Uh oh!

azure-pipelines bot commented Sep 18, 2025

Uh oh!

jsuarezruiz commented Sep 24, 2025

Uh oh!

jsuarezruiz commented Oct 1, 2025

Uh oh!

TamilarasanSF4853 commented Oct 2, 2025

Uh oh!

jsuarezruiz commented Oct 21, 2025

Uh oh!

jsuarezruiz commented Oct 21, 2025

Uh oh!

azure-pipelines bot commented Oct 21, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

TamilarasanSF4853 commented Oct 22, 2025

Uh oh!

jsuarezruiz commented Oct 27, 2025

Uh oh!

azure-pipelines bot commented Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TamilarasanSF4853 commented Sep 2, 2025 •

edited

Loading