[Android] Fix for IndicatorView remains interactive even when IsEnabled="False" #31457
Conversation
|
Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
sheiksyedm
added
the
area-controls-collectionview
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where IndicatorView on Android remains interactive even when IsEnabled is set to False. The problem was that click listeners for indicator dots were created during initialization and continued to respond to clicks regardless of the parent IndicatorView's enabled state.
- Updates the Android implementation to check
IsEnabledbefore processing indicator taps - Adds UI test infrastructure to validate the fix behavior
- Provides test cases for both HostApp demonstration and automated testing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Core/src/Platform/Android/MauiPageControl.cs | Adds IsEnabled check in click listener to prevent interaction when disabled |
| src/Controls/tests/TestCases.HostApp/Issues/Issue31063.cs | Creates HostApp UI test page demonstrating disabled IndicatorView behavior |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31063.cs | Implements NUnit test to validate IsEnabled property is respected |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -0,0 +1,25 @@ | |||
| #if TEST_FAILS_ON_WINDOWS // IndicatorView UI automation not working on Windows | |||
There was a problem hiding this comment.
Could you create a new issue related with this?
There was a problem hiding this comment.
@jsuarezruiz, I’ve created an issue for this #31666
…ed="False" (#31457) * Fix for IndicatorView IsEnabled * Removed Private Keyword * Test restricted on windows * Remove unwanted file * Modified the fix * Modify fix
4 participants
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #31063
Tested the behaviour in the following platforms
Output
Before.mov
After.mov