Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows platform support for microphone permission handling in .NET MAUI Essentials, addressing an issue where permission status was incorrectly returned as Granted even after denial. The implementation provides proper checking and requesting of microphone access permissions on Windows.
Key changes:
- Implements Windows-specific microphone permission checking and requesting logic
- Adds comprehensive device tests for microphone permissions with human interaction scenarios
- Updates platform manifest files to declare required microphone permissions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Essentials/src/Permissions/Permissions.windows.cs |
Implements microphone permission logic for Windows using MediaCapture and DeviceAccessInformation APIs |
src/Essentials/test/DeviceTests/Tests/Microphone_Tests.cs |
Adds comprehensive device tests for microphone permission denied/granted scenarios |
src/Essentials/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt |
Documents new public API methods for Windows microphone permissions |
| Platform manifest files (iOS, MacCatalyst, Android, Windows) | Adds microphone permission declarations across all supported platforms |
jsuarezruiz
added
area-essentials
jsuarezruiz
suggested changes
Sep 3, 2025
jsuarezruiz
reviewed
Sep 4, 2025
jsuarezruiz
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This pull request adds support for microphone permission handling on Windows, including the ability to check and request microphone access. It also introduces corresponding tests and updates platform-specific manifest files to declare microphone permissions, ensuring proper functionality and compliance across Windows, Android, iOS, and MacCatalyst.
Issues Fixed
In a popup summoned by Permissions.RequestAsync<Permissions.Microphone>() I denied the permission. Now every call to Permissions.RequestAsync<Permissions.Microphone> or Permissions.CheckStatusAsync<Permissions.Microphone> returns Granted.
Tests
Fixes #31413