Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes duplicate localized resource files that were previously moved but still remained in the SourceGen directory. The cleanup eliminates 16 redundant .resx files containing localized error messages and type conversion messages for MAUI's source generation functionality.
Key Changes:
- Complete removal of duplicate localized resource files from
src/Controls/src/SourceGen/ - Elimination of redundant translations across 16 different locales
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/SourceGen/MauiGResources.zh-Hant.resx | Removes Traditional Chinese localized resource file |
| src/Controls/src/SourceGen/MauiGResources.zh-Hans.resx | Removes Simplified Chinese localized resource file |
| src/Controls/src/SourceGen/MauiGResources.tr.resx | Removes Turkish localized resource file |
| src/Controls/src/SourceGen/MauiGResources.ru.resx | Removes Russian localized resource file |
| src/Controls/src/SourceGen/MauiGResources.resx | Removes default English localized resource file |
| src/Controls/src/SourceGen/MauiGResources.pt-BR.resx | Removes Brazilian Portuguese localized resource file |
| src/Controls/src/SourceGen/MauiGResources.pl.resx | Removes Polish localized resource file |
| src/Controls/src/SourceGen/MauiGResources.ko.resx | Removes Korean localized resource file |
| src/Controls/src/SourceGen/MauiGResources.ja.resx | Removes Japanese localized resource file |
| src/Controls/src/SourceGen/MauiGResources.it.resx | Removes Italian localized resource file |
| src/Controls/src/SourceGen/MauiGResources.fr.resx | Removes French localized resource file |
| src/Controls/src/SourceGen/MauiGResources.es.resx | Removes Spanish localized resource file |
| src/Controls/src/SourceGen/MauiGResources.de.resx | Removes German localized resource file |
| src/Controls/src/SourceGen/MauiGResources.cs.resx | Removes Czech localized resource file |
PureWeen
approved these changes
Aug 31, 2025
jsuarezruiz
approved these changes
Sep 1, 2025
jfversluis
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
we moved those files, but they're still there