Skip to content

[net10.0] Update the Windows App SDK to 1.8#31281

Closed
MartyIX wants to merge 5 commits intodotnet:net10.0from
MartyIX:feature/2025-08-21-WinAppSDK-1-8
Closed

[net10.0] Update the Windows App SDK to 1.8#31281
MartyIX wants to merge 5 commits intodotnet:net10.0from
MartyIX:feature/2025-08-21-WinAppSDK-1-8

Conversation

@MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Aug 21, 2025

@MartyIX MartyIX requested a review from a team as a code owner August 21, 2025 20:40
@MartyIX MartyIX requested review from mattleibow and rmarinho August 21, 2025 20:40
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 21, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@MartyIX
Copy link
Contributor Author

MartyIX commented Aug 21, 2025

cc @mattleibow

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the feature/2025-08-21-WinAppSDK-1-8 branch from 32593b1 to 9623ae4 Compare September 4, 2025 11:15
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MartyIX MartyIX changed the title [net10.0] Update the Windows App SDK to 1.8 (preview) [net10.0] Update the Windows App SDK to 1.8 Sep 9, 2025
@MartyIX
Copy link
Contributor Author

MartyIX commented Sep 9, 2025

1.8 was released as the stable version. Updated.

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR12 milestone Sep 11, 2025
@PureWeen PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Sep 11, 2025
@PureWeen
Copy link
Member

C:\Users\VssAdministrator\.nuget\packages\microsoft.windows.sdk.buildtools.msix\1.7.20250829.1\build\Microsoft.Windows.SDK.BuildTools.MSIX.Packaging.targets(3744,5): warning APPX0107: The certificate specified is not valid for signing. For more information about valid certificates, see http://go.microsoft.com/fwlink/?LinkID=241478. [D:\a\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-windows10.0.19041.0]
  Controls.DeviceTests -> D:\a\1\s\artifacts\bin\Controls.DeviceTests\Debug\net10.0-windows10.0.19041.0\win-x64\publish\
C:\Users\VssAdministrator\.nuget\packages\microsoft.windows.sdk.buildtools.msix\1.7.20250829.1\build\Microsoft.Windows.SDK.BuildTools.MSIX.Packaging.targets(3015,5): warning : Path to `mspdbcmf.exe` could not be found. A symbols package will not be generated. Review https://aka.ms/windowsappsdkdocs and ensure that all prerequisites for Windows App SDK development have been installed. [D:\a\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-windows10.0.19041.0]
  Controls.DeviceTests -> D:\a\1\s\src\Controls\tests\DeviceTests\AppPackages\Controls.DeviceTests_0.0.0.1_Debug_Test\Controls.DeviceTests_0.0.0.1_x64_Debug.msix
C:\Users\VssAdministrator\.nuget\packages\microsoft.windows.sdk.buildtools.msix\1.7.20250829.1\build\Microsoft.Windows.SDK.BuildTools.MSIX.Packaging.targets(3218,5): error APPX0107: The certificate specified is not valid for signing. For more information about valid certificates, see http://go.microsoft.com/fwlink/?LinkID=241478. [D:\a\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-windows10.0.19041.0]

@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Sep 12, 2025
@PureWeen PureWeen moved this from In Progress to Changes Requested in MAUI SDK Ongoing Sep 12, 2025
@MartyIX
Copy link
Contributor Author

MartyIX commented Sep 13, 2025

@PureWeen This PR targets the net10.0 branch at the moment. Is that correct? Or should it target main because it's slated for NET 9 SR12?

@MartyIX
Copy link
Contributor Author

MartyIX commented Sep 15, 2025

@PureWeen I created .NET 9 PR here: #31615

@PureWeen PureWeen modified the milestones: .NET 9 SR12, .NET 10.0-rc2 Sep 15, 2025
@PureWeen
Copy link
Member

@PureWeen This PR targets the net10.0 branch at the moment. Is that correct? Or should it target main because it's slated for NET 9 SR12?

yea sorry i assigned the wrong milestone.

this should just be net10

@mattleibow mattleibow reopened this Oct 1, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in MAUI SDK Ongoing Oct 1, 2025
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s), but failed to run 1 pipeline(s).

@mattleibow
Copy link
Member

@mattleibow How come I don't see the template tests error locally? I mean it passes on my machine but it failed on the CI. Now you added a few commits that appear to fix the issue. However, does the tests fail locally for you or not?

Confessions: I am not even running this, CI is my machine :)

But I am looking at the errors. The failing test is the PublishPackaged test in windows. I think they changed the path for the output msix to NOT include the RID.

AppxPackageOutput = C:\a_work_temp\test-dir\PublishPackaged1672256656\AppPackages\PublishPackaged1672256656_1.0.0.1_Test\PublishPackaged1672256656_1.0.0.1_x64.msix

@PureWeen PureWeen modified the milestones: .NET 10.0-rc2, .NET 10.0 GA Oct 6, 2025
@MartyIX
Copy link
Contributor Author

MartyIX commented Oct 7, 2025

@mattleibow It looks like only a few tests fail now. :)

@PureWeen PureWeen moved this from In Progress to Ready To Review in MAUI SDK Ongoing Oct 10, 2025
@lothrop
Copy link
Contributor

lothrop commented Oct 16, 2025

@dotMorten You were saying in #30858 all the references should point to Microsoft.WindowsAppSDK.WinUI instead of Microsoft.WindowsAppSDK?

@MartyIX
Copy link
Contributor Author

MartyIX commented Oct 16, 2025

@dotMorten You were saying in #30858 all the references should point to Microsoft.WindowsAppSDK.WinUI instead of Microsoft.WindowsAppSDK?

#31281 (comment)

@dotMorten
Copy link
Contributor

@lothrop that is the recommended approach for 1.8+ class libraries. The meta data package in 1.8 is really just there for backwards compatibility until all the 3rd party libraries (including Maui) have done this work.

@mattleibow
Copy link
Member

@MartyIX can you rebase as maybe some issues were fixed in the tests.

@MartyIX MartyIX force-pushed the feature/2025-08-21-WinAppSDK-1-8 branch from cd72c39 to d8e1d04 Compare October 17, 2025 11:32
@MartyIX
Copy link
Contributor Author

MartyIX commented Oct 17, 2025

@MartyIX can you rebase as maybe some issues were fixed in the tests.

Done

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MartyIX
Copy link
Contributor Author

MartyIX commented Oct 20, 2025

@mattleibow Any idea what to try next?

@mattleibow
Copy link
Member

I am doing this in a branch that is not on a fork as I think some feeds are internal or something: #32174

@rmarinho
Copy link
Member

closing in favor of #32174

@rmarinho rmarinho closed this Oct 24, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Oct 24, 2025
@MartyIX MartyIX deleted the feature/2025-08-21-WinAppSDK-1-8 branch October 27, 2025 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. platform/windows

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants