Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes XML namespace (xmlns) resolution issues when compiling XAML with the source generator, specifically for visual state targets. The fix ensures that type resolution considers the correct namespace context when resolving types in visual state setters.
- Updates the BindablePropertyConverter to properly handle XmlType objects instead of string type names
- Modifies NodeSGExtensions to use XmlType for type resolution in source generation context
- Adds comprehensive test coverage for the xmlns resolution scenario
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Controls/tests/Xaml.UnitTests/Issues/Maui31186.xaml |
Test XAML file demonstrating visual state with custom button type using local xmlns |
src/Controls/tests/Xaml.UnitTests/Issues/Maui31186.xaml.cs |
Unit test validating xmlns resolution for visual state targets works in both runtime and source generation scenarios |
src/Controls/src/SourceGen/NodeSGExtensions.cs |
Updates GetBindablePropertyTarget method to use XmlType instead of string for proper namespace resolution |
src/Controls/src/Build.Tasks/XmlTypeExtensions.cs |
Minor whitespace formatting fix |
src/Controls/src/Build.Tasks/XamlCache.cs |
Method name correction from GetXmlsDefinitions to GetXmlnsDefinitions |
src/Controls/src/Build.Tasks/CompiledConverters/BindablePropertyConverter.cs |
Major refactoring to use XmlType objects throughout for proper namespace-aware type resolution |
src/Controls/src/Build.Tasks/CompiledConverters/BindablePropertyConverter.cs
Outdated
Show resolved
Hide resolved
PureWeen
added
the
p/0
StephaneDelcroix
force-pushed
the
dev/stdelc/fix31186
branch
from
ff5e514 to
e7a384c
Compare
simonrozsival
approved these changes
Aug 19, 2025
jfversluis
approved these changes
Aug 19, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Member
|
/backport to release/10.0.1xx-rc1 |
Contributor
|
Started backporting to release/10.0.1xx-rc1: https://github.com/dotnet/maui/actions/runs/17073533095 |
jfversluis
added a commit
that referenced
this pull request
Aug 20, 2025
Backport of #31229 to release/10.0.1xx-rc1 /cc @rmarinho @StephaneDelcroix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
resolve type in the right xmlns for visual state targets
Issues Fixed