Ensure measure is invalidated when AbsoluteLayout bounds are updated #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
approved these changes
Oct 25, 2021
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
Nov 1, 2021
Context: dotnet#3018 This depends on dotnet#3108 merged first, and we will need the other mobile workloads to implement: <Using Include="Android.App" Platform="Android" /> <Using Include="Android.Widget" Platform="Android" /> <Using Include="Android.OS.Bundle" Alias="Bundle" Platform="Android" />
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
Nov 4, 2021
Context: dotnet#3018 PR dotnet#3108 was a good start in enabling implicit C# global usings. However, there were a couple of issues to work through: 1. There is a `GlobalUsings.cs` file. Can we do this in MSBuild, so it's just there by default? I added: <ItemGroup Condition=" '$(UseMaui)' == 'true' and ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable') "> <!-- %(Sdk) is only here if something later needs to identify these --> <Using Include="Microsoft.Extensions.DependencyInjection" Sdk="Maui" /> <Using Include="Microsoft.Maui" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls.Hosting" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls.Xaml" Sdk="Maui" /> <Using Include="Microsoft.Maui.Graphics" Sdk="Maui" /> <Using Include="Microsoft.Maui.Essentials" Sdk="Maui" /> <Using Include="Microsoft.Maui.Hosting" Sdk="Maui" /> </ItemGroup> 2. The platform-specific usings were not cleared. So types like `Microsoft.Maui.Controls.Application` could conflict with `Android.App.Application`. To solve this, I added a `%(Platform)` metadata in the Android, iOS, macOS, MacCatalyst, and tvOS workloads: <Using Include="Android.App" Platform="Android" /> <Using Include="Android.Widget" Platform="Android" /> <Using Include="Android.OS.Bundle" Alias="Bundle" Platform="Android" /> Then in .NET MAUI's MSBuild targets we can do: <ItemGroup Condition=" '$(UseMaui)' == 'true' and '$(MauiEnablePlatformUsings)' != 'true' and ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable') "> <Using Remove="@(Using->HasMetadata('Platform'))" /> </ItemGroup> I created `$(MauiEnablePlatformUsings)`, just in case someone ever needs to turn this off. I updated the templates to specify `ImplicitUsings=enable`. I updated `Controls.Sample.Tests.csproj`, as it was a .NET 6 project. We probably can't update the other samples yet, because there are Xamarin projects that would not support C# 10 language features.
12 tasks
jonathanpeppers
added a commit
to jonathanpeppers/maui
that referenced
this pull request
Nov 11, 2021
Context: dotnet#3018 PR dotnet#3108 was a good start in enabling implicit C# global usings. However, there were a couple of issues to work through: 1. There is a `GlobalUsings.cs` file. Can we do this in MSBuild, so it's just there by default? I added: <ItemGroup Condition=" '$(UseMaui)' == 'true' and ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable') "> <!-- %(Sdk) is only here if something later needs to identify these --> <Using Include="Microsoft.Extensions.DependencyInjection" Sdk="Maui" /> <Using Include="Microsoft.Maui" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls.Hosting" Sdk="Maui" /> <Using Include="Microsoft.Maui.Controls.Xaml" Sdk="Maui" /> <Using Include="Microsoft.Maui.Graphics" Sdk="Maui" /> <Using Include="Microsoft.Maui.Essentials" Sdk="Maui" /> <Using Include="Microsoft.Maui.Hosting" Sdk="Maui" /> </ItemGroup> 2. The platform-specific usings were not cleared. So types like `Microsoft.Maui.Controls.Application` could conflict with `Android.App.Application`. To solve this, I added a `%(Platform)` metadata in the Android, iOS, macOS, MacCatalyst, and tvOS workloads: <Using Include="Android.App" Platform="Android" /> <Using Include="Android.Widget" Platform="Android" /> <Using Include="Android.OS.Bundle" Alias="Bundle" Platform="Android" /> Then in .NET MAUI's MSBuild targets we can do: <ItemGroup Condition=" '$(UseMaui)' == 'true' and '$(MauiEnablePlatformUsings)' != 'true' and ('$(ImplicitUsings)' == 'true' or '$(ImplicitUsings)' == 'enable') "> <Using Remove="@(Using->HasMetadata('Platform'))" /> </ItemGroup> I created `$(MauiEnablePlatformUsings)`, just in case someone ever needs to turn this off. I updated the templates to specify `ImplicitUsings=enable`. I updated `Controls.Sample.Tests.csproj`, as it was a .NET 6 project. We probably can't update the other samples yet, because there are Xamarin projects that would not support C# 10 language features.
samhouts
added
the
fixed-in-6.0.101-preview.10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3090