[Net10] [iOS] Enable sizing back/flyout icon with the FontImageSource size property#30962
Merged
PureWeen merged 5 commits intodotnet:net10.0from Aug 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where back arrows and toolbar icons have become unusually small on iOS. The fix adds proper size handling for font-based icons by checking if a FontImageSource has an explicit size set before applying automatic resizing.
- Adds conditional checks to prevent automatic resizing of FontImageSource icons when they have explicit size properties
- Preserves existing resizing behavior for other image types and FontImageSource without explicit sizing
- Fixes bracket placement and code structure in affected resizing logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs |
Adds FontImageSource size check before resizing toolbar icons and fixes bracket structure |
src/Controls/src/Core/Compatibility/Handlers/NavigationPage/iOS/NavigationRenderer.cs |
Adds FontImageSource size check before resizing flyout icons with proper bracket structure |
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
previously approved these changes
Aug 1, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
The PR #26016 resolved a sizing issue with excessively large floating icons. However, as a side effect, the Size property of FontImageSource is now ignored, which can be confusing for developers.
For example:
Even though Size is explicitly set to 40, it's currently not respected.
To reduce confusion and improve developer experience we should restore support for the Size property when it is explicitly specified.
Issues Fixed
Fixes #30946