Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes several internal custom view classes public to enable developers to customize platform-specific implementations more easily. The change addresses issue #30762 by exposing views that provide specialized behavior for .NET MAUI controls.
Key changes:
- Makes internal platform view classes public for better extensibility
- Updates public API surface files to reflect the visibility changes
- Affects Android and Windows platform-specific implementations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/src/Platform/Windows/MauiSlider.cs | Changes MauiSlider class from internal to public |
| src/Core/src/Platform/Android/MauiShapeableImageView.cs | Changes MauiShapeableImageView class from internal to public |
| src/Core/src/Platform/Android/MauiScrollView.cs | Changes MauiHorizontalScrollView class from internal to public |
| src/Controls/src/Core/Platform/Android/MauiViewPager.cs | Changes MauiViewPager class from internal to public |
| src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt | Updates public API surface to include newly public Android classes |
| src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt | Updates public API surface to include newly public MauiViewPager class |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
There are some controls, like MauiSliderView that adds some behavior into a native control in order to make it work nicely with the framework. Having it internal will make it difficult to customize this control if needed.
This pull request updates the visibility of selected custom views, making them public to support greater flexibility and extensibility for developers working with platform-specific implementations.
Issues Fixed
Fixes #30762