Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compatibility issue in the XAML source generator where a path separator normalization using UriBuilder was causing inconsistencies with other inflators. The change comments out the path separator fix to maintain compatibility across the system.
- Comments out
UriBuilderpath normalization to preserve existing behavior - Adds explanatory comment about maintaining compatibility with other inflators
StephaneDelcroix
force-pushed
the
dev/stdelc/fixuripath
branch
from
7be4415 to
ea5cd20
Compare
sourceinfo is an uri, but somehow expects the system path separators
StephaneDelcroix
force-pushed
the
dev/stdelc/fixuripath
branch
from
ea5cd20 to
5a1b3c8
Compare
PureWeen
approved these changes
Jul 27, 2025
Member
|
tests are now passing here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourceinfo is an uri, but somehow expects the system path separators