[net10.0, Testing] Fixed test failures on merge main net10.0 PR 30606 #30628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
ghost
added
the
HarishKumarSF4517
requested review from
jfversluis and
rmarinho
and removed request for
a team
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
HarishKumarSF4517
changed the title
rmarinho
approved these changes
Jul 16, 2025
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
This fixes windows failures. we need to look at the rest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed the UI test image failures when the main gets merged to net10.0(#30606) and I have Resaved the UI Test Images. The changes enhance test coverage and update conditional compilation directives for issue tracking.
Build Link: https://dev.azure.com/xamarin/public/_build/results?buildId=146189&view=ms.vss-test-web.build-test-results-tab&runId=4531860&resultId=100085&paneView=debug
Re-saved baseline images for Entry control tests, reflecting a behavior change observed in .NET 10.0.
Specifically, we noticed that when navigating back from another page:
We suspect this is an intentional behavior change in .NET 10.0, so the test images have been updated accordingly.
Enhancements to test cases:
src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/ImageButtonFeatureTests.cs: Added steps to interact with theSourceTypeFileelement in theVerifyImageButtonWithBorderWidthAndCornerRadiustest to ensure proper functionality of theImageButtoncontrol.Updates to conditional compilation:
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21886.cs: Updated the conditional compilation directive to include Android-specific test failures alongside Windows, with links to the respective GitHub issues for tracking.