-
Notifications
You must be signed in to change notification settings - Fork 2k
[Windows] Fixed TimePicker CharacterSpacing issue #30533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
63d534a
Skip simulator install in official pack pipeline (#34802)
PureWeen 739694e
[Windows] Fix for TimePicker CharacterSpacing issue
SubhikshaSf4851 07524f1
Update in method
SubhikshaSf4851 598e9ff
Updated Issue link
SubhikshaSf4851 77ea306
Optimized the code changes
SubhikshaSf4851 5473e7e
Optimized the code changes
SubhikshaSf4851 280cf86
SnapShots updated
SubhikshaSf4851 04732b5
Updated requested changes
SubhikshaSf4851 2dd9650
resolved conflicts
SubhikshaSf4851 ef8493c
Added iOS26 version snapshot
SubhikshaSf4851 ec75540
Updated suggestion
SubhikshaSf4851 3f77ad4
Updated Suggestion
SubhikshaSf4851 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+11.2 KB
...oid.Tests/snapshots/android/Issue30199TimePickerCharacterSpacingShouldApply.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, "30199", "TimePicker CharacterSpacing Property Not Working on Windows", PlatformAffected.UWP)] | ||
|
|
||
| public class Issue30199 : ContentPage | ||
| { | ||
| public Issue30199() | ||
| { | ||
| var label = new Label | ||
| { | ||
| AutomationId = "label", | ||
| Text = "Test passes if TimePicker has character Spacing", | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| VerticalOptions = LayoutOptions.Center, | ||
| }; | ||
|
|
||
| var timePicker = new TimePicker | ||
| { | ||
| AutomationId = "timePicker", | ||
| Time = new TimeSpan(12, 30, 0), | ||
| CharacterSpacing = 10, | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Format = "HH:mm" | ||
| }; | ||
|
|
||
| Content = new StackLayout | ||
| { | ||
| Children = { label, timePicker }, | ||
| Spacing = 20, | ||
| Margin = new Thickness(20) | ||
| }; | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30199.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #if TEST_FAILS_ON_CATALYST //Issue Link https://github.com/dotnet/maui/issues/30532 | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue30199 : _IssuesUITest | ||
| { | ||
| public Issue30199(TestDevice device) | ||
| : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "TimePicker CharacterSpacing Property Not Working on Windows"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.TimePicker)] | ||
| public void Issue30199TimePickerCharacterSpacingShouldApply() | ||
| { | ||
| App.WaitForElement("timePicker"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| #endif | ||
Binary file added
BIN
+8.04 KB
...nUI.Tests/snapshots/windows/Issue30199TimePickerCharacterSpacingShouldApply.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.1 KB
....iOS.Tests/snapshots/ios-26/Issue30199TimePickerCharacterSpacingShouldApply.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.1 KB
...ses.iOS.Tests/snapshots/ios/Issue30199TimePickerCharacterSpacingShouldApply.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.