[Testing] Disabling the Essentials Geocoding failing tests on Windows#30508
Conversation
|
Hey there @@anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables the Get_Placemarks_LatLong test on Windows to avoid CI failures, with a link to a tracking issue for re-enablement.
- Updated the conditional compilation to exclude Windows alongside Android.
- Added comments explaining the temporary change and pointing to issue #30507.
| #if !ANDROID && !WINDOWS | ||
| [Theory] |
There was a problem hiding this comment.
[nitpick] Consider using xUnit’s Skip parameter on the [Theory] attribute to skip the test on Windows rather than a compile-time directive. For example:
[Theory(Skip = "Temporarily disabled on Windows: https://github.com//issues/30507")]
| #if !ANDROID && !WINDOWS | |
| [Theory] | |
| [Theory(Skip = "Temporarily disabled on Windows: https://github.com/dotnet/maui/issues/30507")] |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/backport to release/10.0.1xx-preview6 |
|
Started backporting to release/10.0.1xx-preview6: https://github.com/dotnet/maui/actions/runs/16175195614 |
This pull request makes a minor adjustment to the
Geocoding_Testsinsrc/Essentials/test/DeviceTests/Tests/Geocoding_Tests.cs. It temporarily disables a test on Windows due to consistent CI failures, with a tracking issue provided for re-enablement.Build Link: https://dev.azure.com/xamarin/public/_build/results?buildId=145786&view=ms.vss-test-web.build-test-results-tab&runId=4490667&resultId=100050&paneView=history
Testing adjustments:
src/Essentials/test/DeviceTests/Tests/Geocoding_Tests.cs: Updated the conditional compilation directive to exclude Windows from running theGet_Placemarks_LatLongtest, along with a comment explaining the temporary change and linking to the tracking issue.