Skip to content

[Testing] Disabling the Essentials Geocoding failing tests on Windows#30508

Merged
rmarinho merged 1 commit intomainfrom
unknown repository
Jul 9, 2025
Merged

[Testing] Disabling the Essentials Geocoding failing tests on Windows#30508
rmarinho merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 9, 2025

This pull request makes a minor adjustment to the Geocoding_Tests in src/Essentials/test/DeviceTests/Tests/Geocoding_Tests.cs. It temporarily disables a test on Windows due to consistent CI failures, with a tracking issue provided for re-enablement.

Build Link: https://dev.azure.com/xamarin/public/_build/results?buildId=145786&view=ms.vss-test-web.build-test-results-tab&runId=4490667&resultId=100050&paneView=history

Testing adjustments:

@dotnet-policy-service
Copy link
Contributor

Hey there @@anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 9, 2025
@ghost ghost added the area-testing Unit tests, device tests label Jul 9, 2025
@ghost ghost marked this pull request as ready for review July 9, 2025 11:24
Copilot AI review requested due to automatic review settings July 9, 2025 11:24
@ghost ghost self-requested a review as a code owner July 9, 2025 11:24
@ghost ghost requested review from jfversluis and mattleibow July 9, 2025 11:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables the Get_Placemarks_LatLong test on Windows to avoid CI failures, with a link to a tracking issue for re-enablement.

  • Updated the conditional compilation to exclude Windows alongside Android.
  • Added comments explaining the temporary change and pointing to issue #30507.

Comment on lines +21 to 22
#if !ANDROID && !WINDOWS
[Theory]
Copy link

Copilot AI Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using xUnit’s Skip parameter on the [Theory] attribute to skip the test on Windows rather than a compile-time directive. For example:

[Theory(Skip = "Temporarily disabled on Windows: https://github.com//issues/30507")]

Suggested change
#if !ANDROID && !WINDOWS
[Theory]
[Theory(Skip = "Temporarily disabled on Windows: https://github.com/dotnet/maui/issues/30507")]

Copilot uses AI. Check for mistakes.
@ghost ghost requested a review from rmarinho July 9, 2025 11:35
@rmarinho
Copy link
Member

rmarinho commented Jul 9, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit db405d0 into dotnet:main Jul 9, 2025
90 of 129 checks passed
@rmarinho
Copy link
Member

rmarinho commented Jul 9, 2025

/backport to release/10.0.1xx-preview6

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Started backporting to release/10.0.1xx-preview6: https://github.com/dotnet/maui/actions/runs/16175195614

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant