-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS, Mac] Fix for CursorPosition not updating when typing into Entry control #30505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kubaflo
merged 3 commits into
dotnet:inflight/current
from
SyedAbdulAzeemSF4852:fix-20911
Feb 23, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
30105fa
[iOS, Mac] Fix for Entry not updating CursorPosition on TextChanged e…
SyedAbdulAzeemSF4852 4c709ac
Have clamped the cursor values to ensure that the cursor position alw…
SyedAbdulAzeemSF4852 1bc820b
Updated the fix by setting the cursor position before updating the te…
SyedAbdulAzeemSF4852 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| namespace Controls.TestCases.HostApp.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 20911, "Updating text in the Entry does not update CursorPosition during the TextChanged event", PlatformAffected.iOS)] | ||
| public class Issue20911 : ContentPage | ||
| { | ||
| Entry entry; | ||
| Label cursorPositonStatusLabel; | ||
|
|
||
| public Issue20911() | ||
| { | ||
| entry = new Entry | ||
| { | ||
| AutomationId = "ValidateEntryCursorPosition", | ||
| }; | ||
|
|
||
| cursorPositonStatusLabel = new Label | ||
| { | ||
| AutomationId = "CursorPositionStatusLabel", | ||
| Text = "Cursor Position: 0", | ||
| FontSize = 16, | ||
| }; | ||
|
|
||
| Button button = new Button | ||
| { | ||
| AutomationId = "ValidateEntryCursorPositionBtn", | ||
| Text = "Validate Entry Cursor Position", | ||
| }; | ||
|
|
||
| button.Clicked += (sender, e) => | ||
| { | ||
| cursorPositonStatusLabel.Text = $"{entry.CursorPosition}"; | ||
| }; | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Padding = new Thickness(20), | ||
| Spacing = 10, | ||
| Children = { entry, cursorPositonStatusLabel, button } | ||
| }; | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20911.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue20911 : _IssuesUITest | ||
| { | ||
| public Issue20911(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "Updating text in the Entry does not update CursorPosition during the TextChanged event"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Entry)] | ||
| public void VerifyEntryCursorPositionOnTextChanged() | ||
| { | ||
| App.WaitForElement("ValidateEntryCursorPosition"); | ||
|
|
||
| App.EnterText("ValidateEntryCursorPosition", "Test"); | ||
|
|
||
| App.WaitForElement("ValidateEntryCursorPositionBtn"); | ||
| App.Tap("ValidateEntryCursorPositionBtn"); | ||
|
|
||
| var cursorPositionStatus = App.FindElement("CursorPositionStatusLabel").GetText(); | ||
| Assert.That(cursorPositionStatus, Is.EqualTo("4")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entry and Editor both implement
ITextInput. Does Editor on iOS have the same issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz , I have checked it in the editor, and the issue does not reproduce there. While typing in the editor, the OnSelectionChanged method is called from the native side, which updates the cursor position. A reference video is attached below.
Editor.mov