Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades .NET 9 Arcade tool and SDK versions across build configurations, adds package source mapping scaffolding, and injects conditional PME service connection settings in the job template.
- Bumped
dotnetand Arcade/Helix SDK versions inglobal.json,eng/Versions.props, andeng/Version.Details.xml - Introduced an empty
<packageSourceMapping>section ineng/common/internal/NuGet.config - Added Azure Pipelines conditional logic for
ConnectedPMEServiceNameineng/common/core-templates/job/job.yml
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updated dotnet tool and Arcade/Helix SDK prerelease versions |
| eng/common/internal/NuGet.config | Added <packageSourceMapping> with a <clear /> directive |
| eng/common/core-templates/job/job.yml | Added conditional ConnectedPMEServiceName based on project |
| eng/Versions.props | Bumped dependency version props to 9.0.0-beta.25325.4 |
| eng/Version.Details.xml | Updated toolset dependency versions and SHAs |
Comments suppressed due to low confidence (1)
eng/common/core-templates/job/job.yml:137
- Azure Pipelines template expressions (${{ }}) run at compile time and cannot evaluate runtime variables. To branch on
System.TeamProject, use a runtime expression (e.g.,$[ eq(variables['System.TeamProject'], 'DevDiv') ]) or refactor into a template parameter.
${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
| <add key="dotnet-core-internal-tooling" value="https://pkgs.dev.azure.com/devdiv/_packaging/dotnet-core-internal-tooling/nuget/v3/index.json" /> | ||
| </packageSources> | ||
| <packageSourceMapping> | ||
| <clear /> |
There was a problem hiding this comment.
Introducing an empty with only will remove all default mappings and could prevent package resolution. Consider defining the necessary elements or delaying the insertion until mappings are ready.
Suggested change
| <clear /> | |
| <clear /> | |
| <package pattern="dotnet-core-internal-tooling/*" source="dotnet-core-internal-tooling" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Use darc to update the arcade bits |
This pull request updates several dependencies and configurations across multiple files to ensure compatibility with newer versions and improve project setup. The most important changes involve upgrading dependencies, modifying configuration files, and adding conditional logic for PME service connections.
Dependency Updates:
eng/Version.Details.xmlto version9.0.0-beta.25325.4, includingMicrosoft.DotNet.Build.Tasks.Feed,Microsoft.DotNet.Arcade.Sdk,Microsoft.DotNet.Build.Tasks.Installers, and others. Corresponding SHA values were updated as well.eng/Versions.propsto align with the new dependency versions, such asMicrosoftDotNetBuildTasksFeedVersionandMicrosoftDotNetRemoteExecutorPackageVersion.dotnettool version to9.0.107and upgraded related SDK versions inglobal.json.Configuration Changes:
eng/common/core-templates/job/job.ymlto setConnectedPMEServiceNamebased on theSystem.TeamProjectvariable. This ensures proper service connection configuration for different projects.<packageSourceMapping>section ineng/common/internal/NuGet.configwith a<clear />directive, preparing the configuration for future package source mappings.