Skip to content

Revert "Fixed picker allows user input if the keyboard is visible" #30447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
+2 −71
Merged

Revert "Fixed picker allows user input if the keyboard is visible" #30447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed ...ndroid.Tests/snapshots/android/PickerShouldNotAllowUserInputThroughKeyboard.png
View file
Open in desktop
Binary file not shown.
29 changes: 0 additions & 29 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue24930.cs
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24930.cs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/Core/src/Platform/Android/PickerManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ public static void OnFocusChanged(bool gainFocus, EditText sender)

static void OnKeyPress(object? sender, AView.KeyEventArgs e)
{
//To prevent user from entering text when focus is received
e.Handled = true;
if (!AvailableKeys.Contains(e.KeyCode))
{
e.Handled = false;
return;
}
e.Handled = true;
(sender as AView)?.CallOnClick();
}

Expand Down