Fix iOS Entry password text loss when toggling IsPassword while focused#30327
Closed
Fix iOS Entry password text loss when toggling IsPassword while focused#30327
Conversation
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Entry with IsPassword toggling loses previously entered text on iOS when IsPassword is re-enabled
Fix iOS Entry password text loss when toggling IsPassword while focused
Jun 30, 2025
Contributor
|
It would be nice to also keep the cursor position when toggling. |
Contributor
|
Closed as favour of #30572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
This PR fixes an iOS-specific issue where an Entry with
IsPassword=truewould lose previously entered text when toggling password visibility while the field is focused.Problem
On iOS, when following these steps:
IsPassword = falseto show the textIsPassword = trueto hide the text againThe previously entered text would be lost, resulting in only "456" instead of the expected "password123456".
Root Cause
The issue was in the
UpdateIsPasswordmethod inTextFieldExtensions.csfor iOS. When toggling back to password mode while the field is focused, the existing workaround code:textField.Enabled = false)textField.SecureTextEntry = true)textField.Enabled = entry.IsEnabled)textField.BecomeFirstResponder())This disable/enable cycle on iOS was inadvertently clearing the text field content.
Solution
Added minimal text preservation logic that:
Testing
PasswordTogglingPreservesTextWhenFocusedinEntryHandlerTests.iOS.csIssue30085.csfor validationImpact
Fixes #30085.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.