Skip to content

[iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix #29999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2025
+13 −8
Merged

[iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix #29999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e737ed
[iOS]CarouselView Position Not Respected When Changing From Hidden to…
kubaflo Jun 15, 2025
efcdee6
Update CarouselViewUpdatePosition.xaml
kubaflo Jun 15, 2025
37fac1c
Update CarouselViewUpdatePosition.xaml
kubaflo Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,13 @@ async Task UpdateInitialPosition()
return;
}

if(!ItemsView.IsVisible)
{
// If the CarouselView is not visible we don't want to set the initial position
// since it will be set when the CarouselView becomes visible
return;
}

if (ItemsSource is null)
{
return;
Expand Down
14 changes: 6 additions & 8 deletions src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdatePosition.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,31 +12,29 @@
BackgroundColor="Black"
TextColor="White"
Text="Tap the Button. If the item selected in the CarouselView is Item 4, the test has passed."/>
<!-- This functionality failed in CarouselView2. Reference: https://github.com/dotnet/maui/issues/29309 -->
<!-- TODO: Replace CarouselView1 with CarouselView once the issues mentioned in the GitHub issue are resolved. -->
<local:CarouselView1
<CarouselView
x:Name="carousel"
IsSwipeEnabled="True"
Position="3"
IsVisible="False">
<local:CarouselView1.ItemTemplate>
<CarouselView.ItemTemplate>
<DataTemplate>
<Label
Text="{Binding}"
FontSize="Large"
HorizontalOptions="CenterAndExpand"/>
</DataTemplate>
</local:CarouselView1.ItemTemplate>
<local:CarouselView1.ItemsSource>
</CarouselView.ItemTemplate>
<CarouselView.ItemsSource>
<x:Array Type="{x:Type x:String}">
<x:String>Item 1</x:String>
<x:String>Item 2</x:String>
<x:String>Item 3</x:String>
<x:String>Item 4</x:String>
<x:String>Item 5</x:String>
</x:Array>
</local:CarouselView1.ItemsSource>
</local:CarouselView1>
</CarouselView.ItemsSource>
</CarouselView>
<Button
AutomationId="AppearButton"
Text="Appear"
Expand Down