[.NET10] Obsolete Page.IsBusy API#29935
Merged
mattleibow merged 17 commits intodotnet:net10.0from Jul 21, 2025
Merged
Conversation
dotnet-policy-service
bot
added
community ✨
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Tamilarasan-Paranthaman
force-pushed
the
Page-IsBusy-IndicatorView
branch
from
7ffa50b to
85a65de
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing busy indicators on iOS and Windows when Page.IsBusy is toggled, aligns behavior with Android, and adds support in the UI test suite.
- Adds
PageBusyIndicatorIsVisible/PageBusyIndicatorIsNotVisiblehelpers in Appium test extensions. - Introduces a new UI test and host app sample for Issue 29925.
- Replaces the deprecated network activity indicator on iOS and implements
ProgressRingon Windows inAlertManager.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/TestUtils/src/UITest.Appium/HelperExtensions.cs | Added methods to wait for the busy indicator in cross-platform tests. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29925.cs | New UITest verifying busy indicator visibility toggles. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29925.cs | Sample page with a button to toggle IsBusy and automation IDs. |
| src/Controls/src/Core/Platform/AlertManager/AlertManager.iOS.cs | Removed the deprecated NetworkActivityIndicatorVisible, added an overlay with UIActivityIndicatorView. |
| src/Controls/src/Core/Platform/AlertManager/AlertManager.Windows.cs | Implemented a ProgressRing overlay for busy indication on Windows. |
Comments suppressed due to low confidence (1)
src/TestUtils/src/UITest.Appium/HelperExtensions.cs:2524
- [nitpick] It may be helpful to add an else clause that throws or logs when running on an unsupported platform, to avoid silent failures if no element is awaited.
public static void PageBusyIndicatorIsVisible(this IApp app, TimeSpan? timeout = null)
src/Controls/src/Core/Platform/AlertManager/AlertManager.Windows.cs
Outdated
Show resolved
Hide resolved
PureWeen
requested changes
Jun 13, 2025
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
@Tamilarasan-Paranthaman I think we're going to go the direction of obsoleting this API
Can you obsolete the Page.IsBusy API in NET10 and just indicate that we are going to remove it in NET11
Tamilarasan-Paranthaman
force-pushed
the
Page-IsBusy-IndicatorView
branch
from
6132ae2 to
aa8f191
Compare
Tamilarasan-Paranthaman
changed the title
Member
Author
@PureWeen, I have marked the |
mattleibow
requested changes
Jun 22, 2025
jsuarezruiz
suggested changes
Jun 24, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Need to update the PageTests. With the changes we have a build error:
C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\Page\PageTests.cs(90,4): error CS0618: 'Page.IsBusy' is obsolete: 'Page.IsBusy has been deprecated and will be removed in .NET 11' [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-windows10.0.19041.0]
C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\Page\PageTests.cs(90,4): error CS0618: 'Page.IsBusy' is obsolete: 'Page.IsBusy has been deprecated and will be removed in .NET 11' [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-android]
C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\Page\PageTests.cs(90,4): error CS0618: 'Page.IsBusy' is obsolete: 'Page.IsBusy has been deprecated and will be removed in .NET 11' [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net10.0-windows10.0.20348.0]
3 Error(s)
Member
Author
@jsuarezruiz, the build error has been resolved. |
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
Contributor
|
🚨 API change(s) detected @davidortinau FYI |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
github-actions
bot
force-pushed
the
Page-IsBusy-IndicatorView
branch
from
043e961 to
9be40fb
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
reviewed
Jul 15, 2025
rmarinho
approved these changes
Jul 15, 2025
mattleibow
approved these changes
Jul 21, 2025
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Issues Fixed
Fixes #30155