Conversation
rmarinho
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect public API signatures for the XmlnsDefinitionAttribute by replacing the "target" parameter with the correct "clrNamespace" parameter in the shipped PublicAPI files.
- Corrects the public API constructor signature in PublicAPI files for multiple platforms.
- Removes deprecated API signatures and ensures consistency across shipped files.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
| src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
| src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
| src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
| src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
| src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Shipped.txt | Updated XmlnsDefinitionAttribute signature (changed "target" to "clrNamespace"). |
mattleibow
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The XmlnsDefinitonAttribute PR had some changes to the shipped public file that were incorrect.
Issues Fixed
Fixes PublicApi files