-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView #29660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rmarinho
merged 5 commits into
dotnet:inflight/current
from
SyedAbdulAzeemSF4852:fix-29472
May 30, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fae3d8e
[Windows] Fix for ItemsSource Does Not Dynamically Set to null in Car…
SyedAbdulAzeemSF4852 4363892
Have added test case
SyedAbdulAzeemSF4852 69383b1
Updated AutomationId for better clarity and readability
SyedAbdulAzeemSF4852 9bef0dc
Have modified the context of the description label
SyedAbdulAzeemSF4852 56edd75
Have committed the snapshots
SyedAbdulAzeemSF4852 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+48.3 KB
...oid.Tests/snapshots/android/VerifyCarouselViewItemsSourceClearedDynamically.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| namespace Controls.TestCases.HostApp.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 29472, "ItemsSource is not dynamically cleared in the CarouselView", PlatformAffected.UWP)] | ||
| public class Issue29472 : ContentPage | ||
| { | ||
| public Issue29472() | ||
| { | ||
| Label descriptionLabel = new Label | ||
| { | ||
| Text = "The test passes if the previously bound items are cleared from the view when the ItemsSource is dynamically set to null; otherwise, it fails.", | ||
| FontSize = 16, | ||
| HorizontalOptions = LayoutOptions.Center | ||
| }; | ||
|
|
||
| CarouselView carouselView = new CarouselView | ||
| { | ||
| ItemsSource = new List<string> { "Item1", "Item2" }, | ||
| Loop = false, | ||
| ItemTemplate = new DataTemplate(() => | ||
| { | ||
| Label label = new Label | ||
| { | ||
| FontSize = 24, | ||
| BackgroundColor = Colors.LightGray, | ||
| Margin = new Thickness(10) | ||
| }; | ||
|
|
||
| label.SetBinding(Label.TextProperty, "."); | ||
| return label; | ||
| }), | ||
| }; | ||
|
|
||
| Button clearItemsSource = new Button | ||
| { | ||
| AutomationId = "ClearItemsSourceBtn", | ||
| Text = "Set the ItemsSource of the CarouselView to null", | ||
| HorizontalOptions = LayoutOptions.Center | ||
| }; | ||
|
|
||
| clearItemsSource.Clicked += (s, e) => | ||
| { | ||
| carouselView.ItemsSource = null; | ||
| }; | ||
|
|
||
| Grid grid = new Grid | ||
| { | ||
| Padding = 20, | ||
| RowSpacing = 15, | ||
| RowDefinitions = | ||
| { | ||
| new RowDefinition { Height = GridLength.Auto }, | ||
| new RowDefinition { Height = GridLength.Auto }, | ||
| new RowDefinition { Height = GridLength.Star }, | ||
| } | ||
| }; | ||
|
|
||
| grid.Add(descriptionLabel, 0, 0); | ||
| grid.Add(clearItemsSource, 0, 1); | ||
| grid.Add(carouselView, 0, 2); | ||
|
|
||
| Content = grid; | ||
| } | ||
| } |
Binary file added
BIN
+26.6 KB
...ses.Mac.Tests/snapshots/mac/VerifyCarouselViewItemsSourceClearedDynamically.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29472.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue29472 : _IssuesUITest | ||
| { | ||
| public Issue29472(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "ItemsSource is not dynamically cleared in the CarouselView"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.CarouselView)] | ||
| public void VerifyCarouselViewItemsSourceClearedDynamically() | ||
| { | ||
| App.WaitForElement("ClearItemsSourceBtn"); | ||
| App.Tap("ClearItemsSourceBtn"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
Binary file added
BIN
+11.9 KB
...nUI.Tests/snapshots/windows/VerifyCarouselViewItemsSourceClearedDynamically.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+54.1 KB
...ses.iOS.Tests/snapshots/ios/VerifyCarouselViewItemsSourceClearedDynamically.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.