[android] update AOT profiles for .NET 10 #29612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: jonathanpeppers/Mono.Profiler.Android#23 This is an initial Mono AOT profile for .NET 10. I had to build a .NET 10 version of `libmono-profiler-aot.so` and release a 10.0.0-preview1 `Mono.AotProfiler.Android` NuGet package. Others will be able to update these more easily in the future. An average of 10 runs on a Pixel 7 of `dotnet new maui`: Before: Average(ms): 486.4 Std Err(ms): 5.12770253947451 Std Dev(ms): 16.2152191885689 After: Average(ms): 462.2 Std Err(ms): 3.69022733415948 Std Dev(ms): 11.6695234597552 This is reasonable compared to the numbers I recently got for .NET 9: * 6fc44fb
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Mono AOT profiling setup for .NET 10 by bumping the profiler package dependency and adding troubleshooting guidance.
- Bump
Mono.AotProfiler.Androidpackage from 9.0.0-preview1 to 10.0.0-preview1 - Add a new “Troubleshooting” section to the README with logging and troubleshooting steps
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ProfiledAot/src/Directory.Build.targets | Updated PackageReference to 10.0.0-preview1 |
| src/ProfiledAot/README.md | Added troubleshooting instructions |
Comments suppressed due to low confidence (1)
src/ProfiledAot/README.md:86
- The README refers to commenting out a
debug.mono.logsetting inDirectory.Build.targets, but that file does not include such a setting. Please clarify the correct file or add the instruction where the property is configured.
`src\ProfiledAot\src\Directory.Build.targets` that sets
rmarinho
approved these changes
May 21, 2025
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
Oh thats why I tried I couldn't t get results. I think it was the Directory.Build.targets
jonathanpeppers
commented
May 21, 2025
| <Compile Include="$(MSBuildThisFileDirectory)CommonMethods.cs" /> | ||
| <AndroidAotProfile Include="custom.aprof" /> | ||
| <PackageReference Include="Mono.AotProfiler.Android" Version="9.0.0-preview1" /> | ||
| <PackageReference Include="Mono.AotProfiler.Android" Version="10.0.0-preview1" /> |
Member
Author
There was a problem hiding this comment.
Yeah, I didn't create this package until today, when it didn't work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: jonathanpeppers/Mono.Profiler.Android#23
This is an initial Mono AOT profile for .NET 10.
I had to build a .NET 10 version of
libmono-profiler-aot.soand release a 10.0.0-preview1Mono.AotProfiler.AndroidNuGet package. Others will be able to update these more easily in the future.An average of 10 runs on a Pixel 7 of
dotnet new maui:This is reasonable compared to the numbers I recently got for .NET 9: