-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fixed OnNavigatedTo not triggered for tabs in More section of TabbedPage #29495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
911b5dc
Fixed-16175 : OnNavigatedTo not called on iOS on tabs placed in the M…
Vignesh-SF3580 1a0f0e1
Added testcases.
Vignesh-SF3580 ca5c309
updated testcase.
Vignesh-SF3580 ff3cf40
Testcase updated.
Vignesh-SF3580 2acc2bf
Updated testcase.
Vignesh-SF3580 2f2972c
Modified testcases
Vignesh-SF3580 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 16175, "OnNavigatedTo event triggered in More tabs", PlatformAffected.iOS)] | ||
|
|
||
| public class Issue16175 : TabbedPage | ||
| { | ||
| public Issue16175() | ||
| { | ||
| for (var i = 0; i < 10; i++) | ||
| { | ||
| var page = new Issue16175Page { Title = $"Tab{i + 1}" }; | ||
| Children.Add(page); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public class Issue16175Page : ContentPage | ||
| { | ||
| Label _navigatedToLabel; | ||
|
|
||
| public Issue16175Page() | ||
| { | ||
| _navigatedToLabel = new Label { Text = "NavigatedTo: Not triggered", AutomationId = "navigatedToLabel" }; | ||
|
|
||
| Content = new VerticalStackLayout | ||
| { | ||
| Children = { _navigatedToLabel } | ||
| }; | ||
| } | ||
|
|
||
| protected override void OnNavigatedTo(NavigatedToEventArgs args) | ||
| { | ||
| if (Title is not null && Title == "Tab8" && _navigatedToLabel is not null) | ||
| { | ||
| _navigatedToLabel.Text = "NavigatedTo: Triggered"; | ||
| } | ||
| base.OnNavigatedTo(args); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16175.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID // More tab is available in Mac and iOS | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue16175 : _IssuesUITest | ||
| { | ||
| public Issue16175(TestDevice device) : base(device) | ||
| { | ||
| } | ||
| public override string Issue => "OnNavigatedTo event triggered in More tabs"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.TabbedPage)] | ||
| public void TabEventsTriggeredInMoreTab() | ||
| { | ||
| App.TapTab("More"); | ||
| App.TapTab("Tab8"); | ||
| var navigatedToLabel = App.WaitForElement("navigatedToLabel"); | ||
| Assert.That(navigatedToLabel.GetText(), Is.EqualTo("NavigatedTo: Triggered")); | ||
| } | ||
| } | ||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does checking for "More" also works if the device is set to a language other than English?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jabbah76 Yes, I tested by changing the device language to a non-English language, and it works as expected.