Skip to content

[iOS, Mac] Exception should be thrown when shell item is null #29464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarishwaranVijayakumar wants to merge 6 commits into from
Closed

[iOS, Mac] Exception should be thrown when shell item is null #29464

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b036190
Fix for Shell flyout exception
HarishwaranVijayakumar May 7, 2025
c9e56de
Update ShellRenderer.cs
HarishwaranVijayakumar May 8, 2025
1985909
Revert "Fix for Shell flyout exception"
HarishwaranVijayakumar May 8, 2025
a71c237
Adding TestCase
HarishwaranVijayakumar May 13, 2025
e784301
Revert "Adding TestCase"
HarishwaranVijayakumar May 13, 2025
7c35f06
Exception Message update
HarishwaranVijayakumar May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ void SetupCurrentShellItem()
{
if (Shell.CurrentItem == null)
{
return;
throw new InvalidOperationException($"Content not found for active {Shell}. Title: {Shell.Title}. Route: {Shell.Route}.");

@jsuarezruiz jsuarezruiz May 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is aligning the behavior with other platforms?

@HarishwaranVijayakumar HarishwaranVijayakumar May 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz Yes on Android, InvalidOperationException is thrown. On windows, this pr #28879 will ensure the same behavior

}
else if (_currentShellItemRenderer == null)
{
Expand Down