Skip to content

Conversation

@rmarinho
Copy link
Member

@rmarinho rmarinho commented May 5, 2025

Description of Change

Try add a test for #29320

Issues Fixed

Fixes #

Copilot AI review requested due to automatic review settings May 5, 2025 14:26
@rmarinho rmarinho added the area-testing Unit tests, device tests label May 5, 2025
@rmarinho rmarinho requested a review from a team as a code owner May 5, 2025 14:26
@rmarinho rmarinho requested review from PureWeen and jfversluis May 5, 2025 14:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CoreCLR test case for the SF sample to address testing improvements mentioned in issue #29320.

  • Added a new test case using the parameter "--sample-content" with "UseMonoRuntime=false" in Release configuration.
  • A Debug test case for the same scenario is commented out with a note indicating it's not ready yet.
Comments suppressed due to low confidence (1)

src/TestUtils/src/Microsoft.Maui.IntegrationTests/SimpleTemplateTest.cs:18

  • Ensure that this new test case is adequately reflected in both TestCases.HostApp and TestCases.Shared.Tests to maintain consistency in automated testing.
[TestCase("maui", DotNetCurrent, "Release", false, "--sample-content", "UseMonoRuntime=false")]

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add one for the non --sample-content one? And Blazor?

@matouskozak matouskozak self-requested a review May 5, 2025 15:29
matouskozak
matouskozak previously approved these changes May 5, 2025
@rmarinho
Copy link
Member Author

rmarinho commented May 6, 2025

@jonathanpeppers https://dev.azure.com/xamarin/public/_build/results?buildId=141123&view=ms.vss-test-web.build-test-results-tab&runId=4089349&resultId=100050&paneView=attachments do I need to enable something? or the error is correct ?

/Users/builder/azdo/_work/1/s/.dotnet/sdk/10.0.100-preview.5.25251.105/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(525,5): error NETSDK1082: There was no runtime pack for Microsoft.NETCore.App available for the specified RuntimeIdentifier 'iossimulator-arm64'. [/Users/builder/azdo/_work/_temp/test-dir/Buildmauinet1002042431682/Buildmauinet1002042431682.csproj::TargetFramework=net10.0-ios]
/Users/builder/azdo/_work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/36.0.0-preview.4.77/tools/Xamarin.Android.Common.targets(570,3): error XA1040: The CoreCLR runtime on Android is an experimental feature and not yet suitable for production use. File issues at: https://github.com/dotnet/android/issues [/Users/builder/azdo/_work/_temp/test-dir/Buildmauinet1002042431682/Buildmauinet1002042431682.csproj::TargetFramework=net10.0-android]
/Users/builder/azdo/_work/1/s/.dotnet/sdk/10.0.100-preview.5.25251.105/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(525,5): error NETSDK1082: There was no runtime pack for Microsoft.NETCore.App available for the specified RuntimeIdentifier 'maccatalyst-x64'. [/Users/builder/azdo/_work/_temp/test-dir/Buildmauinet1002042431682/Buildmauinet1002042431682.csproj::TargetFramework=net10.0-maccatalyst]
    0 Warning(s)
    3 Error(s)

build-133909314535259630.binlog.zip

@jonathanpeppers
Copy link
Member

@rmarinho you will need to remove all ios and maccatalyst TargetFrameworks for the project to ubild, as the CoreCLR packs mentioned do not exist.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have TreatWarningsAsErrors you will need to pass -p:EnablePreviewFeatures=true:

/Users/builder/azdo/_work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/36.0.0-preview.4.77/tools/Xamarin.Android.Common.targets(570,3): error XA1040: The CoreCLR runtime on Android is an experimental feature and not yet suitable for production use. File issues at: https://github.com/dotnet/android/issues

@rmarinho
Copy link
Member Author

rmarinho commented Jun 5, 2025

@rmarinho rmarinho merged commit 3784aaf into net10.0 Jun 6, 2025
125 of 129 checks passed
@rmarinho rmarinho deleted the add-coreclr-test branch June 6, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants