-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[tests] Add coreclr test for SF sample #29327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new CoreCLR test case for the SF sample to address testing improvements mentioned in issue #29320.
- Added a new test case using the parameter "--sample-content" with "UseMonoRuntime=false" in Release configuration.
- A Debug test case for the same scenario is commented out with a note indicating it's not ready yet.
Comments suppressed due to low confidence (1)
src/TestUtils/src/Microsoft.Maui.IntegrationTests/SimpleTemplateTest.cs:18
- Ensure that this new test case is adequately reflected in both TestCases.HostApp and TestCases.Shared.Tests to maintain consistency in automated testing.
[TestCase("maui", DotNetCurrent, "Release", false, "--sample-content", "UseMonoRuntime=false")]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add one for the non --sample-content one? And Blazor?
|
@jonathanpeppers https://dev.azure.com/xamarin/public/_build/results?buildId=141123&view=ms.vss-test-web.build-test-results-tab&runId=4089349&resultId=100050&paneView=attachments do I need to enable something? or the error is correct ? |
|
@rmarinho you will need to remove all |
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have TreatWarningsAsErrors you will need to pass -p:EnablePreviewFeatures=true:
/Users/builder/azdo/_work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Darwin/36.0.0-preview.4.77/tools/Xamarin.Android.Common.targets(570,3): error XA1040: The CoreCLR runtime on Android is an experimental feature and not yet suitable for production use. File issues at: https://github.com/dotnet/android/issues
eea386d to
d3b79fe
Compare
Description of Change
Try add a test for #29320
Issues Fixed
Fixes #