-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fix for the FontImageSource color is not applied properly to the Bottom Tab Icon #29317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+27.4 KB
...hots/android/DynamicFontImageSourceColorShouldApplyOnBottomTabIconOnAndroid.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+27.4 KB
...s/snapshots/android/FontImageSourceColorShouldApplyOnBottomTabIconOnAndroid.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
122 changes: 122 additions & 0 deletions
122
src/Controls/tests/TestCases.HostApp/Issues/Issue29109.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| using Microsoft.Maui.Controls.PlatformConfiguration.AndroidSpecific; | ||
| using Button = Microsoft.Maui.Controls.Button; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 29109, "[Android] Unable to set unselected iconImageSource color when toolbar placement is set to bottom", PlatformAffected.Android)] | ||
| public class Issue29109 : TestTabbedPage | ||
| { | ||
| protected override void Init() | ||
| { | ||
| // Set the toolbar placement to bottom (android specific) | ||
| On<Microsoft.Maui.Controls.PlatformConfiguration.Android>().SetToolbarPlacement(Microsoft.Maui.Controls.PlatformConfiguration.AndroidSpecific.ToolbarPlacement.Bottom); | ||
| // Set tab colors | ||
| this.SelectedTabColor = Colors.Red; | ||
| this.UnselectedTabColor = Colors.Gray; | ||
|
|
||
| // Add tabs | ||
| this.Children.Add(new Issue29109Tab1()); | ||
| this.Children.Add(new Issue29109Tab2()); | ||
| this.Children.Add(new Issue29109Tab3()); | ||
| } | ||
| } | ||
|
|
||
| public class Issue29109Tab1 : ContentPage | ||
| { | ||
| public Issue29109Tab1() | ||
| { | ||
| //If no FontImageSource color is given, tab icon should be applied based on the SelectedTabColor and UnselectedTabColor. | ||
| IconImageSource = new FontImageSource | ||
| { | ||
| FontFamily = "Ion", | ||
| Glyph = "\uf47e", | ||
| Size = 15 | ||
| }; | ||
| Button button = new Button | ||
| { | ||
| Text = "Change Tab Icon Color", | ||
| BackgroundColor = Colors.Green, | ||
| TextColor = Colors.White | ||
| }; | ||
| button.AutomationId = "Button"; | ||
| button.Clicked += (s, e) => | ||
| { | ||
| //If the FontImageSource color is given, the tab icon color should be applied solely based on the specified color, regardless of the SelectedTabColor or UnselectedTabColor. | ||
| (this.IconImageSource as FontImageSource).Color = Colors.Orange; | ||
| }; | ||
| Title = "Tab 1"; | ||
| var verticalStackLayout = new VerticalStackLayout | ||
| { | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = { | ||
| new Label | ||
| { | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| Text = "Tab 1" | ||
| }, | ||
| button | ||
| } | ||
|
|
||
| }; | ||
| Content = verticalStackLayout; | ||
| } | ||
| } | ||
|
|
||
| public class Issue29109Tab2 : ContentPage | ||
| { | ||
| public Issue29109Tab2() | ||
| { | ||
| //The FontImageSource color is given. So, the tab icon color should be applied based solely on the given color, regardless of the selected tab or unselected tab color. | ||
| IconImageSource = new FontImageSource | ||
| { | ||
| FontFamily = "Ion", | ||
| Glyph = "\uf47e", | ||
| Color = Colors.DodgerBlue, | ||
| Size = 15 | ||
| }; | ||
|
|
||
| Title = "Tab 2"; | ||
| var verticalStackLayout = new VerticalStackLayout | ||
| { | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| Text = "Tab 2" | ||
| }, | ||
| } | ||
| }; | ||
| Content = verticalStackLayout; | ||
| } | ||
| } | ||
| public class Issue29109Tab3 : ContentPage | ||
| { | ||
| public Issue29109Tab3() | ||
| { | ||
| //The FontImageSource color is given. So, the icon color should be applied based solely on the given color, regardless of the selected tab or unselected tab color. | ||
| IconImageSource = new FontImageSource | ||
| { | ||
| FontFamily = "Ion", | ||
| Glyph = "\uf47e", | ||
| Color = Colors.Green, | ||
| Size = 15 | ||
| }; | ||
|
|
||
| Title = "Tab 3"; | ||
| var verticalStackLayout = new VerticalStackLayout | ||
| { | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| Text = "Tab 3" | ||
| }, | ||
| } | ||
| }; | ||
| Content = verticalStackLayout; | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29109.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #if ANDROID | ||
| //Since bottom tab placement is specific to Android, I enabled it only for Android: https://learn.microsoft.com/en-us/dotnet/maui/android/platform-specifics/tabbedpage-toolbar-placement?view=net-maui-9.0 | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| public class Issue29109 : _IssuesUITest | ||
| { | ||
| public Issue29109(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "[Android] Unable to set unselected iconImageSource color when toolbar placement is set to bottom"; | ||
|
|
||
| [Test, Order(1)] | ||
| [Category(UITestCategories.TabbedPage)] | ||
| public void FontImageSourceColorShouldApplyOnBottomTabIconOnAndroid() | ||
| { | ||
| App.WaitForElement("Button"); | ||
| VerifyScreenshot(); | ||
| } | ||
|
|
||
| [Test, Order(2)] | ||
| [Category(UITestCategories.TabbedPage)] | ||
| public void DynamicFontImageSourceColorShouldApplyOnBottomTabIconOnAndroid() | ||
| { | ||
| App.WaitForElement("Button"); | ||
| App.Tap("Button"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| } | ||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.