Fix iOS Label being truncated when using Padding #29031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albyrock87
commented
Apr 16, 2025
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ValidateTableViewTitles.png
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
github-actions
bot
force-pushed
the
fix-ios-maui-label-padding
branch
from
506974d to
5ce1591
Compare
Member
|
@albyrock87 I see this PR is for a closed issue. Is this a new issue that was introduced or a refinement of the fix? Is there a better issue to reference? |
Member
|
@Dhivya-SF4094 FYI |
mattleibow
requested changes
May 23, 2025
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
Just marking red so I can make sure that this is correct after the PR for the same issue.
github-project-automation
bot
moved this from Ready To Review
to Changes Requested
in MAUI SDK Ongoing
Contributor
Author
|
@mattleibow this is a refinement of that fix which didn't fully cover the topic. |
albyrock87
force-pushed
the
fix-ios-maui-label-padding
branch
from
5ce1591 to
8912a80
Compare
albyrock87
force-pushed
the
fix-ios-maui-label-padding
branch
from
8912a80 to
7b83b49
Compare
Contributor
Author
|
@mattleibow I should have addressed your concerns |
mattleibow
approved these changes
May 27, 2025
github-project-automation
bot
moved this from Changes Requested
to Approved
in MAUI SDK Ongoing
Member
|
/azp run MAUI-DeviceTests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Seems this was fixed by #28081 |
rmarinho
approved these changes
May 29, 2025
github-project-automation
bot
moved this from In Progress
to Approved
in MAUI SDK Ongoing
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes iOS Label being truncated when using padding under some conditions.
Issues Fixed
Fixes #28180