Conversation
jsuarezruiz
added
the
area-single-project
rmarinho
requested changes
Apr 15, 2025
| catch (Exception ex) | ||
| { | ||
| Log.LogError(null, "MAUI0000", null, null, 0, 0, 0, 0, ex.ToString()); | ||
| Log.LogError("Apple Resource Processing", "MAUIR0005", null, null, 0, 0, 0, 0, $"Error occurred in processing Apple-specific storyboard resources. {ex.ToString()}"); |
Member
There was a problem hiding this comment.
Should we add these to a Resource files so we can translate these errors using OneLoc?
Contributor
Author
There was a problem hiding this comment.
Could you provide more details? Should I add .resx files for localization? If so, how many languages should be included? Should I handle the translations myself using tools or AI, or would it be better to coordinate with someone for more accurate translations?
Member
There was a problem hiding this comment.
you just add 1 resx the others will be generated by OneLoc tool . we have a service that handles the translations.
Contributor
Author
There was a problem hiding this comment.
Nice, moved the error messages to a resx file and also create a class with constants for the error codes.
rmarinho
approved these changes
May 27, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
rmarinho
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Improve MSBuild Error Actionability in Resizetizer. All the error used the MAUI0000 code. With the changes in this PR, the error codes have been updated to use a new format
MAUIRto indicate resizetizer as the category, and have a few new code numbers for the different types of errors in that.Issues Fixed
Fixes #27127