Skip to content

Conversation

@jsuarezruiz
Copy link
Contributor

Description of Change

Enable Nullability on ShellPageRendererTracker.

Issues Fixed

Fixes #27162

@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Mar 17, 2025
Copilot AI review requested due to automatic review settings March 17, 2025 11:04
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner March 17, 2025 11:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables nullability on ShellPageRendererTracker and updates related iOS renderer classes to improve null-safety. Key changes involve enabling #nullable in ShellPageRendererTracker, updating property types and event handler signatures to account for nullability, and minor refactoring in UIContainerView.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerView.cs Minor refactoring in Disconnect with added null-safety handling.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs Enabled #nullable, updated properties and event handler signatures, and adjusted toolbar/search handling for nullability.
Comments suppressed due to low confidence (1)

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs:835

  • Method name 'DettachSearchController' contains a typo; please consider renaming it to 'DetachSearchController'.
void DettachSearchController()


public bool IsRootPage { get; set; }

#nullable disable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are adding this here instead of fixing the all file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this properties are implementing the IShellPageRendererTracker interface. To add nullability here, we need to update the interface too.

@rmarinho
Copy link
Member

/rebase

@jsuarezruiz
Copy link
Contributor Author

All the iOS tests passed:
image

@jsuarezruiz jsuarezruiz requested a review from rmarinho May 28, 2025 10:51
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure we add brackets to all ifs ?

@jsuarezruiz jsuarezruiz requested a review from rmarinho May 28, 2025 13:13
@jsuarezruiz
Copy link
Contributor Author

Can we make sure we add brackets to all ifs ?

Have done the changes, could you review it again?

@rmarinho
Copy link
Member

/rebase

@rmarinho rmarinho merged commit 62888a3 into net10.0 May 30, 2025
127 of 129 checks passed
@rmarinho rmarinho deleted the fix-27162-II branch May 30, 2025 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout proposal/open

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants